Re: Review Request 124718: Baloo monitor fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124718/ --- (Updated Aug. 18, 2015, 2:26 a.m.) Status -- This change has been ma

Re: Review Request 124718: Baloo monitor fixes

> On Aug. 17, 2015, 7:56 p.m., Vishesh Handa wrote: > > Not exactly what I had in mind, but sure :) * Tried exposing the enum to qml, didn't work because enum was not declared in a QObject. * Tried to have the states as a property of the root obeject, didn't work out either. Though don't knonw

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/#review83970 --- It's very strange that this patch changes anything because ecm

Re: Review Request 124718: Baloo monitor fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124718/#review83963 --- Ship it! Not exactly what I had in mind, but sure :) - Vishe

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/#review83962 --- You only need to add ecm_mark_as_test in the non-automated tes

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review83960 --- Looks good. I didn't realize making the database global would

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 17, 2015, 6:32 p.m.) Review request for Baloo, Bhushan Shah

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review83956 --- src/engine/database.h (line 47)

Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- Review request for Baloo, Bhushan Shah and Vishesh Handa. Bugs: 350247

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- (Updated Aug. 17, 2015, 3:38 p.m.) Review request for Baloo. Changes --

Re: Review Request 124790: Port to ecm_mark_as_test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- (Updated Aug. 17, 2015, 3:13 p.m.) Review request for Baloo. Summary (u

Re: Review Request 124790: Respect -DBUILD_TESTING=OFF

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- (Updated Aug. 17, 2015, 3:13 p.m.) Review request for Baloo. Repository

Re: Review Request 124790: Respect -DBUILD_TESTING=OFF

Ecm internally should disable building the tests as long each executable is marked as a test. In the case of Baloo the manual tests are not marked. Could you please mark them? >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 124790: Respect -DBUILD_TESTING=OFF

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- Review request for Baloo. Repository: baloo Description --- Other

Re: Review Request 124718: Baloo monitor fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124718/ --- (Updated Aug. 17, 2015, 8:51 a.m.) Review request for Baloo and Vishesh H