----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/#review83962 -----------------------------------------------------------
You only need to add ecm_mark_as_test in the non-automated tests. autotests/benchmarks/CMakeLists.txt (line 1) <https://git.reviewboard.kde.org/r/124790/#comment58162> ecm_add_test internally marks the executable as a test. This is not required. - Vishesh Handa On Aug. 17, 2015, 3:38 p.m., Armin K. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124790/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 3:38 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > As requested by vhanda, I have marked all test executables with > ecm_mark_as_test and now -DBUILD_TESTING=OFF is respected. > > Note that I don't have commit access, and if this change gets accepted, I ask > that someone commits it. > > > Diffs > ----- > > CMakeLists.txt f81bb0f > autotests/benchmarks/CMakeLists.txt 40d8efd > autotests/integration/CMakeLists.txt 74a5965 > autotests/unit/codecs/CMakeLists.txt f65d633 > autotests/unit/engine/CMakeLists.txt 1339003 > autotests/unit/file/CMakeLists.txt cfcd041 > autotests/unit/lib/CMakeLists.txt 871bf8d > src/file/extractor/autotests/CMakeLists.txt 524026c > tests/file/CMakeLists.txt fb58bec > > Diff: https://git.reviewboard.kde.org/r/124790/diff/ > > > Testing > ------- > > I have verified that no files in tests and autotests subdir were built when > -DBUILD_TESTING=OFF was passed to cmake. > Everything was built when the mentioned build option wasn't used. > > > Thanks, > > Armin K. > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
