Re: Review Request 124699: Move file url export to main thread

2015-08-14 Thread Pinak Ahuja
> On Aug. 13, 2015, 9:27 p.m., Vishesh Handa wrote: > > src/file/extractorprocess.cpp, line 71 > > > > > > Could you please check if this is internally spawning an event loop? We > > want to avoid that. >From wh

Re: Review Request 124733: Fix build on FreeBSD

2015-08-14 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124733/ --- (Updated Aug. 14, 2015, 8:54 a.m.) Status -- This change has been ma

Re: Review Request 124733: Fix build on FreeBSD

2015-08-14 Thread Tobias Berner
> On Aug. 14, 2015, 9:53 a.m., David Faure wrote: > > Do you have a developer account, to push this fix? Nope, could you do it for me, thanks. - Tobias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: Review Request 124733: Fix build on FreeBSD

2015-08-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124733/#review83797 --- Ship it! Do you have a developer account, to push this fix?