> On Aug. 14, 2015, 9:53 a.m., David Faure wrote: > > Do you have a developer account, to push this fix?
Nope, could you do it for me, thanks. - Tobias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124733/#review83797 ----------------------------------------------------------- On Aug. 14, 2015, 7:03 a.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124733/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 7:03 a.m.) > > > Review request for Baloo and David Faure. > > > Repository: kfilemetadata > > > Description > ------- > > There is no implicit conversion to char* > > ==== build output ==== > [ 87%] Building CXX object > src/extractors/CMakeFiles/kfilemetadata_plaintextextractor.dir/plaintextextractor.cpp.o > /tmp/usr/ports/devel/kf5-kfilemetadata/work/kfilemetadata-5.13.0/src/extractors/plaintextextractor.cpp:102:19: > error: no matching constructor for initialization of 'std::ifstream' (aka > 'basic_ifstream<char>') > std::ifstream fstream(QFile::encodeName(result->inputUrl())); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/c++/v1/iosfwd:131:33: note: candidate constructor (the implicit > copy constructor) not viable: no known conversion from 'QByteArray' to 'const > std::__1::basic_ifstream<char, std::__1::char_traits<char> >' for 1st argument > class _LIBCPP_TYPE_VIS_ONLY basic_ifstream; > ^ > /usr/include/c++/v1/fstream:1008:14: note: candidate constructor not viable: > no known conversion from 'QByteArray' to 'const char *' for 1st argument > explicit basic_ifstream(const char* __s, ios_base::openmode __mode = > ios_base::in); > ^ > /usr/include/c++/v1/fstream:1009:14: note: candidate constructor not viable: > no known conversion from 'QByteArray' to 'const string' (aka 'const > basic_string<char, char_traits<char>, allocator<char> >') for 1st argument > explicit basic_ifstream(const string& __s, ios_base::openmode __mode = > ios_base::in); > ^ > /usr/include/c++/v1/fstream:1011:5: note: candidate constructor not viable: > no known conversion from 'QByteArray' to 'std::__1::basic_ifstream<char, > std::__1::char_traits<char> >' for 1st argument > basic_ifstream(basic_ifstream&& __rhs); > ^ > /usr/include/c++/v1/fstream:1007:5: note: candidate constructor not viable: > requires 0 arguments, but 1 was provided > basic_ifstream(); > ^ > 1 error generated. > *** Error code 1 > > > Diffs > ----- > > src/extractors/plaintextextractor.cpp 71d09ee > > Diff: https://git.reviewboard.kde.org/r/124733/diff/ > > > Testing > ------- > > Built locally > > > Thanks, > > Tobias Berner > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
