Re: Review Request 120657: Dublic core conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120657/ --- (Updated May 8, 2015, 6 a.m.) Status -- This change has been discard

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 8, 2015, 5:20 a.m.) Status -- This change has been mark

Re: Interested in contributing

Ralf, I took a look at the bugs and other parts of the links you sent me, what should I start reading up on next? John > On May 7, 2015, at 7:40 PM, Ralf Habacker wrote: > > Am 08.05.2015 um 02:09 schrieb John Freeman: >> Hi > Hi John, > >> I’m looking for a mentor to get started on KDE deve

Re: Interested in contributing

Am 08.05.2015 um 02:09 schrieb John Freeman: > Hi Hi John, > I’m looking for a mentor to get started on KDE development Working on an application (fixing bug or implementing feature requests) is a good starting point to get in touch with KDE development. > I have a reasonable amount of time to

Interested in contributing

Hi I’m looking for a mentor to get started on KDE development I have a reasonable amount of time to do this and experience in c++. Some interesting projects I’ve looked into are Baloo and Kate. Also if you have some suggestions other than those two I am open to that also. I have a background in

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80057 --- Ship it! Ship It! - Milian Wolff On May 7, 2015, 11:43 a.m

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 7, 2015, 11:43 a.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80027 --- src/engine/postingdb.cpp (line 285)

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80026 --- src/engine/postingdb.cpp (line 296)

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 380 > > > > > > auto, tyke comVal and com by value > > Pinak Ahuja wrote: > Same as above. > > Pinak Ahuja wrote: > ok

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 380 > > > > > > auto, tyke comVal and com by value > > Pinak Ahuja wrote: > Same as above. ok got passing integers by valu

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 324 > > > > > > use auto instead of Validator, otherwise you'll pay for the type erasure oh, now I get it, std::function uses t

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80012 --- yep, better and pretty close but not yet there :) thanks! s