Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 7:59 p.m., Milian Wolff wrote: > > src/engine/postingdb.h, line 55 > > > > > > could this be made private? and then a template function and take the > > Validator as a template arg? this would s

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 7, 2015, 4:53 a.m.) Review request for Baloo and Vishesh Han

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79986 --- src/engine/postingdb.h (line 55)

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.cpp, line 381 > > > > > > Maybe in a seperarate patch we want to use QByteArray::fromRawData or > > something and avoid the copy. Though

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79979 --- Ship it! Good job. If the tests are also passing, then ship i

Re: Interested in Contribution

El Dimarts, 5 de maig de 2015, a les 11:33:40, Kevin Funk va escriure: > On Tuesday 05 May 2015 02:08:15 Aleix Pol wrote: > > On Tue, May 5, 2015 at 1:48 AM, Claudio Autiero > > > > wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA1 > > > > > > Hi Alex & Albert, > > > > > > @Alex

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 6, 2015, 6:28 p.m.) Review request for Baloo and Vishesh Han

Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti