Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115007/ --- (Updated Jan. 15, 2014, 2:37 a.m.) Status -- This change has been ma

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115007/#review47421 --- This review has been submitted with commit 3994c4fb5251e51b17

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115006/ --- (Updated Jan. 15, 2014, 2:37 a.m.) Status -- This change has been ma

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115006/#review47422 --- This review has been submitted with commit 8994006ff7f03aa5dc

Announce: A useful d-bus analyzer

2014-01-14 Thread Andreas Hartmetz
Hello, I've worked on and off on an implementation of the d-bus protocol which, of course, needs a proof of concept. That proof of concept is a d-bus analyzer, probably the best d-bus analyzer around if your use case isn't exactly what Bustle covers - in that case, Bustle is the best. The analyzer

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115007/#review47370 --- Ship it! If you want you can even stop compiling the indexcle

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Vishesh Handa
> On Jan. 14, 2014, 10:18 a.m., Vishesh Handa wrote: > > src/file/extractor/app.cpp, line 78 > > > > > > Btw, I don't think this deletes it from the FileMapping db, only from > > the xapian database. > > Simeon

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Simeon Bird
> On Jan. 14, 2014, 10:18 a.m., Vishesh Handa wrote: > > src/file/extractor/app.cpp, line 78 > > > > > > Btw, I don't think this deletes it from the FileMapping db, only from > > the xapian database. Should it a

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115007/ --- (Updated Jan. 14, 2014, 2:59 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115006/#review47359 --- Ship it! Nice! src/file/extractor/app.cpp

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115007/#review47358 --- I think you uploaded the incorrect patch :P - Vishesh Handa