----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115006/#review47422 -----------------------------------------------------------
This review has been submitted with commit 8994006ff7f03aa5dc18994a4d8d65cb98da9973 by Simeon Bird to branch master. - Commit Hook On Jan. 14, 2014, 12:14 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115006/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 12:14 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Minor fix to the deletion of stale documents: if they had been removed > from the FileMapping db, but remained in the Xapian db with indexing > level 1, we would previously re-index them repeatedly. > > This happened because the non-existent id would be mapped to a url, eg, > $HOME/1234, which did not exist, and the extractor would exit normally. > > Change it so that something which is not found anywhere is removed as if > it were an id. If the id doesn't exist in the db, nothing will be > removed. > > (this would only happen as the result of a bug, I think; I only got it > after running a crazy broken test baloo_file. But it's best to be safe; > looping > forever doing nothing bugs are the worst because there's nothing for people > to send us) > > > Diffs > ----- > > src/file/extractor/app.cpp 456f83a > > Diff: https://git.reviewboard.kde.org/r/115006/diff/ > > > Testing > ------- > > It fixed my infinite loop! > > > Thanks, > > Simeon Bird > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
