line.
konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15702>
in the... ? :-)
(unfinished sentence)
It's easier to just move the connect to the block that creates the widget,
anyway. No if() needed, then.
- David F
> On Sept. 30, 2012, 8:26 a.m., David Faure wrote:
> > Looks good to me (feel free to commit if nobody else has comments).
> >
> > But then, what if someone is annoyed by icon views, and wants a details
> > view everywhere? [switch this sentence around if the d
> On Oct. 1, 2012, 8:30 a.m., David Faure wrote:
> > kioslave/ftp/ftp.cpp, line 2639
> > <http://git.reviewboard.kde.org/r/106636/diff/2/?file=87785#file87785line2639>
> >
> > Does this really work? This method is being called in the middle of the
> &g
kconfig_compiler test
framework is quite extensive, you can provide a "foo.cpp.ref" baseline which
will contain the expected generated code.
- David Faure
On Jan. 28, 2012, 8:39 p.m., Laszlo Papp wrote:
>
> ---
> This
Useful when embedding this widget somewhere else
than the
kfiledialog.
OK then. But maybe Apaku should review this too :)
- David Faure
On Oct. 2, 2012, 10:12 a.m., Aurélien Gâteau wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106581/
---
(Updated Oct. 2, 2012, 10:55 a.m.)
Review request for kdelibs and Andreas
---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101348/
> -------
>
> (Updated June 1, 2011, 6:07 a.m.)
>
>
> Review request for kdelibs, Ivan Čukić, Kevin Ottens, and David Faure.
>
ore deps, and if a user installs
the app, he would need the runtime deps anyway (= the service and its deps).
In short, the whole "libs / runtime" split idea from KDE4, is gone in KF5,
replaced with the more modular "here is all you need for technology xyz".
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
wo lines at most, it will never be bigger than a third of the
desktop height. Remove usingScrollArea and the associated code.
The tree widget can be tall, yes, but not the label on top.
- David Faure
On Oct. 4, 2012, 3:50 a.m., Dawit Alemayehu wrote:
>
> --
ttp://git.reviewboard.kde.org/r/106503/#comment15943>
Ah yes I misread, there's a call to icon.pixmap() in there. Sorry.
- David Faure
On Oct. 8, 2012, 5:43 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-m
> On Sept. 29, 2012, 6:48 a.m., David Faure wrote:
> > Doesn't this break "moving a tab with MMB" then? The KTabBar
> > mousePress/mouseRelease code won't be called anymore.
> >
> > If this is the case, then what we really have is two incompatib
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review20112
---
Ship it!
Ship It!
- David Faure
On Oct. 8, 2012, 5:43 p.m
can disappear at
the next upgrade, and the local one will keep working.
But this means it should be a full copy. Not just categories should be added,
but everything, using KConfig::copyTo().
- David Faure
On Oct. 8, 2012, 5:53 p.m., Dawit Alemayehu wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106906/#review20435
---
Ship it!
Ship It!
- David Faure
On Oct. 15, 2012, 9:35 p.m
d==0, and in >>, read into a temp url,
and if empty, skip the other fields.
- David Faure
On Oct. 15, 2012, 10:15 p.m., Ignat Semenov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
lt;http://git.reviewboard.kde.org/r/106636/#comment16142>
same
- David Faure
On Oct. 10, 2012, 3:55 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To r
stream out } ), and 2) well, make "a" null, so delete a.d; a.d = 0;
kio/kio/kfileitem.cpp
<http://git.reviewboard.kde.org/r/106902/#comment16153>
setter, should warn
kio/kio/kfileitem.cpp
<http://git.reviewboard.kde.org/r/106902/#comment16154
ntfilter), or a Qt bug could make
it fail to deliver the FocusOut before the view gets deleted. I'm not
completely sure there's a bug here, but it just sounds risky to rely on an
event to be received in order to avoid a crash.
- David Faure
On Oct. 17, 2
foreach would have done the
job just the same, but yes, this works too.
Please rename emitStatEntry to maybeEmitStatEntry (or emitStatEntryIfMatches)
(since it doesn't always emit, it checks whether to emit), and commit.
- David Faure
On Oct. 17, 2012, 8:48 p.m., Dawit Alemayehu
this stuff though, it only says
"this view has focus", but how does it get information about the current url
etc?
- David Faure
On Oct. 17, 2012, 4:06 p.m., Ivan Čukić wrote:
>
> ---
> This is an automatically ge
r the hint about setUri, I had missed that)
- David Faure
On Oct. 18, 2012, 10:13 a.m., Ivan Čukić wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
case is missing: item.d being NULL.
This should say
if (!d || !item.d)
return false;
kio/kio/kfileitem.cpp
<http://git.reviewboard.kde.org/r/106902/#comment16259>
brace on the same line, here and in similar if()s before and after.
- David Faure
On Oct. 16, 2012,
s on Qt 4.7
Is anyone still testing kdelibs -- or the rest of KDE SC master -- with
Qt-4.7?
Qt-4.8 was released quite a long time ago, I would think we could raise the
dependency.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
ose we use
KFileItem and not QUrl as the key in KFileItemModelRolesUpdater simply in
order to have this extra info available? But the QUrl is really the key, the
rest is associated data.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
Y(fileItem == fileItem2); // created independently,
> but still 'equal' +QVERIFY(!(fileItem != fileItem2));
> QVERIFY(fileItem.cmp(fileItem2));
Thank you kmail for messing up the lines in the reply...
The change looks good though.
Could you add a bit of docu while at it, about the difference between == and
cmp as discussed here? Thanks.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
. In contrast, operator== only compares URLs.
* @param item the item to compare
* @return true if all values are equal
*/
bool cmp( const KFileItem & item ) const;
Thanks for the fix, please commit to 4.10.
(This changes behavior, so it could create bugs
will return the error from the
loading of the last one, but I guess that's OK (no room for all, and the
problem is probably the same on all of them anyway, e.g. undef symbol in Qt or
another shared lib).
- David Faure
On Oct. 25, 2012, 12:12 a.m., Milian Wolff
nline the code if possible (unless you
> mark it as no_inline, which takes extra effort on your part).
>
> Or in other words, the compiler might do the right thing for you regardless.
Might --- or might not :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
of the staticQString, IMHO. This is an artefact from before the
QLatin1String times -- and we got rid of it in KF5 already.
Heh this one is even about an empty string, for a corner case (empty char* as
input), not worth the trouble IMHO.
And then the documentation will be correct.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
signature.asc
Description: This is a digitally signed message part.
s internal, it doesn't
affect KDE app devels outside of git.kde.org), but all I can see about git is
http://community.kde.org/Sysadmin/GitKdeOrgManual
which is more about the technical setup.
Maybe start a new webpage at the toplevel of community.kde.org?
GitWorkflowForEachModule? :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
On Wednesday 31 October 2012 10:14:20 Aurélien Gâteau wrote:
> Le mardi 30 octobre 2012 12:16:40 David Faure a écrit :
> > > Ok, thanks.
> > > Is this documented somewhere ?
> >
> > No (I described it in an email some time ago, but it's not on any wiki)
>
On Thursday 01 November 2012 20:44:14 Christoph Feck wrote:
> On Thursday 01 November 2012 12:05:51 David Faure wrote:
> > as soon as we branch out other modules for 4.10, we'll reopen
> > master, it will be less confusing to everyone.
>
> Good grief :P
I just mean
should be for dfaure to reset the 4.9 branch to the v4.9.3 tag,
> cherry-pick the commits made after that and force push the result. He's
> going to do that now I think.
Yep, fixed now, everything is back to normal.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
On Wednesday 07 November 2012 17:45:19 Alexander Neundorf wrote:
> > On Thursday, November 1, 2012 12:05:51 David Faure wrote:
> > > (seems I'm still confused about techbase vs community)
> >
> The git workflow docs should go to techbase, probably in the git s
further into this? From a quick look I guess that
extracting the file name from "relativePath" instead of from "filePath" might
do the job here.
- David Faure
On June 18, 2012, 5:39 p.m., Michael Reeves wrote:
>
> ---
> On June 19, 2012, 5:55 a.m., David Faure wrote:
> > Good idea, but it seems to break the case where nested dirs exist in the
> > directory being restored. Everything gets flattened out. Probably a bug in
> > CopyJob though, in the handling of fileNameUsedForCopying=Dis
n the last revision of the api documentation :(
result() -> to trigger application logic that should run when the job is done
finished() -> to hide progress dialogs, or to delete the job by hand
The difference: result() is not emitted by kill(Silently).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
issues with that sentence.
1) Models must be able to react to dynamic changes (e.g. the user creates a
file), so once they do that, they can also react similarly to "here are 10
entries" followed by "here are 10 more entries" (= inserting rows).
2) Why not just use KDirModel? It
oInitDBusConnection() -- which introduces a bit of noise in the
patch -- is only due to the very last hunk: so that we can make the call from
parent to child using the private connection rather than sessionBus().
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
On Saturday 17 November 2012 07:22:34 Thiago Macieira wrote:
> On sábado, 17 de novembro de 2012 10.55.01, David Faure wrote:
> > My current broken patch is
> > http://www.davidfaure.fr/2012/kuniqueapp_broken_fix.diff
> >
> > The change from QDBusConnectionInterface
g changed for a given file (permissions, size...), KDirLister calls
refresh() on the corresponding item, to update its information directly from
the disk.
In general, there is little reason for the apps themselves to call refresh on
a KFileItem, *if* that fileitem is being used in KDirLister/KDirModel.
On a standalone KFileItem it makes sense, of course.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
r/2012/kuniqueapp_dbus.diff
Is this what you had in mind? It leaves one issue though: in the case where
the app is already running, KApp calls ::_exit(0) but it should write to the
pipe first, see TODO in the diff. Shall I really export the pipe in
kuniqueapplication.cpp and write to it there in k
that should be next
to kdewebkit, or even inside kdewebkit. This would be more modular (and I'm all
for modularity, see kde frameworks 5 ;-)
Also, shouldn't this use macro_log_feature, like for all other mandatory
dependencies?
- David Faure
On Nov. 19, 2012, 2:54 p.m., Guy Ma
let's not nitpick.
- David Faure
On Nov. 19, 2012, 4:12 p.m., Guy Maurel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
On Monday 19 November 2012 18:11:06 Mark wrote:
> On Mon, Nov 19, 2012 at 12:05 PM, David Faure wrote:
> > On Saturday 17 November 2012 18:02:59 Mark wrote:
> >> On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote:
> >> > On Saturday, November 17, 2012 16:22:07 Ma
for the case of konqueror or konsole).
So no issue here, OK for the cache.
- David Faure
On Nov. 17, 2012, 10:56 a.m., Jaime Torres Amate wrote:
>
> ---
> This is an automatically
nto frameworks, then create the lib, and put your code
there.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by BlueSystems and KDAB to work on KDE Frameworks
n
kdelibs4, actually, it doesn't use QPrinter because that's in QtGui, and
klocale is in kdecore.
3) Your patch is OK though. I just checked, and PageSize is just a typedef for
PaperSize, so the actual int values are the same, so no porting problem. Phew.
- David Faure
On Nov. 17, 201
<http://git.reviewboard.kde.org/r/107358/#comment17133>
Wow...
kdecore/services/kmimetype.cpp
<http://git.reviewboard.kde.org/r/107358/#comment17134>
Spaces around the '=' and '<' signs are missing, in all the newly added
code.
- David Faure
x27;s used for? This
will make it more consistent with listDir.
Even better: move this to a common helper file-static function in the .cpp
file.
Input: relativePath, fileId
Output: fileDisplayName
=> static QString makeDisplayName(const QString& relativePath, const
Q
hould look at parent mimetypes too, for this to work more generally.
Can you test this patch instead? http://www.davidfaure.fr/2012/188989.diff
Please check that everything works ok with zip-based documents, like openoffice
files etc.
- David Faure
On May 27, 2011, 11:06 p.m., Matthias F
all other i18nc calls ported to translate...
- David Faure
On Nov. 21, 2012, 7:47 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This is an automatically generated e-mail. To reply
On Thursday 15 November 2012 19:37:49 Mark wrote:
> On Thu, Nov 15, 2012 at 6:26 PM, David Faure wrote:
> > On Thursday 15 November 2012 13:12:27 Mark wrote:
> >> My bad, the second signal is only emitting the remainder of whatever
> >> comes after the first signal.
>
, so an explicit
call to setActivePart should be added.
Looking at the other setFocus calls:
* KonqView::setLoading calls setFocus, but it's ok if this doesn't change the
active part (fixes a race condition with the user changing parts quickly after
starting to load a typed url, so th
, then, since
apparently kde-baseapps master only requires kdelibs-4.8...
It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, but
that wouldn't help anyway.
- David Faure
On Nov. 22, 2012, 5:26 p.m., Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote:
> > This probably needs a #ifdef on the kdelibs version number, then, since
> > apparently kde-baseapps master only requires kdelibs-4.8...
> >
> > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at le
kDebug over gdb for this, especially for a method that is called
500 times.
> What i can do is grab the logic out ant test it in a separate C++ project.
Well yeah you already posted a test program iirc.
Otherwise here's mine: http://www.davidfaure.fr/2012/kio-listdir.zip
--
David Faure,
o chunks, it's perfectly valid.
> What's your opinion here?
> Note: These issues that i find never stay on the surface do they..
> This one is diving very deep in KIO, the shortcuts one was diving very
> deep in KDE internals and even Qt..
Well, this is 2012. The easy bugs were fixed long ago, only the interesting
ones remain :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
would welcome your help in fixing this better indeed.
I don't see a KConfigData class, not a revertToDefault outside of KConfigGroup,
so I wonder what you saw and where...
- David
---
This is an automatically generat
ewboard or can i just push it
> to 4.10? My patches are never perfect the first time so i guess you
> guys will have some comments first :p
Yep, please put on reviewboard after fixing the above, it will be easier to
review the new code than to have it intermixed with the old lines in that dif
On Thursday 29 November 2012 16:04:21 Mark wrote:
> On Thu, Nov 29, 2012 at 2:23 PM, David Faure wrote:
> > On Friday 23 November 2012 22:23:24 Mark wrote:
> >> Here it is: http://paste.kde.org/613670/
> >
> > This calls gettimeofday for every entry, even wh
to succeed
and chdir() to fail...
kioslave/file/file_unix.cpp
<http://git.reviewboard.kde.org/r/107520/#comment17552>
Remove this comment, it is wrong here.
kioslave/file/file_unix.cpp
<http://git.reviewboard.kde.org/r/107520/#comment17553>
Move this comment down to th
t. Is that "before" or
"after"? Why does it say "without devices"? It shows Home and Root twice, could
that be fixed?
lib/konq/konq_copytomenu.cpp
<http://git.reviewboard.kde.org/r/102657/#comment17596>
Create it on the stack, if its lifetime is limited to th
s a lot of small
> files to read to get the total size, so it may not be that fast in all
> cases (1000 items on an old HD? NFS/SMB?).
This sounds slower than simply stat()ing every trashed filed to determine its
size. stat() is a single syscall, while open+read+parsing+close is a lot
more...
pretty good :-)
Thanks.
- David Faure
On Dec. 5, 2012, 6:54 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
utomatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107520/
> -------
>
> (Updated Dec. 5, 2012, 6:54 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> ---
>
> listDir is batching onl
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107642/#review23210
---
Ship it!
Ship It!
- David Faure
On Dec. 9, 2012, 4:44 p.m
t?
My current solution is QCoreApplication::translate("", "foo") so that an empty
context is used, but it's a bit ugly.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
return fileDisplayName;" is missing here, so basically makeDisplayName
was returning an invalid QString?
kioslave/trash/kio_trash.cpp
<http://git.reviewboard.kde.org/r/105078/#comment17935>
This comment should move up to the implementation of makeDisplayName()
- David Faure
On
org/r/105078/#comment17966>
This doesn't work, it makes every file under a subdir "0-Documents" appear
as "Documents"...
I'll rework this...
- David Faure
On Dec. 11, 2012, 9:51 p.m., Michael Reeves wrote:
>
> --
untime), this is good
news then, it sounds like we can drop the weird QCoreApp::translate("",
"text") in KF5.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
signature.asc
Description: This is a digitally signed message part.
"cleanups" and new features in frameworks, however.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
ou need something, make it happen, don't just hope for others to do so :)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
igh entry barrier? Pff.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
On Monday 17 December 2012 14:47:11 David Faure wrote:
> Now that all modules have a KDE/4.10 branch, kdelibs can use again the same
> workflow as the other modules: 4.10 for the 4.10.x series, and master for
> the 4.11.x series. This will create less confusion than a frozen maste
ee if it breaks
anything).
An addition to the kconfig_compiler unittests is missing, though, could you add
that?
- David Faure
On Dec. 14, 2012, 1:17 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-
f it's a
ton of single files, this will be a lot slower than stat'ing, for sure.
> So, I'll wait for a bit more input before really starting. I'm a bit busy
> at the moment anyway.
Don't wait, get the discussion started on xdg :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
don't need the
QCoreApplication::translate("", "foo") ugliness, a simple tr("foo") can do the
job just fine. We'll need to adjust the existing code and the wiki, obviously.
- David Faure
On Dec. 17, 2012, 8:05 p.m.,
On Thursday 13 December 2012 21:50:29 Chusslove Illich wrote:
> >> [: David Faure :]
> >> If it handles this correctly (so that tr() works at runtime), this is
> >> good news then, it sounds like we can drop the weird
> >> QCoreApp::translate("", "
viewboard.kde.org/r/107412/#comment18252>
lots of trailing whitespaces around here
- David Faure
On Dec. 23, 2012, 5:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This is an automatically generated
difference between r2
and r3.
- David Faure
On Dec. 23, 2012, 5:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
> On Nov. 22, 2012, 11:04 a.m., David Faure wrote:
> > Well, if setFocus() shouldn't trigger the PartManager, then the fix would
> > be in PartManager itself. Otherwise the part manager and konqueror will
> > have a different vision of the currently active part.
it
though:
QCoreApplication::translate("SonnetDictionaryLoader", variantEnglish,
"dictionary variant")
- David Faure
On Dec. 24, 2012, 10:03 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This
ed by value everywhere, as per
http://www.macieira.org/blog/2012/02/the-value-of-passing-by-value/
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
signature.asc
Description: This is a digitally signed message part.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107412/#review24021
---
Ship it!
Ship It!
- David Faure
On Dec. 26, 2012, 11:02
aging/sonnet/src/core/backgroundchecker.cpp
<http://git.reviewboard.kde.org/r/107791/#comment18308>
Why do other files (below) pass parameters to the QSettings constructor and
not this one (nor ConfigWidget)?
- David Faure
On Dec. 27, 2012, 12:52 a.m., Martin Tobias Holmeda
--
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107791/
> ---
>
> (Updated Dec. 27, 2012, 12:52 a.m.)
>
>
> Review reques
27;t apply to "projects which refer to the kdelibs coding
style". There's no good reason for apps to do this, only porting trouble comes
from that.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107048/#review24415
---
Ship it!
Ship It!
- David Faure
On Dec. 30, 2012, 1:37 a.m
anges.
Also, this changes misses a corresponding unittest in kdirlistertest.cpp.
- David Faure
On Dec. 29, 2012, 8:31 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> On Dec. 28, 2011, 7:37 a.m., David Faure wrote:
> > kio/kio/kdirlister.cpp, line 1078
> > <http://git.reviewboard.kde.org/r/103555/diff/1/?file=44960#file44960line1078>
> >
> > Yes, but changing permissions is only one case for ending up here. The
>
. Could you look
into KSelectionWatcher in the kdelibs-frameworks branch (with Qt5 installed),
and port the kselectionwatcher unittest to the new kselectionwatcher API
(fredrikh made it async, due to XCB being async, but didn't port the unittest)?
- David Faure
On Dec. 30, 2012, 4:4
f we could just keep a readonly svn
around (surely this shouldn't require much maintainance), it would be useful
for archeology purposes.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
team: shall I commit it to
KDE/4.10, or wait until 4.10.0 is out (but that would mean Feb 6), given that
it's not a release showstopper and we're in RC2 already.
- David Faure
On Dec. 22, 2012, 7:46 p.m., Yichao Yu wrote:
>
> --
e (which sends
application/octet-stream as mimetype).
It offered "open with kwrite" but choosing that would lead to an open-with
dialog, because the mimetype was still application/octet-stream in KRun.
With this fix, kwrite runs.
Thanks,
David Faure
;
I'm not sure why the test was making the HTTP Request twice (Andreas?), but
this is changing what's actually being tested, a little bit, I think?
- David Faure
On Jan. 13, 2013, 9:28 a.m., Jon Severinsson wrote:
>
> ---
e right fix...
- David Faure
On Jan. 13, 2013, 11:54 a.m., Jon Severinsson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.revie
More from me later...
- David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106475/#review19914
---
On Sept. 17, 2012, 10:39 a.m., Àlex Fiestas wrote:
>
>
---
* "save image as" in konqueror
* additional kurl unittests
Thanks,
David Faure
, for future
maintainance. Let's extract it. Can you test if this works for you?
http://www.davidfaure.fr/2013/kprotocolinfo.diff
- David Faure
On Jan. 18, 2013, 1:29 p.m., Reza Shah wrote:
>
> ---
> This is an automatically g
901 - 1000 of 1169 matches
Mail list logo
