----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102657/#review23026 -----------------------------------------------------------
I like the idea, but I don't understand the screenshot. Is that "before" or "after"? Why does it say "without devices"? It shows Home and Root twice, could that be fixed? lib/konq/konq_copytomenu.cpp <http://git.reviewboard.kde.org/r/102657/#comment17596> Create it on the stack, if its lifetime is limited to the current block. - David Faure On Dec. 4, 2012, 6:25 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102657/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 6:25 p.m.) > > > Review request for Dolphin, KDE Base Apps and David Faure. > > > Description > ------- > > The most common usage for "{Copy,Move} To" dolphin context menus is that a > user wants to copy/move a selected file to plugged in USB drive. Show the > mounted removable media also along with "Root Folder" and recently used > entries. > > It would be nice to have "Places" sidebar instead of the current > implementation, which includes Root Folder, Home Folder, Desktop Folder, > other drives including removable media like USB drives etc. See bugs 140475, > 251151 et al. This should also help in scenario where plugged in removable > media is not automatically mounted (which is the default setup at least in > Fedora). I couldn't find a way to easily extend that functionality, though. > > > This addresses bug 251151. > http://bugs.kde.org/show_bug.cgi?id=251151 > > > Diffs > ----- > > lib/konq/konq_copytomenu.cpp ca1d963 > > Diff: http://git.reviewboard.kde.org/r/102657/diff/ > > > Testing > ------- > > Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user. > > > Screenshots > ----------- > > Places without Devices > http://git.reviewboard.kde.org/r/102657/s/268/ > > > Thanks, > > Rajeesh K Nambiar > >
