is loaded.
Same thing in
http://lxr.kde.org/source/extragear/base/kwebkitpart/src/kwebkitpart.cpp#759,
the wallet icon is removed when the wallet is closed.
- David Faure
On Oct. 1, 2011, 7:14 p.m., Thomas Friedrichsmeier wrote
nt no optimizations (e.g. for step-by-step in gdb).
- David Faure
On Oct. 3, 2011, 4:25 p.m., Guy Maurel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
idget or in Qt?
- David Faure
On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
ttp://git.reviewboard.kde.org/r/101653/#comment6234>
Still a weird indentation here. reviewboard messing up?
- David Faure
On Oct. 5, 2011, 7:28 a.m., Thomas Friedrichsmeier wrote:
>
> ---
> This is an automatically generated e-mail.
> On Oct. 3, 2011, 5:24 p.m., David Faure wrote:
> > Please don't commit this.
> >
> > Use debugfull if you want no optimizations (e.g. for step-by-step in gdb).
>
> Guy Maurel wrote:
> thanks, I'll try this.
>
> Guy Maurel wrote:
&g
?
Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big
icon button makes the dialog quite large?
- David Faure
On Oct. 4, 2011, 8:02 p.m., Greg T wrote:
>
> ---
> This is an automatically genera
after typing "search", to match
google search urls).
Yep, it's hidden, feel free to make it happen automatically in the right
completion class. I'm just saying the support for actually searching is there,
so this should be easy to add.
--
David Faure, fa...@kde.org, http:
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote:
> > Why the setMaxLength?? What if one wants to type in a long URL?
> >
> > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the
> > big icon button makes the dialog quite large?
>
;s called on a (specific) keypress, this hasn't been a
problem until now. It might become a problem if it happens during normal
typing though...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote:
> > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of
> > the patch looks good. I'm just wondering about using Unbuffered. If someone
> > installs a mimetype definition with multiple
atio on kde-core-devel is already high enough.
And release-team@ has probably many more subscribers than you think.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
> On Aug. 29, 2011, 4:09 p.m., David Faure wrote:
> > konqueror/src/konqmain.cpp, line 125
> > <http://git.reviewboard.kde.org/r/101850/diff/1/?file=26095#file26095line125>
> >
> > So it won't ask when logging into a new KDE session? Seems to me that
t6448>
Probably due to double encoding. Might be fixed by my suggestion of using
KFileItem(UDSEntry).
directoryusagenotifier/cleanupdirectory.cpp
<http://git.reviewboard.kde.org/r/102083/#comment6449>
Don't use exec. Since these are always local files, I would suggest si
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote:
> > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of
> > the patch looks good. I'm just wondering about using Unbuffered. If someone
> > installs a mimetype definition with multiple
file, not just changing the mode line)
:-)
kioslave/ftp/ratecontroller.cpp
<http://git.reviewboard.kde.org/r/102307/#comment6487>
BTW I fixed that for Qt 5 (usleep is now public) so you can add a "QT5
TODO: remove" comment.
- David Faure
On
l var "mimeType", why not use it? ;)
kio/kio/previewjob.cpp
<http://git.reviewboard.kde.org/r/102929/#comment6505>
And this is why you shouldn't use QUrl. As documented in KUrl,
QUrl::toString() is terribly wrong (gives wrong results when a
Anyway, why use a local variable for this case and not for the "KIO" case?
This is harder to read because not symmetric.
I guess making it a single line, just like for KIO, would be okay.
- David Faure
On Oct. 22, 2011, 12:55 a.m., Sebastian Kügler wrote:
>
> ---
e path. KUrl isn't meant to store a
relative location, and KUrlRequester always returns an absolute url when using
the file dialog, one would have to type something blindly to get a relative
filename in there, no? Anyway KUrlRequester should be fixed if it returns
relative paths, I don't think it should let apps resolve that to a full path
when it can do so itself.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
tches the chosen one?
- David Faure
On Oct. 29, 2011, 11:32 a.m., Martin Koller wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.
ld be safer. No strong opinion though.
On the other hand, "find" should probably be propagated so that the
webpage-global find gets triggered. I guess that's what your patch does
currently, so nothing to change for these "safe" actions.
It's a bugfix, it can go to
ttp://git.reviewboard.kde.org/r/103038/#comment6834>
Could be file-static instead of class-static, so that it doesn't generate a
symbol at all.
- David Faure
On Nov. 3, 2011, 5:59 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103098/#review8079
---
Ship it!
Yep, looks good.
- David Faure
On Nov. 9, 2011, 9
changed
> to use Qt 5.
This would require 1) that frameworks is ready before qt 5 is (with the
current development speed, that remains to be proven), and
2) that apps port twice. Once to frameworks, and then once again to Qt5.
Not sure that would be a good idea.
It also shortens the window of API chang
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103165/#review8262
---
Looks good except for one item.
- David Faure
On Nov. 17
g/r/103165/#comment7070>
- David Faure
On Nov. 17, 2011, 11:41 a.m., Jaime Torres Amate wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboar
On Thursday 17 November 2011 13:33:25 David Faure wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103165/#r
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review8269
---
- David Faure
On Aug. 24, 2011, 4:29 p.m., Cyril Oblikov
> On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
> >
Cyril, can you rebase your changes on top of the kdelibs frameworks branch,
compile, and commit there?
- David
---
This is an automatically generated e-mail. To reply, vi
tor' wrong.
+ does have precedence over ?:, so the code was wrong, and your fix fixes an
actual bug. Yay for compiling the same code with different compilers!
- David Faure
On Nov. 17, 2011, 2:37 p.m., Jaime Torres Amate wrote:
>
> ---
Diff: http://git.reviewboard.kde.org/r/103168/diff/diff
Testing
---
Thanks,
David Faure
indow" isn't fully
fixed with this patch alone, kmail2rc is still reparsed because the kdeui code
that calls revertToDefault on entries that are equal to the default value,
makes the config dirty. This requires a different fix which I'll submit
separately.
Thanks,
David Faure
r to do this inside of setWindow() or even
deeper down...
- David Faure
On Nov. 24, 2011, 3:16 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.revi
g/r/103226/#comment7284>
This function is now unused, please remove it.
kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7285>
add comment to explain why we don't use setWindow
- David Faure
On Nov. 29, 2011, 4:09 p.m., Dawit Alemayehu wrote:
&g
while reviewing this commit:
http://quickgit.kde.org/?p=clones%2Fkdelibs%2Fpgquiles%2Fkdelibs-
jointhegame.git&a=commitdiff&h=5f50f16480667b52c38b8e53c0bb33888bd50309
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
t; could be added later...
>
> I tried to find other tests in kde-workspace but none of them seem to
> use non-program files.
kdelibs has many of these, and the define KDESRCDIR (set by kde4_add_unit_test)
can be used to point to the files in the source directory while running the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103199/#review8804
---
Ship it!
Ship It!
- David Faure
On Nov. 21, 2011, 8:11 p.m
ensionList.contains(...)) {
extension = '.' + currentExtension;
} else {
extension = defaultExtension;
}
If there are really just two cases, there is no need for 3 ifs.
- David Faure
On Nov. 17, 2011, 6
> On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
> >
>
> David Faure wrote:
> Cyril, can you rebase your changes on top of the kdelibs frameworks
> branch, compile, and commit there?
>
> Cyril Oblikov wrote:
> Hi David.
>
> I'm curre
On Thursday 08 December 2011 16:56:16 David Faure wrote:
> khelpmenu seems to have been ported from qt3 without much thinking, the
> actions in menu() could just use kstandardaction too, instead of
> duplicating the action details... but that's for frameworks 5 :)
Hmm, actual
x27;\${START_KDEINIT_PATH}' &&
chmod u+s '\${START_KDEINIT_PATH}'\")
")
endif (CMAKE_SYSTEM_NAME MATCHES Linux)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
412/#comment7474>
Please use KFileSystemType instead of KMountPoint, it will be much faster.
And yeah, given that copying to NFS will be slow anyway, I'm not sure if
using KDiskFreeSpaceInfo is really a problem...
- David Faure
On Dec. 16, 2011, 1:28 p.m., Nick Shaforo
. How about adding
a SETTINGS_LOCALE if that's what you need?
- David Faure
On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.revi
comboboxes? I
think the fast-mode-checkbox should stay, in the list widget. Other than that,
it looks good.
- David Faure
On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote:
>
> ---
> This is an automatically generated e-mail.
x bug #289094.
If everyone only went for the "minimal lines of code" fix all the time, we
would have one hell of a mess by now...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
On Sunday 18 December 2011 20:26:42 Lamarque V. Souza wrote:
> Em Sunday 18 December 2011, David Faure escreveu:
> > On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote:
> > > Another problem with this approach is that we cannot prevent anybody
> > > e
ttp://git.reviewboard.kde.org/r/103469/#comment7509>
I like the idea (KGlobalSettings reparsing configuration), but not the
implementation (setLanguage(langage)). Can't KLocale get a
reparseConfiguration() (to reuse the KConfig naming) ?
- David Faure
On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote:
> > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > > kdeui/kernel/kglobalsettings.cpp, line 886
> > > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867lin
> > >
available. Sounds ok then.
- David Faure
On Dec. 19, 2011, 4:48 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote:
> Em Monday 19 December 2011, David Faure escreveu:
> > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote:
> > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > > > > kdeui/
on the proposal.
So this patch does not merge them, it only makes fullmode more usable - no
objections.
- David Faure
On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103500/#review9158
---
Ship it!
Ship It!
- David Faure
On Dec. 22, 2011, 12:25 a.m
;t run the risk that an
app that wasn't mean to run twice, ends up running twice.
konsole is doing rather unusual stuff with kuniqueapplication so I can't
comment on what would be the proper fix for konsole, but I'm pretty sure it
should only affect konsole, not other kuniqueapplic
> On Dec. 23, 2011, 11:59 a.m., Askar Safin wrote:
> > Ship It!
I don't think you're supposed to "Ship it" your own change, the point of
reviewboard is to get reviews from others :-)
- David
---
This is an automatically generated e-mai
. Why not factorize this and call that code for
local files too? It would make the code shorter and easier to maintain.
- David Faure
On Dec. 24, 2011, 4:14 a.m., Dawit Alemayehu wrote:
>
> ---
> This is an automati
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote:
> > This seems like a dangerous change to me.
> >
> > With it, you could run multiple instance of "kmail --nofork", and they
> > would step on each other's toes. The whole point of kuniqueapplication (i
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote:
> > konqueror/client/kfmclient.cpp, line 386
> > <http://git.reviewboard.kde.org/r/103524/diff/1/?file=44675#file44675line386>
> >
> > The code later on uses "new KRun" for the case of a user-defin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote:
> > This seems like a dangerous change to me.
> >
> > With it, you could run multiple instance of "kmail --nofork", and they
> > would step on each other's toes. The whole point of kuniqueapplication (i
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote:
> > konqueror/client/kfmclient.cpp, line 386
> > <http://git.reviewboard.kde.org/r/103524/diff/1/?file=44675#file44675line386>
> >
> > The code later on uses "new KRun" for the case of a user-defin
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote:
> > konqueror/client/kfmclient.cpp, line 386
> > <http://git.reviewboard.kde.org/r/103524/diff/1/?file=44675#file44675line386>
> >
> > The code later on uses "new KRun" for the case of a user-defin
/4.8
- David Faure
On Dec. 19, 2011, 10:15 p.m., Lamarque Vieira Souza wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
over url.directory() instead of
url.path(), then. Which then means both cases (directory and file) can be
merged.
- David Faure
On Dec. 27, 2011, 6:26 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote:
> > konqueror/client/kfmclient.cpp, line 386
> > <http://git.reviewboard.kde.org/r/103524/diff/1/?file=44675#file44675line386>
> >
> > The code later on uses "new KRun" for the case of a user-defin
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote:
> > konqueror/client/kfmclient.cpp, line 386
> > <http://git.reviewboard.kde.org/r/103524/diff/1/?file=44675#file44675line386>
> >
> > The code later on uses "new KRun" for the case of a user-defin
QDir/QFileInfo's fault, not yours :)
You don't seem to have a kde contributor account, do you want to get one, or
should I commit this for you?
- David Faure
On Dec. 30, 2011, 2:44 a.m., Anssi Hannula wrote:
>
> ---
>
the kde-
> src-build sample config because it hadn't been up-
> dated yet).
Right. kdelibs.git HEAD is pretty much the same though, someone would have to
remember to update it (and only sysadmins can do so), while everyone can fix
kdesrc-build-sample. Anyway, we're nitpicking, it'
might create
issues in the users of the dialog.
I think a different fix is needed, usually this is done via a bool "dirty",
i.e. "there are changes to be saved", and not doing anything if there are no
changes to be saved.
- David Faure
On Dec. 30, 2011, 6:39 a.m., D
ldn't (on startup, or when the
user asks to see it), this looks ok.
- David Faure
On Dec. 30, 2011, 6:47 a.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.review
rt in the view mode menu, but I'm
not sure we have enough information to know that in there.
- David Faure
On Dec. 30, 2011, 11:08 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To r
eference to the bug
report.
I trust that you also tested it in the standard case, where name() contains no
slash.
- David Faure
On Dec. 31, 2011, 5:23 a.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103599/#review9437
---
Ship it!
Ship It!
- David Faure
On Dec. 31, 2011, 11:33 a.m
<http://git.reviewboard.kde.org/r/103579/#comment7767>
futher -> further
- David Faure
On Jan. 2, 2012, 6:25 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To re
plicated.
This code change shows mimetype comments rather than mimetype names, too.
That's fine I suppose, it's just missing from the overall description of this
change. Don't forget it in the commit log ;)
> On Jan. 2, 2012, 10:50 p.m., David Faure wrote:
> > kparts/browseropenorsavequestion.cpp, line 287
> > <http://git.reviewboard.kde.org/r/103617/diff/1/?file=45307#file45307line287>
> >
> > I don't get what this call changes, here (with no filename p
ttp://git.reviewboard.kde.org/r/103617/#comment7778>
So, this is passing the default mimetype as first argument, knowing very
well that it won't be used...
This kind of factorization isn't really factorization :/
If we want to call findByUrl here, why not just call findByUrl...
-
; them and the existing ktouchpadenabler so instead of one simple codebase
> (166 lines with 20 of headers) you end up adding more complexity to
> existing programs (probably integrating the code in the existing programs
> would be more than 166 lines).
IMHO this isn't about the number o
adding a Qt key for that X keysym.
Should be pretty forward.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
both foo.sh and my shell source the same setup file)
This is off-topic for kde-core-devel, let's discuss this on IRC if you still
can't get it to work.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
/konqmainwindow.cpp
<http://git.reviewboard.kde.org/r/103663/#comment7962>
The comment should be adjusted to "the empty match case is handled
directly", or removed (it doesn't seem useful, in fact).
- David Faure
On Jan. 9, 2012, 8:33 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103684/#review9785
---
Ship it!
- David Faure
On Jan. 12, 2012, 6:14 p.m., Dawit
, not command lines types
by the user or selected in the application tree. So this looks good.
- David Faure
On Jan. 1, 2012, 9:49 p.m., Ingomar Wesp wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
was broken, in particular?
I'm not objecting to the fix, I would just like to understand why it's
necessary for you and not for everyone else ;)
(different platform? compiler? X version? ...)
- David Faure
On Jan. 15, 2012, 12:53 p.
latforms"
Why is this review about adding stuff to kdeui, then? I don't get it. Either
you're using it or you're not using it -- or the real reason is core/gui split
in your libs/apps, which would be a valid point.
- David Faure
On Jan. 17, 2012,
eAndContent(chosenFileName, content)
where content is a QByteArray with the header of a desktop file ("[Desktop
Entry]\n").
- David Faure
On Jan. 13, 2012, 7:10 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an auto
> On Jan. 18, 2012, 3:39 p.m., Jeremy Paul Whiting wrote:
> > Looks good to me as long as we aren't trying to keep BIC in frameworks. If
> > we are, a duplicate method with KConfigSkeleton that simply calls this new
> > method should be added to keep BC.
We are definitely not keeping BC in fr
ot;.desktop". #224142.
- David Faure
On Jan. 18, 2012, 6:26 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
opers should check for
"since 4.8" tags when looking at Qt api docs, and people using 4.7 to compile
kde must accept that they'll sometimes hit a breakage due to 4.8-only api
being used (and then either fix it or report it). To be re-evaluated when 4.8
is more commonly used.
--
David
g/r/103740/#comment8283>
Shouldn't this connect be removed then?
Isn't there a risk that both signals get emitted in some cases?
- David Faure
On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote:
>
> ---
>
el, 2) I
don't know if deleteLater are processed at app quitting time, so this might
lead to false positives in future memory-leak debugging. 3) in general, any of
these non-running destructors could be doing things that we actually need to
happen.
- David Faure
On Jan. 30
?
> >
> > I cannot confirm that the fix is correct or not because I don't know why
> > the crash happens.
>
> I can generate one, but I do not have a debug build of Qt and it takes
> way too long to build that on my 6 year old home PC.
Wow. We need to resurrect adopt-a-gee
ins do the job?
kio/kio/previewjob.cpp
<http://git.reviewboard.kde.org/r/103882/#comment8560>
Use protocol() instead of scheme() in KDE4 so that it gets lowercased if
necessary.
- David Faure
On Feb. 7, 2012, 10:06 a.m., Sebas
that from kxmlguibuilder instead, and
keeping a list internally.
Then you can iterate over that list to find the action, which will prevent
finding it in completely unrelated action collections (e.g. the one used for a
popup menu, like in konqueror).
- David Faure
On Jan. 28, 2012, 3:28 p.m.
m_remoteProtocolPlugins then,
which indeed is missing crucial information. But no reason to keep both.
I understand if you don't want to do this, in that case just commit and I'll
clean up ;)
- David Faure
On Feb. 8, 2012, 9:56 p.m., Sebastian T
ent8655>
Double connect, this was already done on line 24.
kioslave/recentdocuments/recentdocumentsnotifier.cpp
<http://git.reviewboard.kde.org/r/103849/#comment8656>
Not sure what there is to clean in "recentdocuments:/filename" :-)
I think this line can be remo
ttp://git.reviewboard.kde.org/r/103849/#comment8663>
Why use KUrl here? This is always a local path, and you turn it into a
local path in order to use it.
It would be much simpler to just use a QString here, concatenate directory
and filename, then use KDesktopFile with that.
- David Faure
this attribute
necessary? It's not like the the compiler is going to warn about the lack of a
return value...
- David Faure
On Jan. 31, 2012, 8:58 p.m., Allen Winter wrote:
>
> ---
> This is an automatically generated e-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103693/#review10591
---
Ship it!
Ship It!
- David Faure
On Jan. 14, 2012, 9:27 a.m
, shouldn't the bool
spellCheckerFound be removed altogether?
Multiple copies of the same information is always source of trouble, as you
noticed.
- David Faure
On Jan. 18, 2012, 5:35 p.m., Nick Shaforostoff wrote:
>
> ---
&
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103642/#review10594
---
Ship it!
Ship It!
- David Faure
On Jan. 6, 2012, 9:54 p.m
ced to starting kioslaves, which will make it
possible to have klauncher only started on-demand by the first KIO job (at
which point the app is ok with multiple processes, obviously).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
con( const QIcon &pix );
>
> I assume this deprecation was done before Qt itself had the possibility to
> load an icon from a theme ?
Sounds right.
> So should the KDE_DEPRECATED be simply removed ?
Yep, please do (this is also in line with the direction of KDE Frameworks).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
601 - 700 of 1169 matches
Mail list logo
