----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review9322 -----------------------------------------------------------
kio/kio/kdirlister.cpp <http://git.reviewboard.kde.org/r/103555/#comment7692> Yes, but changing permissions is only one case for ending up here. The most common case is that KDirWatch (in Stat mode) notifies us that a directory has changed because files have been created in it, or deleted, etc. In that case we do want to make the directory as dirty, not its parent. I guess that means we need to do both, mark the parent and the directory itself, as dirty. Sucks for performance, though. The real issue is that KDirWatch's dirty() signal is pretty unspecific. Ah, I know. This is called by KDirWatch so it's local only, no networ transparency. So we should just clear the permissions/owner in the KFileItem for the directory, they'll be re-determined on demand by KFileItem. kio/kio/kdirlister.cpp <http://git.reviewboard.kde.org/r/103555/#comment7691> Well, that's equivalent to looping over url.directory() instead of url.path(), then. Which then means both cases (directory and file) can be merged. - David Faure On Dec. 27, 2011, 6:26 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103555/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2011, 6:26 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > If you open a directory that contains other directories in Konqueror or > Dolphin, change the permission of one of these directories from outside, say > the command line, and right click on the same directory to look at the > permission tab in the properties dialog, you will see that the permission > change has not been updated. This patch addresses that bug. > > > This addresses bug 173733. > http://bugs.kde.org/show_bug.cgi?id=173733 > > > Diffs > ----- > > kio/kio/kdirlister.cpp ec3d622 > > Diff: http://git.reviewboard.kde.org/r/103555/diff/diff > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
