Re: Review Request 113413: Improved Keyboard Layout Preview

2014-09-30 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 1, 2014, 2:59 a.m.) Status -- This change has been mar

Re: Review Request 113413: Improved Keyboard Layout Preview

2014-01-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/#review48292 --- Ship it! Ship It! - shivam makkar On Nov. 15, 2013, 9:37 a

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-15 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Nov. 15, 2013, 9:37 a.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-14 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review43699 --- Hi Shivam, there's a bug report about the reversed positions of

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-05 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Nov. 5, 2013, 8:22 p.m.) Review request for KDE Runtime, kde-work

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-05 Thread shivam makkar
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-27 Thread Albert Astals Cid
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread Xuetian Weng
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 26, 2013, 1:12 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 26, 2013, 1:04 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42378 --- How does it look on 1024 pixel wide screens (not that I want to

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42377 --- Could you also post a preview for French ? It should have 4 sym

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 25, 2013, 7:13 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42345 --- I think a screenshot would nicely go along with this ;) (Updat

Review Request 113413: Improved Keyboard Layout Preview

2013-10-24 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- Review request for KDE Runtime, kde-workspace and Andriy Rysin. Repository