----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review43699 -----------------------------------------------------------
Hi Shivam, there's a bug report about the reversed positions of small/capital letters (https://bugs.kde.org/show_bug.cgi?id=327393), it looks like the small/capital letter positions on the 1st/2nd levels are correct in the screenshots you attached, but the 3rd/4th levels are reversed (at least in Ukrainian layout), not sure about 5th/6th levels in Neo 2. Could you please take a look? Thanks. - Andriy Rysin On Nov. 5, 2013, 3:22 p.m., shivam makkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113413/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 3:22 p.m.) > > > Review request for KDE Runtime, kde-workspace and Andriy Rysin. > > > Repository: kde-workspace > > > Description > ------- > > Improved keyboard layout preview > added geometry feature, multi-level keys (>4) and parsed geometry file using > Boost c++ libraries and tool tip showing symbol names. > my GSoC-13 project ! > > > Diffs > ----- > > kcontrol/keyboard/preview/kbpreviewframe.cpp 40359f9 > kcontrol/keyboard/preview/keyboardpainter.cpp 0427102 > > Diff: http://git.reviewboard.kde.org/r/113413/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > English layout default geometry > > http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/57ce3e15-26a9-46e2-ad5d-6073e04a5489__snapshot16.jpg > german neo 2 layout default geometry > > http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/231ded09-9f22-44f5-aafe-6759c683b552__snapshot17.jpg > ukranian layout microsoft natural geometry > > http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/8dca14f2-2d00-46d1-95a1-f7eca0ff5831__snapshot18.jpg > > > Thanks, > > shivam makkar > >
