Re: Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
On Wed, Jan 4, 2012 at 20:46, Albert Astals Cid wrote: > El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va > escriure: >> On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: >> > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va >> > >> > escriure: >>

Re: Review Request: kcm-grub2

2012-01-04 Thread Albert Astals Cid
El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va escriure: > On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: > > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va > > > > escriure: > >> Hi, > >> > >> kcm-grub2 has been in kdereview for months.

Re: Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va > escriure: >> Hi, >> >> kcm-grub2 has been in kdereview for months. It would be great if it >> could be moved back or forth. I am planning a new release soon, I >> would

Re: Review Request: kcm-grub2

2012-01-04 Thread Albert Astals Cid
El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va escriure: > Hi, > > kcm-grub2 has been in kdereview for months. It would be great if it > could be moved back or forth. I am planning a new release soon, I > wouldn't like to abuse kdereview. If noone raised extra comments an

Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
Hi, kcm-grub2 has been in kdereview for months. It would be great if it could be moved back or forth. I am planning a new release soon, I wouldn't like to abuse kdereview. Regards, Konstantinos

Re: Review Request: kcm-grub2

2011-06-05 Thread Konstantinos Smanis
Raphael Kubo da Costa gmail.com> writes: > > Konstantinos Smanis gmail.com> writes: > > > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he > > has agreed to give up his request for inclusion in extragear. > > > > Our conversation has been over plain e-mails, so I cannot prove

Re: Review Request: kcm-grub2

2011-06-04 Thread Raphael Kubo da Costa
Konstantinos Smanis writes: > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he > has agreed to give up his request for inclusion in extragear. > > Our conversation has been over plain e-mails, so I cannot prove this. > Perhaps I should contact him to confirm this? That sound

Re: Review Request: kcm-grub2

2011-06-04 Thread Konstantinos Smanis
Raphael Kubo da Costa gmail.com> writes: > Konstantinos Smanis gmail.com> writes: > > > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis > > gmail.com> wrote: > >>> The following line should probably be simplified (see > >>> http://websvn.kde.org/?revision=1184860&view=revision): > >>> > >>>

Re: Review Request: kcm-grub2

2011-06-02 Thread Raphael Kubo da Costa
Konstantinos Smanis writes: > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis > wrote: >>> The following line should probably be simplified (see >>> http://websvn.kde.org/?revision=1184860&view=revision): >>> >>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new >>> QTreeW

Re: Review Request: kcm-grub2

2011-06-01 Thread Konstantinos Smanis
On Thu, May 26, 2011 at 00:03, Konstantinos Smanis wrote: >> The following line should probably be simplified (see >> http://websvn.kde.org/?revision=1184860&view=revision): >> >> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new >> QTreeWidgetItem(ui.treeWidget_recover, QStrin

Re: Review Request: kcm-grub2

2011-05-25 Thread Konstantinos Smanis
> The following line should probably be simplified (see > http://websvn.kde.org/?revision=1184860&view=revision): > > src/kcm_grub2.cpp:113:QTreeWidgetItem *item = new > QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name > << partition->filePath() << volume->l

Re: Review Request: kcm-grub2

2011-05-24 Thread Alexander Potashev
2011/5/25 Konstantinos Smanis : > Any updates? The two week review period is over. The following line should probably be simplified (see http://websvn.kde.org/?revision=1184860&view=revision): src/kcm_grub2.cpp:113:QTreeWidgetItem *item = new QTreeWidgetItem(ui.treeWidget_reco

Re: Review Request: kcm-grub2

2011-05-24 Thread Konstantinos Smanis
On Thu, May 12, 2011 at 01:48, Konstantinos Smanis wrote: > On Tue, May 10, 2011 at 07:33, Ben Cooksley wrote: >> On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote: >>> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: I think kcm-grub2 has reached a pleasant level of maturity a

Re: Review Request: kcm-grub2

2011-05-12 Thread Konstantinos Smanis
On Tue, May 10, 2011 at 07:33, Ben Cooksley wrote: > On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote: >> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: >>> I think kcm-grub2 has reached a pleasant level of maturity and >>> includes enough features to be moved from playground/sysa

Re: Review Request: kcm-grub2

2011-05-10 Thread Albert Astals Cid
A Monday, May 09, 2011, Konstantinos Smanis va escriure: > On Tue, May 10, 2011 at 00:36, Christoph Feck wrote: > > On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: > >> I think kcm-grub2 has reached a pleasant level of maturity and > >> includes enough features to be moved from playgroun

Re: Review Request: kcm-grub2

2011-05-10 Thread Konstantinos Smanis
On Tue, May 10, 2011 at 00:36, Christoph Feck wrote: > On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: >> I think kcm-grub2 has reached a pleasant level of maturity and >> includes enough features to be moved from playground/sysadmin to >> extragear. >> >> Let me know if you have any obj

Re: Review Request: kcm-grub2

2011-05-09 Thread Ben Cooksley
On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote: > On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: >> I think kcm-grub2 has reached a pleasant level of maturity and >> includes enough features to be moved from playground/sysadmin to >> extragear. >> >> Let me know if you have any o

Re: Review Request: kcm-grub2

2011-05-09 Thread Christoph Feck
On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: > I think kcm-grub2 has reached a pleasant level of maturity and > includes enough features to be moved from playground/sysadmin to > extragear. > > Let me know if you have any objections. http://techbase.kde.org/Policies/SVN_Guidelines t

Review Request: kcm-grub2

2011-05-09 Thread Konstantinos Smanis
I think kcm-grub2 has reached a pleasant level of maturity and includes enough features to be moved from playground/sysadmin to extragear. Let me know if you have any objections. Git Repo: https://projects.kde.org/projects/playground/sysadmin/kcm-grub2/repository Regards, Konstantinos