Re: Review Request: Fix for stale permissions information in properties dialog

2013-01-03 Thread Dawit Alemayehu
> On Jan. 2, 2013, 3:18 p.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1080 > > > > > > I don't understand the if(). Why should the behavior differ depending > > on whether we have this url currently sh

Re: Review Request: Fix for stale permissions information in properties dialog

2013-01-02 Thread David Faure
> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Fix for stale permissions information in properties dialog

2013-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review24439 --- kio/kio/kdirlister.cpp

Re: Review Request: Fix for stale permissions information in properties dialog

2012-12-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- (Updated Dec. 29, 2012, 8:31 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Fix for stale permissions information in properties dialog

2012-08-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- (Updated Aug. 3, 2012, 7:04 p.m.) Review request for kdelibs and David Fau

Re: Review Request: Fix for stale permissions information in properties dialog

2012-01-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- (Updated Jan. 5, 2012, 9:48 p.m.) Review request for kdelibs and David Fau

Re: Review Request: Fix for stale permissions information in properties dialog

2012-01-02 Thread Dawit Alemayehu
> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Fix for stale permissions information in properties dialog

2011-12-28 Thread Dawit Alemayehu
> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Fix for stale permissions information in properties dialog

2011-12-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review9322 --- kio/kio/kdirlister.cpp

Review Request: Fix for stale permissions information in properties dialog

2011-12-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- Review request for kdelibs and David Faure. Description --- If you op