Re: New cmake warning.

2022-05-03 Thread Thomas Friedrichsmeier
On Tue, 3 May 2022 10:35:20 +0200 Méven wrote: > I am guessing you are using cmake >= 3.16 so it allows you to run, but > since the project does not have a cmake minimum, for others using > cmake < 3.16 the build will break. > This warning highlights it, so you inform your contributor they need >

Re: RKWard is in kdereview - again

2022-04-27 Thread Thomas Friedrichsmeier
Hi, On Wed, 27 Apr 2022 16:09:51 +0200 Thierry Thomas wrote: > I just upgraded RKWard to 0.7.3 (just locally, not yet in the ports > tree), and the patch of FindR.cmake is no more necessary. > > It builds and installs clearly, but I noticed 2 problems: > > 1- the tests do not run: > > > source

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
Am Wed, 30 Mar 2022 17:55:12 +0200 schrieb Thomas Friedrichsmeier : [...] > What's troubling me more is that QWebEngineView (used, among other > things, for Help->Help on RKWard) does not adapt to the color theme at > all. I tried adding CSS rules (@media (prefers-color-scheme: da

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
An update and some questions: Am Mon, 28 Mar 2022 15:39:55 +0200 schrieb Nicolas Fella : [...] > - Consider adding a color scheme selector (KColorSchemeManager) to the > menu. On Windows that gives you dark mode support for free (this only > really works nicely when using Breeze QStyle). See > htt

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 17:09:44 +0200 Nicolas Fella wrote: [...] > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > presumably due to having a different tar implementation than Linux. Sweet! > I'd appreciate if

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 00:09:38 +0200 Albert Astals Cid wrote: [...] > Results of running clang-tidy with some of my favorite options > attached. Thanks! > The first group [bugprone-integer-division] seems an actual bug since >double RKGraphicsDeviceFrontendTransmitter::lwdscale = 72/96; > m

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
Hi, On Mon, 28 Mar 2022 15:39:55 +0200 Nicolas Fella wrote: > I recently used RKWard for my Master Thesis, cool project! thanks! > A couple of observations: > > - CommitPolicy.txt still mentions Phabricator, that should point to > Gitlab instead Done. > - CommitPolicy.txt mentions Ubuntu Tru

RKWard is in kdereview - again

2022-03-26 Thread Thomas Friedrichsmeier
Hi! KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a previous review failed due to lack of time on my part. Sorry! Now, finally, I'd like to ask you to start reviewing RK

Re: RKWard 0.7.1 release candidate is available

2020-10-11 Thread Thomas Friedrichsmeier
Hi! On Sun, 11 Oct 2020 11:47:58 +0200 David Faure wrote: > If RKWard is being released, shouldn't it move out of playground? Well, yes, it should. Embarrassingly, last time RKWard moved to KDEreview, I went missing in the middle of the process. It's definitely still on our list, though: https:

Re: RKWard is in kdereview

2018-10-13 Thread Thomas Friedrichsmeier
Hi, On Sat, 13 Oct 2018 06:59:53 +0200 Thomas Baumgart wrote: > That's exactly how kate behaves. Using krunner to start it always > creates a new instance. Using the 'Open with' option in dolphin opens > the file in an existing instance. Or am I missing something? Maybe, > you take a look at kate

Re: RKWard is in kdereview

2018-10-12 Thread Thomas Friedrichsmeier
meter "--reuse" to select the desired behavior. But how to fit both into a single .desktop file? Regards Thomas > On Wed, 10 Oct 2018 at 17:33, Thomas Friedrichsmeier > wrote: > > > > On Wed, 10 Oct 2018 18:24:38 +0200 > > meik michalke wrote: > > > how

Re: RKWard is in kdereview

2018-10-10 Thread Thomas Friedrichsmeier
On Wed, 10 Oct 2018 18:24:38 +0200 meik michalke wrote: > how would it affect our various PPAs if there was no debian/ > directory in the sources? In fact, we'd have to keep the debian packaging somewhere, and "merge" it into the sources while building (we do the same for translations in the PPAs

Re: RKWard is in kdereview

2018-10-10 Thread Thomas Friedrichsmeier
Hi! Thanks for your first feedback items. I'll try to respond to everything, eventually, but I'm probably not going to be too fast. (Albert: I'll get back to your items!) On Wed, 10 Oct 2018 11:21:05 +0100 Jonathan Riddell wrote: > It installs two desktop files which creates duplicate menu entri

RKWard is in kdereview

2018-10-06 Thread Thomas Friedrichsmeier
round. Looking forward to your feedback! Thomas Friedrichsmeier for the RKWard team pgpMAeppCXr4J.pgp Description: OpenPGP digital signature

GDPR, privacy notices - any action required for individual projects?

2018-05-10 Thread Thomas Friedrichsmeier
Hi! A co-developer recently pointed out that EU General Data Protection Regulation (GDPR) is going to come into effect, soon (May 25th). To my _very_ limited understanding, this will require privacy notices on all websites. I see some kde.org sites already have one (e.g. https://community.kde.org/

Re: Required VS compiler

2016-04-02 Thread Thomas Friedrichsmeier
Hi, sorry for the late reply. On Sat, 26 Mar 2016 16:07:03 +0100 Dominik Haumann wrote: > On Wed, Mar 23, 2016 at 7:51 AM, Thomas Friedrichsmeier > wrote: > > On Mon, 21 Mar 2016 22:07:57 +0100 > > Dominik Haumann wrote: > [...] > >> Therefore, I would lik

Re: Required VS compiler

2016-03-22 Thread Thomas Friedrichsmeier
Well, this thread is already split across two lists, so I'm cross-replying... On Mon, 21 Mar 2016 22:07:57 +0100 Dominik Haumann wrote: > I installed Qt 5.6.0 and MSVC 2015, and surprisingly Kate > including all its dependencies compiled out of the box. > > I still see QStringLiteral fixes from

Re: Sunsetting of Infrastructure and the Phabricator migration

2016-03-18 Thread Thomas Friedrichsmeier
Hi! On Fri, 18 Mar 2016 19:46:03 +1300 Ben Cooksley wrote: > We will be creating > a mechanism which will allow repositories following certain naming > conventions to be easily created by developers (although this will > have to be done through the web interface). And in another mail: > That na

Re: Policy regarding QtWebKit and QtScript

2016-03-06 Thread Thomas Friedrichsmeier
Hi, sorry for a somewhat bitter tone, I find it a bit hard to avoid(*): On Sat, 5 Mar 2016 11:37:48 +0100 Allan Sandfeld Jensen wrote: > On Saturday 05 March 2016, Thomas Lübking wrote: > > On Samstag, 5. März 2016 08:09:22 CEST, Thomas Friedrichsmeier > > wrote: > > > Q

Re: Policy regarding QtWebKit and QtScript

2016-03-05 Thread Thomas Friedrichsmeier
Hi, On Sat, 05 Mar 2016 09:58:34 +0100 Niels Ole Salscheider wrote: > On Saturday, 5 March 2016, 08:09:22 CET, Thomas Friedrichsmeier wrote: > > This is not only an uncomfortable situation for a free software > > project to be in. If you're trying to interface with thir

Re: Policy regarding QtWebKit and QtScript

2016-03-05 Thread Thomas Friedrichsmeier
Hi, On Sat, 05 Mar 2016 10:35:23 +0100 Thomas Lübking wrote: > On Samstag, 5. März 2016 08:09:22 CEST, Thomas Friedrichsmeier wrote: > > QtWebEngine can _only_ be compiled using (free > > as in beer) MSVC 2013. In particular, MinGW is explicitly _not_ > > supported. >

Re: Policy regarding QtWebKit and QtScript

2016-03-04 Thread Thomas Friedrichsmeier
Hi, On Fri, 25 Dec 2015 12:42:26 +0100 Milian Wolff wrote: > Sorry, but how is "it takes long to compile" and argument for or > against a piece of software if there is no feature equivalent > alternative that takes less time to compile? > > Qt WebEngine is far easier to compile than Qt WebKit in

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-10 Thread Thomas Friedrichsmeier
Hi, On Wed, 09 Dec 2015 11:51:43 +0100 Jan Kundrát wrote: [...] > There is active work within the DMARC WG, with first drafts being > published only *two months ago* [1]. My suggestion for everybody who > doesn't have time to follow this process is to sit back, relax, and > watch the IETF come up

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Thomas Friedrichsmeier
Hi, On Tue, 27 Jan 2015 03:30:48 +0100 Thomas Lübking wrote: > On Samstag, 24. Januar 2015 15:24:28 CET, Thomas Friedrichsmeier > wrote: > > > But beyond review functionality, I think moving towards a more > > integrated solution is clearly a step in the right direction,

Re: Sysadmin report on the modernization of our infrastructure

2015-01-24 Thread Thomas Friedrichsmeier
Hi! On Wed, 21 Jan 2015 17:12:07 +1300 Ben Cooksley wrote: > Hi all, > > As promised in the earlier thread, i'd like to present the sysadmin > report on the state of the infrastructure surrounding our code. > > It contains a detailed summary of what is broken with our existing > systems, why ch

Re: Changes to our Git infrastructure

2015-01-06 Thread Thomas Friedrichsmeier
On Tue, 06 Jan 2015 13:19:45 +0100 Jan Kundrát wrote: > On Monday, 5 January 2015 14:03:13 CEST, Thomas Friedrichsmeier wrote: > > I think there is an easy test for this (well, not a real test, but a > > useful initial heuristic): Can you explain exactly how to submit a > > p

Re: Changes to our Git infrastructure

2015-01-05 Thread Thomas Friedrichsmeier
Hi, On Mon, 05 Jan 2015 10:37:24 +0100 Jan Kundrát wrote: > On Sunday, 4 January 2015 13:21:12 CEST, Thomas Friedrichsmeier wrote: > > True, but don't forget about the other side of the story: > > - potential contributors will have to learn more stuff, before they &g

Re: Changes to our Git infrastructure

2015-01-04 Thread Thomas Friedrichsmeier
On Sun, 04 Jan 2015 00:37:49 +0100 Jan Kundrát wrote: > My goal is to help bridge the gap between the existing project > maintainers (who produce software in git trees) and the new > contributors (who produce patches). If we can offload the management > of git trees to the contributors, then the f

Re: Changes to our Git infrastructure

2014-12-29 Thread Thomas Friedrichsmeier
On Mon, 29 Dec 2014 16:19:37 -0500 "Jeff Mitchell" wrote: > On 29 Dec 2014, at 15:20, Thomas Friedrichsmeier wrote: > > I am absolutely not qualified to comment on the pain this is > > causing to > > you sysadmins. But are we talking about / is the problem inher

Re: Changes to our Git infrastructure

2014-12-29 Thread Thomas Friedrichsmeier
Hi, On Mon, 29 Dec 2014 14:41:03 -0500 "Jeff Mitchell" wrote: > I just want to point out that scratch repos may be useful to some > people, but are also the easiest repo type for anyone to host > anywhere, including on their own local filesystem. The concept was a > bit flawed from the beginning

Re: Changes to our Git infrastructure

2014-12-29 Thread Thomas Friedrichsmeier
Hi, On Mon, 29 Dec 2014 12:13:38 -0500 "Jeff Mitchell" wrote: > On 29 Dec 2014, at 11:36, Jan Kundrát wrote: > > I agree with scratch repos being useful as a first step. > > Except nobody deletes it. That's a large problem. Scratch is nice in > concept but it's a sysadmin nightmare. > > Out of

Re: Changes to our Git infrastructure

2014-12-27 Thread Thomas Friedrichsmeier
Hi, On Tue, 23 Dec 2014 13:21:37 +0100 Milian Wolff wrote: > Here's a list of things that I'd like to have for my workflow, which > is basically two folded: On one hand, I actively develop new software > and new features. On the other hand, I spent a considerable amount of > KDE time reviewing ot

Re: Changes to branch management

2014-12-25 Thread Thomas Friedrichsmeier
On Thu, 25 Dec 2014 20:21:05 +1300 Ben Cooksley wrote: [...] > > 1) Everybody can create, delete and force-push to all branches > > except the "reserved" ones (kde/*, master, stable,... see the list). > > > > 2) People are free to create, delete and force-push to all branches > > below my/$usernam

Re: Changes to branch management

2014-12-24 Thread Thomas Friedrichsmeier
Hi! On Wed, 24 Dec 2014 14:11:46 +1300 Ben Cooksley wrote: > That brings the list of protected branches requested thus far to: > > master > frameworks > KDE/* > Applications/* > Plasma/* > Calligra/* > > Any others? Extragear apps may have different names for release series branches. For RKWar

Re: QtScript considered dangerous

2012-05-24 Thread Thomas Friedrichsmeier
-- Note: Reposting to follow Dominik's example of CCing kde-core-devel -- Hi, On Wednesday 23 May 2012, Milian Wolff wrote: > We have port Kate away from QtScript. I'm not sure, whether this is a serious suggestion, or just a way to catch attention. In the latter case: it worked. In the former

Re: Frameworks mailing list

2011-11-20 Thread Thomas Friedrichsmeier
Hi, I'll start with the bottom of your mail, and only add some clarifications after that. On Saturday 19 November 2011, Aaron J. Seigo wrote: > so .. to summarize: > > * k-c-d needs more active guidance, and that guidance needs the support of > core members of the community > > * decisions nee

Re: Frameworks mailing list

2011-11-19 Thread Thomas Friedrichsmeier
Hi, I don't want to play the blame-game. But I'm really worried about this tendency to take essential discussions to side-channels. So I'm sorry to continue on one of those another lengthy meta discussions. On Saturday 19 November 2011, Aaron J. Seigo wrote: > On Thursday, November 17, 2011 18:

Re: Frameworks mailing list

2011-11-16 Thread Thomas Friedrichsmeier
On Wednesday 16 November 2011, Albert Astals Cid wrote: > In case someone is interested since it has never mentioned in this list, > there is a frameworks mailing list at kde-frameworks-devel > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel So why have this discussion on a separate lis

Re: Request: remove libkactivites from kdelibs (in experimental/)

2011-11-14 Thread Thomas Friedrichsmeier
Hi, On Monday 14 November 2011, Aaron J. Seigo wrote: > besides kde-core-devel, it was also blogged by a number of attendees, so > planetkde.org readership was in the loop. there was a story on dot.kde.org, > so dot.kde.org readership was in the loop. there's documentation on > community.kde.org

Re: Review Request: Put an end to plugin statusbar icon leaks

2011-10-05 Thread Thomas Friedrichsmeier
ttp://git.reviewboard.kde.org/r/101653/diff/diff Testing --- Thanks, Thomas Friedrichsmeier

Re: Review Request: Put an end to plugin statusbar icon leaks

2011-10-01 Thread Thomas Friedrichsmeier
ffs (updated) - kparts/statusbarextension.h 69691d7 kparts/statusbarextension.cpp 11fdf40 Diff: http://git.reviewboard.kde.org/r/101653/diff/diff Testing --- Thanks, Thomas Friedrichsmeier

Review Request: Do not force lowercase in KFileDialog automatic file name extension

2011-09-16 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102632/ --- Review request for kdelibs, David Faure and Clarence Dang. Summary ---

Review Request: One step towards fixing plugin statusbar icon leak

2011-06-17 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101653/ --- Review request for kdelibs. Summary --- I guess this one needs some e

Re: Review Request: Fix keypress stealing issue

2011-06-08 Thread Thomas Friedrichsmeier
On Monday 06 June 2011, David Faure wrote: > About the second question, here's my commit log for 60ae8626e917cb1f3: > > Re-route the old actions "Find Text as You Type" and "Find Links as You > Type" to the findbar. Remove them from the menu, since they are redundant > with "Find text", but ke

Review Request: Fix keypress stealing issue

2011-06-02 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101491/ --- Review request for kdelibs and David Faure. Summary --- Shortcut cont

Re: Review Request: Make sure to remove KXMLGUIClients from factory on destruction

2010-11-17 Thread Thomas Friedrichsmeier
This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4126/#review6354 --- On 2010-06-01 07:15:25, Thomas Friedrichsmeier wrote: > > -