/kauthactionreply.cpp 53b0e39
Diff: http://git.reviewboard.kde.org/r/108822/diff/
Testing
---
Compiles against KDE 4.10.0.
Thanks,
Konstantinos Smanis
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote:
> > We can do better than hardcoding a reasonable default. We can launch a
> > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages:
> >
> > 1. We don't miss paths (e.
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote:
> > We can do better than hardcoding a reasonable default. We can launch a
> > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages:
> >
> > 1. We don't miss paths (e.
ther shell-specific login scripts (such as ~/.bash_profile for Bash).
- Konstantinos Smanis
On Feb. 2, 2013, 8:27 a.m., Kevin Kofler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
- Konstantinos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review17055
---
On Aug. 7, 2012, 3:56 p.m., Konstantino
ond screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
> On Aug. 7, 2012, 1:25 p.m., Oswald Buddenhagen wrote:
> > kdm/backend/util.c, line 205
> > <http://git.reviewboard.kde.org/r/105563/diff/16/?file=76460#file76460line205>
> >
> > len isn't actually used in that loop
>
> Konstantinos Smanis wrote
------
On Aug. 7, 2012, 1:37 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105563/
> ---
ond screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
uced in my system with `grub2-mkconfig`.
Also works with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
then you need a condition to track when
> > you need to pop items - but that's still shorter and more elegant than this
> > findMenu stuff, i think).
>
> Konstantinos Smanis wrote:
> I could be wrong but how is this gonna work with nested submenus?
>
>
ond screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
-
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review16926
---
On Aug. 5, 2012, 1:25 p.m., Konstantinos Smanis wrote:
>
>
em with `grub2-mkconfig`.
Also works with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Th
kconfig`.
Also works with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
gt; > solution of the general nested case.
>
> Konstantinos Smanis wrote:
> I noticed that my menuentry-case code kinda duplicates the old code but
> could you please elaborate a little more on this? I am not sure I get how you
> want the implementation. If-nesting for sub
> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote:
> > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we
> > should drop the ksmserver part? It doesn't apply on the 4.9 branch.
>
> Lamarque Vieira Souza wrote:
> We still nee
yet). Maybe we
should drop the ksmserver part? It doesn't apply on the 4.9 branch.
- Konstantinos Smanis
On Aug. 1, 2012, 8:54 a.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
nu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
e I get how you want
the implementation. If-nesting for submenus and simple actions outside of it?
- Konstantinos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review1
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review16719
-------
On July 31, 2012, 5:54 p.m., Konstantinos Smanis wrote:
>
> -
am missing something?
- Konstantinos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review16717
---
On July 31, 201
each boot manager's separator in the set* functions.
- Konstantinos Smanis
On July 31, 2012, 5:54 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. To r
n's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
Smanis
On July 30, 2012, 12:31 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
nu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
g`.
Also works with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
o works with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
ly generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review16624
---
On July 29, 2012, 7:05 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an auto
in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
------
On July 29, 2012, 6:06 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105563/
> ---
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
,5 +797,5 @@ processCtrl(const char *string, int len, int fd,
> > struct display *d)
> > }
> > freeStrArr(opts);
> > -writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\n", def, cur));
> > +writer(fd
,5 +797,5 @@ processCtrl(const char *string, int len, int fd,
> > struct display *d)
> > }
> > freeStrArr(opts);
> > -writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\n", def, cur));
> > +writer(fd
enus"
> > needs to be only a stack of integers (and you can just allocate a
> > fixed-size array for that - nobody is going to nest beyond 3 (does grub
> > even support nesting? i didn't gather that impression).
>
> Konstantinos Smanis wrote:
> Grub2 now s
enus"
> > needs to be only a stack of integers (and you can just allocate a
> > fixed-size array for that - nobody is going to nest beyond 3 (does grub
> > even support nesting? i didn't gather that impression).
>
> Konstantinos Smanis wrote:
> Grub2 now s
,5 +797,5 @@ processCtrl(const char *string, int len, int fd,
> > struct display *d)
> > }
> > freeStrArr(opts);
> > -writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\n", def, cur));
> > +writer(fd
bution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
the
> > two counts makes little sense.
>
> Konstantinos Smanis wrote:
> True, but we still have to know if a closing brace is from a 'menuentry'
> or a 'submenu'.
I could drop both counters and use an unsigned char as bool for marking when we
are inside
,5 +797,5 @@ processCtrl(const char *string, int len, int fd,
> > struct display *d)
> > }
> > freeStrArr(opts);
> > -writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\n", def, cur));
> > +writer(fd
; }
> > freeStrArr(opts);
> > -writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\n", def, cur));
> > +writer(fd, cbuf, sprintf(cbuf, "\t%d\t%d\t%s\n", def, cur,
> > sep));
> >
om menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
visit:
http://git.reviewboard.kde.org/r/105563/#review16037
---
On July 17, 2012, 9:23 p.m., Konstantinos Smanis wrote:
>
> ---
> This is an automatically generated e-mail. T
reenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
.org/r/105563/).
- Konstantinos Smanis
On July 14, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.rev
- Konstantinos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review16017
---
On July 14, 2012, 8:16 a.m., Konstantinos Smanis wrote:
>
> --
org/r/105568/
> ---
>
> (Updated July 14, 2012, 6:53 p.m.)
>
>
> Review request for KDE Runtime and Konstantinos Smanis.
>
>
> Description
> ---
>
> Add support to show submenus in the new QML shutdown dialog. I think this
> patch can be improved, the GUI too.
> On July 14, 2012, 12:18 p.m., Konstantinos Smanis wrote:
> > My QML knowledge is too limited to review your code, but I tested your
> > patch and have the following remarks to make:
> >
> > 1) There is some flickering when hovering a menu item. Dunno if it has to
> On July 14, 2012, 12:18 p.m., Konstantinos Smanis wrote:
> > My QML knowledge is too limited to review your code, but I tested your
> > patch and have the following remarks to make:
> >
> > 1) There is some flickering when hovering a menu item. Dunno if it has to
rovisioned for this). A double ampersand is shown
as a single.
3) When the menu item's text is small (~4-5 characters), the arrow is shown
very close to the text.
The core functionality seems to be fine, I onlyn noticed the above GUI issues.
- Konstantinos Smanis
On July 14, 2012, 5:48 a.
with a custom menu file I made (as shown in the second screenshot).
Screenshots
---
Distribution's stock menu file
http://git.reviewboard.kde.org/r/105563/s/633/
A custom menu file for testing
http://git.reviewboard.kde.org/r/105563/s/634/
Thanks,
Konstantinos Smanis
On Sat, Jul 7, 2012 at 1:02 AM, Lamarque V. Souza wrote:
> Em Friday 06 July 2012, Konstantinos Smanis escreveu:
>
>> Hi,
>
>
>
> Hi,
>
>> I am working on a patch for bug #297209
>
>> (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help
tMenu component).
I wouldn't like to dig in QML just for this and I think it makes more
sense if the list was centrally generated and not in every theme.
Still, if the code should reside in the theme, I would appreciate any
pointers as to how implement submenus in the context menu.
--
Konstantinos Smanis
.cpp (7d72a88)
>
> View Diff
I tested the patch against 4.8.3, works as expected.
However, I too think that this option should be implemented somewhere
else in the stack (udisks/udev: whatever is most fit). Although a sane
default, you should be able to configure it more easily.
--
Konstantinos Smanis
4785/#comment10220>
Same here.
kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10221>
Same here.
- Konstantinos Smanis
On April 29, 2012, 6:48 p.m., Dawit Alemayehu wrote:
>
> -
On Wed, Jan 4, 2012 at 20:46, Albert Astals Cid wrote:
> El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va
> escriure:
>> On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote:
>> > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis
On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote:
> El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va
> escriure:
>> Hi,
>>
>> kcm-grub2 has been in kdereview for months. It would be great if it
>> could be moved back or forth. I am
Hi,
kcm-grub2 has been in kdereview for months. It would be great if it
could be moved back or forth. I am planning a new release soon, I
wouldn't like to abuse kdereview.
Regards,
Konstantinos
Is it a bug or feature that no enviroment variables (most notably
$PATH) are set for DBus-activated KAuth helpers?
Manually launching the helper from a shell doesn't lead to this
behaviour: enviroment variables are properly set.
Konstantinos Smanis
Raphael Kubo da Costa gmail.com> writes:
>
> Konstantinos Smanis gmail.com> writes:
>
> > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he
> > has agreed to give up his request for inclusion in extragear.
> >
> > Our conversation h
Raphael Kubo da Costa gmail.com> writes:
> Konstantinos Smanis gmail.com> writes:
>
> > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis
> > gmail.com> wrote:
> >>> The following line should probably be simplified (see
> >>> ht
On Thu, May 26, 2011 at 00:03, Konstantinos Smanis
wrote:
>> The following line should probably be simplified (see
>> http://websvn.kde.org/?revision=1184860&view=revision):
>>
>> src/kcm_grub2.cpp:113: QTreeWidgetItem *item = new
>> QTr
> The following line should probably be simplified (see
> http://websvn.kde.org/?revision=1184860&view=revision):
>
> src/kcm_grub2.cpp:113:QTreeWidgetItem *item = new
> QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name
> << partition->filePath() << volume->l
On Thu, May 12, 2011 at 01:48, Konstantinos Smanis
wrote:
> On Tue, May 10, 2011 at 07:33, Ben Cooksley wrote:
>> On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote:
>>> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote:
>>>> I think kcm-grub2 has reache
On Tue, May 10, 2011 at 07:33, Ben Cooksley wrote:
> On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote:
>> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote:
>>> I think kcm-grub2 has reached a pleasant level of maturity and
>>> includes enough features
On Tue, May 10, 2011 at 00:36, Christoph Feck wrote:
> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote:
>> I think kcm-grub2 has reached a pleasant level of maturity and
>> includes enough features to be moved from playground/sysadmin to
>> extragear.
>>
>
I think kcm-grub2 has reached a pleasant level of maturity and
includes enough features to be moved from playground/sysadmin to
extragear.
Let me know if you have any objections.
Git Repo:
https://projects.kde.org/projects/playground/sysadmin/kcm-grub2/repository
Regards,
Konstantinos
69 matches
Mail list logo
