Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-14 Thread Andriy Rysin
Neo 2. Could you please take a look? Thanks. - Andriy Rysin On Nov. 5, 2013, 3:22 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts

2013-06-19 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110285/#review34718 --- Ship it! Ship It! - Andriy Rysin On May 3, 2013, 11 a.m

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

2013-05-01 Thread Andriy Rysin
If the feature freeze for 4.11 is May 22 and there is no more feature releases for branch 4.x, where all those features from GSoC go? I don't think students should work on version 5 yet... On May 1, 2013 9:16 AM, "Aaron J. Seigo" wrote: > ** > > Hello everyone, > > > > tl;dr -> 4.11 will be the l

Re: Input method integration for KDE 4.11

2013-01-31 Thread Andriy Rysin
gt; On Sat, Jan 26, 2013 at 3:41 AM, Andriy Rysin wrote: > > > On 01/15/2013 03:11 PM, Weng Xuetian wrote: > > >> Hi, > > >> Under linux, input method is always being a mess: > > >> 1. Start it correctly > > >> ubuntu, debian: im-switch, im

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-31 Thread Andriy Rysin
> On Jan. 26, 2013, 3:13 a.m., Andriy Rysin wrote: > > Manuel, I like how it looks in general with rounded corners and space > > between keys, but I must say that the font size is quite small. E.g. small > > letters are not easy to read even with good eyes, I wander if

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-25 Thread Andriy Rysin
so we can't use active geometry. Although that might not be that big of a problem if we actually do use active one (if user switches keyboard model he would just have to apply before opening layout preview). - Andriy Rysin On Jan. 12, 2013, 5:13 p.m.,

Re: Input method integration for KDE 4.11

2013-01-25 Thread Andriy Rysin
Hi I am a current (even if somewhat recently passive :)) KDE keyboard module maintainer and I promised Weng to reply so here it goes. 1. I've never used IM and have pretty vague understanding how it works so I am open for discussion 2. I don't plan to use IM (current keyboard layout implement

Re: Review Request: This change will allow the user to see keyboard layout visually

2012-11-05 Thread Andriy Rysin
://git.reviewboard.kde.org/r/107202/diff/ Testing --- Screenshots --- Keyboard Layout Preview http://git.reviewboard.kde.org/r/107202/s/813/ Thanks, Andriy Rysin

Re: merging development branch into master

2012-11-04 Thread Andriy Rysin
On 11/04/2012 01:18 AM, Shaun Reich wrote: well, you've got until november 8th (4 days according to my clock) until hard feature freeze which blocks even those on the planned feature list. so, as my procrastinating self would say you've got "plenty of time" ;) done: https://git.reviewboard.kd

Review Request: This change will allow the user to see keyboard layout visually

2012-11-04 Thread Andriy Rysin
, Andriy Rysin

Re: merging development branch into master

2012-11-04 Thread Andriy Rysin
On 11/04/2012 01:18 AM, Shaun Reich wrote: well, you've got until november 8th (4 days according to my clock) until hard feature freeze which blocks even those on the planned feature list. so, as my procrastinating self would say you've got "plenty of time" ;) ok, I tried to do post-review -n

Re: merging development branch into master

2012-11-03 Thread Andriy Rysin
Yes, it's in feature list for 4.10 I can try to submit it to review if I have time tomorrow, but wouldn't it be a bit too late? Thanks, Andriy On Nov 4, 2012 12:17 AM, "Shaun Reich" wrote: > >* I guess once the branch is merged it should be closed for business: > fixes go >into master and new f

merging development branch into master

2012-11-03 Thread Andriy Rysin
Hi all My student for SoK (Shivam Makkar) was working on a feature this summer (to show preview of a keyboard layout) and I think it's ready to be included in 4.10 (although some improvements and cleanup would not hurt a bit later). It seems that we're getting close to feature freeze so I'd l

Right location for test config files?

2011-11-21 Thread Andriy Rysin
In regards to defect below, what's the right location for some xml files I use in keyboard daemon tests? Currently the files I have is to test the code for parsing /usr/share/X11/xkb/rules/evdev.xml but some others could be added later... I tried to find other tests in kde-workspace but none o

Re: detection if applet is running

2011-10-29 Thread Andriy Rysin
On 10/29/2011 06:38 AM, Aaron J. Seigo wrote: On Saturday, October 29, 2011 12:18:00 Ruurd Pels wrote: On Friday 28 October 2011 12:46:38 Andriy Rysin wrote: Yes, but I can get the keyboard layouts from x11 directly (that's what applets and systray is doing), that'll be more eff

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 12:41 PM, Aaron J. Seigo wrote: On Friday, October 28, 2011 11:26:05 Andriy Rysin wrote: We already have that dbus API in keyboard kded daemon could the kded daemon be checked to see if keyboard layouts are available, and if so, show that button in the unlock dialog? does it

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 02:38 AM, Aaron J. Seigo wrote: On Thursday, October 27, 2011 23:35:52 Andriy Rysin wrote: 2) make keyboard layout applet exposes some dbus to make it detectable when running (feels a bit too "heavy") that would be a preferred way ... note, however, that one can hav

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 09:20 AM, Ruurd Pels wrote: On Thursday 27 October 2011 23:35:52 Andriy Rysin wrote: 2) make keyboard layout applet exposes some dbus to make it detectable when running (feels a bit too "heavy") Yes. Better. Why does it feel heavy? I'd venture the thought that

detection if applet is running

2011-10-27 Thread Andriy Rysin
I need to detect if keyboard layout indicator applet is running and show the keyboard layout button in the screen lock dialog (bug 276692 ). Currently it only checks if "indicator" option is on which turns on systray icon but user can bypass that opt

Re: Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

2011-10-23 Thread Andriy Rysin
? and using "--tab=" will allow adding other params later easier - Andriy Rysin On Oct. 23, 2011, 10:36 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

solid/networking.h: No such file or directory

2011-05-21 Thread Andriy Rysin
pulled from git seconds ago, compiled with Profile=Mobile [ 62%] Building CXX object kio/misc/kpac/CMakeFiles/kded_proxyscout.dir/proxyscout.o /home/arysin/work/OSS/KDE/kdelibs/kio/misc/kpac/proxyscout.cpp:32:30: fatal error: solid/networking.h: No such file or directory

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-21 Thread Andriy Rysin
from KDE 4.6. Most likely you need to do a clean build. At lease a clean kdewebkit build. On Sat, May 21, 2011 at 10:59 AM, Andriy Rysin wrote: In file included from /home/arysin/work/OSS/KDE/kdelibs/kdewebkit/kgraphicswebview.cpp:85:0: /home/arysin/kde/build/KDE/kdelibs/kdewebkit/kgraphicswebview

kdewebkit compilation fails for Mobile profile in trunk

2011-05-21 Thread Andriy Rysin
In file included from /home/arysin/work/OSS/KDE/kdelibs/kdewebkit/kgraphicswebview.cpp:85:0: /home/arysin/kde/build/KDE/kdelibs/kdewebkit/kgraphicswebview.moc: In member function ‘virtual int KGraphicsWebView::qt_metacall(QMetaObject::Call, int, void**)’: /home/arysin/kde/build/KDE/kdelibs/kde

Nepomuk dependency is optional for dolphin but not for its tests

2011-05-21 Thread Andriy Rysin
When compiling kde-baseapps nepomuk is optional: - -- The following OPTIONAL packages could NOT be located on your system. -- Consider installing them to enable more features from this software. ---

Re: saving/restoring session in kded module

2011-04-29 Thread Andriy Rysin
On 04/28/2011 05:08 AM, David Faure wrote: On Saturday 16 April 2011, Andriy Rysin wrote: On 03/05/2011 11:32 AM, Andriy Rysin wrote: There seems to be plenty info on saving/restoring sessions for applications (i.e. the features in KApplication and KMainWindow classes) but I'd like to

Re: Window switch notification for plasma applets

2011-04-23 Thread Andriy Rysin
On 04/14/2011 12:40 PM, Aaron J. Seigo wrote: On Wednesday, April 13, 2011 20:31:01 Andriy Rysin wrote: well as per top-level windows. So the question is whether there's a way to tell "active/focused" applet and get notified on switch? ah, and getting the current view() for the

KStatusNotifierItem.showMessage() with custom icon

2011-04-17 Thread Andriy Rysin
In regards to https://bugs.kde.org/show_bug.cgi?id=66641 I am thinking to add an option to show notification when layout changes, and I already set the tooltip with text and my custom icon (if flags are shown) but showMessage() currently takes icon as QString. The question is can I pass QIcon

Re: saving/restoring session in kded module

2011-04-15 Thread Andriy Rysin
On 03/05/2011 11:32 AM, Andriy Rysin wrote: There seems to be plenty info on saving/restoring sessions for applications (i.e. the features in KApplication and KMainWindow classes) but I'd like to save/restore some information in KDED module (keyboard layouts to be exact) but only if re

Re: Window switch notification for plasma applets

2011-04-14 Thread Andriy Rysin
t too ugly. Thanks Andriy On Apr 14, 2011, at 12:39, "Aaron J. Seigo" wrote: > On Wednesday, April 13, 2011 20:31:01 Andriy Rysin wrote: >> So the question is whether there's a way to >> tell "active/focused" applet and get notified on switch? > > not cur

Window switch notification for plasma applets

2011-04-13 Thread Andriy Rysin
Currently the keyboard layout switcher (when in per-Window or per-Application mode) ignores the desktop when it becomes the active window. This was done intentionally so that when keyboard layout applet (on the desktop) is clicked it would change the current (or technically previous) active wi

saving/restoring session in kded module

2011-03-05 Thread Andriy Rysin
There seems to be plenty info on saving/restoring sessions for applications (i.e. the features in KApplication and KMainWindow classes) but I'd like to save/restore some information in KDED module (keyboard layouts to be exact) but only if restore session on login is set to true (I'd like not t

Re: api to get tray icon panel foreground color?

2011-02-19 Thread Andriy Rysin
On 02/18/2011 10:48 PM, Andriy Rysin wrote: On 02/18/2011 09:53 PM, Aaron J. Seigo wrote: On Friday, February 18, 2011, Andriy Rysin wrote: So the question is what's the API to get suggested tray foreground color? in Plasma, what we are doing right now is this: m_svg = new P

Re: api to get tray icon panel foreground color?

2011-02-18 Thread Andriy Rysin
On 02/18/2011 09:53 PM, Aaron J. Seigo wrote: On Friday, February 18, 2011, Andriy Rysin wrote: So the question is what's the API to get suggested tray foreground color? in Plasma, what we are doing right now is this: m_svg = new Plasma::Svg(this); m_svg->setI

api to get tray icon panel foreground color?

2011-02-18 Thread Andriy Rysin
In regards to https://bugs.kde.org/show_bug.cgi?id=266434 I've added a halo as suggested before and then had to increase its radius but it's still not a perfect solution for some themes. To provide reliable text in tray indicator needs to know suggested foreground color. Or background color but

Re: Epseranto flag

2011-02-06 Thread Andriy Rysin
On 02/06/2011 07:15 AM, Albert Astals Cid wrote: A Dissabte, 5 de febrer de 2011, Andriy Rysin va escriure: I have this "Add the Esperanto flag (please)" but (https://bugs.kde.org/show_bug.cgi?id=264533) and I don't feel like this flag belongs to just keyboard indicator. So

Epseranto flag

2011-02-05 Thread Andriy Rysin
I have this "Add the Esperanto flag (please)" but (https://bugs.kde.org/show_bug.cgi?id=264533) and I don't feel like this flag belongs to just keyboard indicator. So the question is whether we have or should have Esperanto flag somewhere in common place? And all the flags we have currently belo

Need help with "This module still uses K_EXPORT_COMPONENT_FACTORY"

2010-12-27 Thread Andriy Rysin
I need some help with KCModuleLoader: when I try to load kcm_keyboard in 4.6 I get this warning $ kcmshell4 kcm_keyboard kcmshell(946)/kcontrol KCModuleLoader::loadModule: This module still uses K_EXPORT_COMPONENT_FACTORY. Please port it to use KPluginFactory and K_EXPORT_PLUGIN. so it fails

kdewebkit fails to build with Mobile profile in trunk

2010-12-26 Thread Andriy Rysin
Commenting out two deprecated methods helped but that's probably a wrong solution. In file included from /home/kdeuser/work/OSS/KDE/kdelibs/kdewebkit/kgraphicswebview.cpp:85:0: /home/kdeuser/kde/build/KDE/kdelibs/kdewebkit/kgraphicswebview.moc: In member function 'virtual int KGraphicsWebView

Re: screensaver activation notification

2010-11-20 Thread Andriy Rysin
2010/11/20 Oswald Buddenhagen > On Sat, Nov 20, 2010 at 11:28:25AM -0500, Andriy Rysin wrote: > > Could anybody point me to an (easy) way to listen to screensaver/lock > dialog > > activation so I can provide separate layout for it? > > > you could have trivi

screensaver activation notification

2010-11-20 Thread Andriy Rysin
There's a request for keyboard layout to be remembered differently for screen lock dialog when in (by window mode) https://bugs.kde.org/show_bug.cgi?id=246301 Seems like the keyboard daemon does not get activeWindowChanged event when screensaver activated (or lock dialog is shown). Could anybody po