Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-01 Thread Martin Gräßlin
> On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the fu

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75184 --- startkde/kcminit/CMakeLists.txt

Re: Review Request 122276: [OS X] use a more representative Display stub typedef

2015-02-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122276/ --- (Updated Feb. 1, 2015, 11:32 p.m.) Review request for KDE Software on Mac

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75179 --- -1 for not submitting this upstream for shared-mime-info. I t

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread Denis Steckelmacher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/ --- (Updated Feb. 1, 2015, 7:28 p.m.) Status -- This change has been mar

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 --- Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48 p.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75090 --- thumbnail/thumbnail.cpp

Re: Another proposal for modernization of our infrastructure

2015-02-01 Thread Thiago Macieira
On Saturday 31 January 2015 20:56:41 Martin Graesslin wrote: > I have to agree. Whenever I need to do a change for Qt I need to google for > how to do it. Including putting serious thought in how the push command > must look like, how I need to adjust the examples provided and for which > ref/for/

Re: Another proposal for modernization of our infrastructure

2015-02-01 Thread Thiago Macieira
On Saturday 31 January 2015 20:37:31 Christoph Feck wrote: > On Saturday 31 January 2015 20:07:42 Eike Hein wrote: > > [...] Qt is using gerrit and we intend to remain a major stakeholde > > in Qt development, which means a sizable number of KDE developers > > need to be familiar with gerrit anyway

Re: Another proposal for modernization of our infrastructure

2015-02-01 Thread Thiago Macieira
On Friday 30 January 2015 10:57:33 Ben Cooksley wrote: > Given that upstream has had multiple attempts now at an improved > interface, I would question whether they would be willing to accept a > user interface which is suitable for our needs. It appears that they > are quite comfortable with an in

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2015-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108434/ --- (Updated Feb. 1, 2015, 12:20 nachm.) Status -- This change has been

Re: Review Request 108312: Use view-certificate for SSL settings KCM

2015-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108312/ --- (Updated Feb. 1, 2015, 12:14 nachm.) Status -- This change has been

Re: Review Request 110084: Make ftp error messages prettier

2015-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110084/ --- (Updated Feb. 1, 2015, 12:11 nachm.) Status -- This change has been

Re: Review Request 122212: [baseapps] Make tests optional

2015-02-01 Thread Andreas Sturmlechner
> On Jan. 23, 2015, 10:07 a.m., Emmanuel Pescosta wrote: > > Ship It! I'm glad you like it! Without write access, I need to ask for someone else to merge. - Andreas --- This is an automatically generated e-mail. To reply, visit: https: