-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108434/
-----------------------------------------------------------

(Updated Feb. 1, 2015, 12:20 nachm.)


Status
------

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
-------

It took me hours (really, it's like. System Settings adds a KCModuleProxy which 
calls KCModuleLoader to load a KCModule which is in some different directory 
which uses KPageDialog (where I looked at first …) which uses KPageWidget which 
is a private class inside which then uses KPageView bla.. :D)

Finally got it and made it use the MainToolbar size which also defaults to 
22px, so you won't notice any difference, but users of MacBook Pro Retina and 
similar devices will appreciate. Also makes it unified a bit because it is 
always the toolbar icon size.


Diffs
-----

  kdeui/paged/kpageview.cpp 8863934 

Diff: https://git.reviewboard.kde.org/r/108434/diff/


Testing
-------

Yup, see screenshots.

Only minor problem is that it doesn't react to when the icon size changes (like 
buttons and other elements do).


File Attachments
----------------

KPageDialog icon adapted
  https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconding.png


Thanks,

Kai Uwe Broulik

Reply via email to