Re: Review Request: kde-workspace KDE/4.9 broken

2012-07-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105522/#review16099 --- This review has been submitted with commit d929ac6da7adf6eea04

Review Request: Do not crash avahi DNSSD service

2012-07-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105613/ --- Review request for kdelibs, KTorrent, Joris Guisson, and Thiago Macieira.

Re: Review Request: Port K_GLOBAL_STATIC in kdecore to Q_GLOBAL_STATIC

2012-07-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105603/#review16089 --- This review has been submitted with commit 98d4018a36991e017be

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-18 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16066 --- dolphin/src/dolphinpart.cpp

Re: Scope of kde-frameworks-devel and k-c-d mailing lists

2012-07-18 Thread David Faure
On Wednesday 18 July 2012 07:05:28 Laszlo Papp wrote: > I am having this question: where should the frameworks review requests go? Yep, I was thinking the same, we should open a "frameworks" area in reviewboard, and have these requests sent to kde-frameworks-de...@kde.org. I'll file a sysadmin r

Re: Review Request: Port K_GLOBAL_STATIC in kdecore to Q_GLOBAL_STATIC

2012-07-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105603/#review16063 --- Looks good, just one issue (*3). Thanks! (feel free to commit

Re: Review Request: Support for GRUB2 submenus

2012-07-18 Thread Konstantinos Smanis
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is