----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105603/#review16063 -----------------------------------------------------------
Looks good, just one issue (*3). Thanks! (feel free to commit after adjusting) kdecore/services/kservicetypeprofile.cpp <http://git.reviewboard.kde.org/r/105603/#comment12638> The point of the exists() call in this particular instance, was to avoid creating the singleton just to clear it. With the Qt4/Qt-5.0 Q_GLOBAL_STATIC, I don't think there's API for that. But it's part of the planned-for-Qt-5.1 merge request from Thiago, so I suggest adding a ### Qt-5.1 TODO: .exists() Or even better, so we don't forget, #if QT_VERSION >= QT_VERSION_CHECK(5,1,0) if (s_serviceTypeProfiles.exists()) #else ... #endif kdecore/services/kservicetypeprofile.cpp <http://git.reviewboard.kde.org/r/105603/#comment12639> same here. kdecore/sycoca/ksycoca.cpp <http://git.reviewboard.kde.org/r/105603/#comment12640> same here - David Faure On July 17, 2012, 11:24 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105603/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 11:24 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > There's two i didn't do because use isDestroyed and David suggested that'll > get into 5.1 > > In ktimezone i removed the &* which i guess might be needed before but not > now what we get a pointer directly > > There's more in kdelibs but i just wanted a first review on this to make sure > i'm not doing something totally wrong and thus have to redo something. > > > Diffs > ----- > > kdecore/date/kdatetime.cpp 9d01afb > kdecore/date/ksystemtimezone.cpp 770e8c8 > kdecore/date/ktimezone.cpp 66279a8 > kdecore/io/kdebug.cpp 528a68a > kdecore/kernel/ktoolinvocation.h ad669fd > kdecore/kernel/ktoolinvocation.cpp af0cecb > kdecore/localization/klocalizedstring.cpp 333ea37 > kdecore/services/kmimetypefactory.cpp 8e42169 > kdecore/services/kmimetypetrader.h 4267c19 > kdecore/services/kmimetypetrader.cpp bf2274e > kdecore/services/kservicefactory.cpp 7265ca9 > kdecore/services/kservicegroupfactory.cpp 79001dd > kdecore/services/kservicetypefactory.cpp 490a05f > kdecore/services/kservicetypeprofile.cpp 0629a8c > kdecore/services/kservicetypetrader.h f403e9d > kdecore/services/kservicetypetrader.cpp ac6c0d9 > kdecore/sycoca/ksycoca.cpp 5b91377 > > Diff: http://git.reviewboard.kde.org/r/105603/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Albert Astals Cid > >
