Re: Review Request: Rebuild fake locale as soon as possible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101509/ --- (Updated June 5, 2011, 12:23 a.m.) Review request for kdelibs. Summary (

Review Request: Rebuild fake locale as soon as possible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101509/ --- Review request for kdelibs. Summary --- By calling locale() instead o

Re: Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101477/#review3671 --- This review has been submitted with commit 67625dcea346e1f54da4

Re: Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101477/#review3670 --- This review has been submitted with commit 8ea273f60ef6b55609dd

Re: Review Request: a very little fix

> On May 24, 2011, 5:33 p.m., Jaime Torres Amate wrote: > > kdecore/config/kconfigdata.h, line 265 > > > > > > Even better, change it to log the previous value and the new one. > > But look, it is commented. ye

Re: Review Request: Two important KUrlCompletion fixes...

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101499/#review3667 --- This review has been submitted with commit d9997d711e493416a35a

Re: Review Request: kcm-grub2

Konstantinos Smanis writes: > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he > has agreed to give up his request for inclusion in extragear. > > Our conversation has been over plain e-mails, so I cannot prove this. > Perhaps I should contact him to confirm this? That sound

Re: Review Request: kcm-grub2

Raphael Kubo da Costa gmail.com> writes: > Konstantinos Smanis gmail.com> writes: > > > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis > > gmail.com> wrote: > >>> The following line should probably be simplified (see > >>> http://websvn.kde.org/?revision=1184860&view=revision): > >>> > >>>

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- (Updated June 3, 2011, 10:09 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

> On June 3, 2011, 7:58 p.m., Dawit Alemayehu wrote: > > Looks good, however should the new if statements have an else that > > defaulted to previous behavior ? That is should not > > > > if ( !(m & XValue) ) > > x = this->x(); > > if ( !(m & YValue) ) > > y = this->y(); > > >

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- (Updated June 3, 2011, 6:58 p.m.) Review request for kdelibs. Changes --