Re: Review Request: Two important KUrlCompletion fixes...

2011-06-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101499/ --- (Updated June 4, 2011, 5:12 a.m.) Review request for kdelibs. Changes --

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-06-03 Thread Dawit A
Hello Maksim, Do you have any plans for pushing this into git master/KDE 4.6 branch ? Either your patch or mine needs to make it into KDE 4.7. On Sat, May 28, 2011 at 11:02 AM, Maksim Orlovich wrote: > Or you could just do this 1-line + comments change: > commit 4c65ecb9fb5ca6aba393189a818e2cfcb

Review Request: Two important KUrlCompletion fixes...

2011-06-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101499/ --- Review request for kdelibs. Summary --- The attached patch fixes two

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

2011-06-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3653 --- Looks good, however should the new if statements have an else th

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

2011-06-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3651 --- kdeui/widgets/kmainwindow.cpp

Review Request: Do not emit KLineEdit::textEdited when a user scrolls through the popup completion list

2011-06-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101498/ --- Review request for kdelibs. Summary --- Currently it is impossible to

Re: [Kde-hardware-devel] Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-06-03 Thread Bart Cerneels
On Thu, Jun 2, 2011 at 23:39, Friedrich W. H. Kossebau wrote: > Hi, > > (all follow-ups only to kde-core-devel please, copying also amarok-devel this > time to get your attention and comments, amarokers) > > guess you are still heavily occupied by more important things, Nikhil :) > Still  I think

Re: Review Request: Update KActionCollection member documentation

2011-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101494/#review3649 --- This review has been submitted with commit 1fde3604395dc5a75c23

Re: Command line options stripped for KUniqueApplication

2011-06-03 Thread Urban Widmark
On Fri, May 27, 2011 at 11:54 AM, Aaron J. Seigo wrote: > one other little "gotcha" is that some unique apps do open a new window when > launched a second time, just in the same process. it would be really nice if > such applications could note that they do so and thus always leave the flags > alo

Re: Review Request: Preffer new hunspell library over the old one in the finder

2011-06-03 Thread Tomáš Chvátal
> On June 2, 2011, 8:51 a.m., Christoph Feck wrote: > > HUNSPELL is the only optional dependency that is missing from my kdelibs > > build, so I cannot test, but if you say it works better this way, please > > commit :) Hmm, unless having account on identity mean that I also have write access

Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

2011-06-03 Thread Urban Widmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/ --- Review request for kdelibs. Summary --- When an X geometry is given o