-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101499/
-----------------------------------------------------------
(Updated June 4, 2011, 5:12 a.m.)
Review request for kdelibs.
Changes
-------
Updated description and added more bug reports to the bugs list.
Summary (updated)
-------
The attached patch fixes two long stand bugs in KUrlCompletion:
#1. No completion for executables when the mode is set to
KUrlCompletion::ExeCompletion as reported in the bugs listed above.
#2. For every text completion request a new directory listing thread is
unnecessarily created due to a logic error in KUrlCompletion::customEvent. This
means that every keypress in the location bar of apps like Konqueror, Dolphin
and the input box of Krunner causes the the creation of a new directory lister
thread when in reality none needs to be created until there is a directory
change, e.g. if you type /usr/ instead of two lister threads (for / and /usr/)
you get 5 for each and every key press.
This addresses bugs 77169, 116639 and 158124.
http://bugs.kde.org/show_bug.cgi?id=77169
http://bugs.kde.org/show_bug.cgi?id=116639
http://bugs.kde.org/show_bug.cgi?id=158124
Diffs
-----
kio/kio/kurlcompletion.cpp 86aa9d3
Diff: http://git.reviewboard.kde.org/r/101499/diff
Testing
-------
Made sure executable completion in KOpenWith dialog works correctly.
Made sure a directory lister thread is not created for every completion request
(completion should be much faster).
Made sure the unit test class, kurlcompletiontest, passes with the fixes.
Thanks,
Dawit
