https://bugs.kde.org/show_bug.cgi?id=404888
Rhys Kidd changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #14 from Rhys Kidd ---
OK, I'll land this autotools cleanup series sometime this week.
Will spin up a separate series that sets the minimum autoconf version, and
drops the need for some hacks for functionality that valgrind can now rely upo
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #13 from Julian Seward ---
(In reply to Rhys Kidd from comment #11)
> autoconf-2.60released 2006-06-26
> autoconf-2.63released 2008-09-09
>
> Even autoconf-2.68 is nearly a decade old having been released on
> 2010-09-22.
>
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #12 from Julian Seward ---
(In reply to Rhys Kidd from comment #10)
> At the end of the block the "-Werror" is reverted, and autotools continues
> to the next block.
Ah, yes. I was aware of the flag save/restore game, but I didn't know tha
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #11 from Rhys Kidd ---
(In reply to Julian Seward from comment #9)
> (In reply to Rhys Kidd from comment #7)
> > I also wonder whether valgrind should be explicit about a minimum supported
> > version of autoconf (via AC_PREREQ() macro)?
>
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #10 from Rhys Kidd ---
(In reply to Julian Seward from comment #8)
> One minor question:
>
> 0004-config-Conditionalize-finline-functions-on-compiler-.patch
>
> +safe_CFLAGS=$CFLAGS
> +CFLAGS="-finline-functions -Werror"
>
> Why -Werror f
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #9 from Julian Seward ---
(In reply to Rhys Kidd from comment #7)
> I also wonder whether valgrind should be explicit about a minimum supported
> version of autoconf (via AC_PREREQ() macro)?
I would be in favour of that. My only comment is
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #8 from Julian Seward ---
Rhys, thank you for the cleanup patches. I know next to nothing about
auto*, but these look OK to land, at least to my inexperienced eye. One
minor question:
0004-config-Conditionalize-finline-functions-on-compil
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #7 from Rhys Kidd ---
I also wonder whether valgrind should be explicit about a minimum supported
version of autoconf (via AC_PREREQ() macro)? This would allow some of the
existing backwards compatible hacks to be dropped.
The only current
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #6 from Rhys Kidd ---
Created attachment 118419
--> https://bugs.kde.org/attachment.cgi?id=118419&action=edit
0006-Add-missing-documentation-file-from-EXTRA_DIST.patch
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #5 from Rhys Kidd ---
Created attachment 118418
--> https://bugs.kde.org/attachment.cgi?id=118418&action=edit
0005-macOS-Don-t-duplicate-fno-stack-protector.patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #4 from Rhys Kidd ---
Created attachment 118417
--> https://bugs.kde.org/attachment.cgi?id=118417&action=edit
0004-config-Conditionalize-finline-functions-on-compiler-.patch
--
You are receiving this mail because:
You are watching all bu
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #3 from Rhys Kidd ---
Created attachment 118416
--> https://bugs.kde.org/attachment.cgi?id=118416&action=edit
0003-Makefile.am-Consistent-indent-and-align.patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #2 from Rhys Kidd ---
Created attachment 118415
--> https://bugs.kde.org/attachment.cgi?id=118415&action=edit
0002-config-Set-automake-options-consistenly-in-one-locat.patch
--
You are receiving this mail because:
You are watching all bu
https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #1 from Rhys Kidd ---
Created attachment 118414
--> https://bugs.kde.org/attachment.cgi?id=118414&action=edit
0001-config-remove-unrequired-AC_HEADER_STDC.patch
--
You are receiving this mail because:
You are watching all bug changes.
15 matches
Mail list logo
