https://bugs.kde.org/show_bug.cgi?id=404888
--- Comment #10 from Rhys Kidd <rhysk...@gmail.com> --- (In reply to Julian Seward from comment #8) > One minor question: > > 0004-config-Conditionalize-finline-functions-on-compiler-.patch > > +safe_CFLAGS=$CFLAGS > +CFLAGS="-finline-functions -Werror" > > Why -Werror for the test compiler invokation? Is that standard? Yes, this is an approach used many times within Valgrind's configure.ac. Look for any of the examples of: safe_CFLAGS=$CFLAGS CFLAGS="$CFLAGS <something> -Werror" ... CFLAGS=$safe_CFLAGS Between the first and last line, the CFLAGS is temporarily overwritten with the compiler option we are testing for the presence of. The "-Werror" works to cause a hard error if the compiler option isn't present, which is then handled. At the end of the block the "-Werror" is reverted, and autotools continues to the next block. -- You are receiving this mail because: You are watching all bug changes.
