https://bugs.kde.org/show_bug.cgi?id=464870
Ralf Habacker changed:
What|Removed |Added
Version Fixed In|5.1.4 |5.2
--
You are receiving this mail because:
Yo
https://bugs.kde.org/show_bug.cgi?id=464870
Jack changed:
What|Removed |Added
Resolution|--- |FIXED
Status|CONFIRMED |RE
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #13 from Jack ---
OK, my c++ reading ability is far worse than I thought. Even debugging through
the Qt code, I somehow missed the switch from the call to item() to the call to
text(). Adding a check before calling text() would certainly w
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #12 from Thomas Baumgart ---
QStandardItem has no problem. Looking at the codeline in question
symbol = m_file->m_model->item(row, symbolCol)->text().trimmed();
the first part "m_file->m_model->item(row, symbolCol)" returns a n
https://bugs.kde.org/show_bug.cgi?id=464870
Jack changed:
What|Removed |Added
Status|REPORTED|CONFIRMED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #10 from Jack ---
Even though the csv import wizard clearly shows Start Line as 1 and End Line as
6, within sortLines m_startLine is -2 (from csvimporterrc) and m_endLine is 5
(which I assume is correct after changing 1 based counting for hu
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #9 from Jack ---
I agree a central check is good - perhaps whenever those values get changed. I
don't think this crash is simply because item() returns a null pointer, but
because something crashes in the depths of Qt during the call to ite
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #8 from Thomas Baumgart ---
I would not want to check that before every loop but in a central spot. If
start is -7 and end is -1 then the for loop still gets executed because -7 is
less than -1. The crash happens on this line
sy
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #7 from Jack ---
I wonder whether it is StartLine (or m_profile->m_startline) being negative
that leads to the crash.
The importer has plenty of loops with "for (int row = m_profile->m_startLine;
row <= m_profile->m_endLine; ++row)" which
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #6 from Thomas Baumgart ---
Looking at the following two parameters in the rc file
StartLine=2
TrailerLines=12
and the code in CSVFile::getStartEndRow(CSVProfile *profile) explains how
m_startLine can become negative if the number of rows
https://bugs.kde.org/show_bug.cgi?id=464870
Jack changed:
What|Removed |Added
Resolution|WAITINGFORINFO |---
Status|NEEDSINFO |REPO
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #4 from Jack ---
I have reproduced the crash with a new user using the csvimporterrc from
comment2. Running in a debugger, in CSVImporterCore::sortSecurities, the row
number starts out negative, even when I set the start and end rows to imp
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #3 from gza...@gmail.com ---
Created attachment 155757
--> https://bugs.kde.org/attachment.cgi?id=155757&action=edit
CSV to import
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=464870
--- Comment #2 from gza...@gmail.com ---
Created attachment 155756
--> https://bugs.kde.org/attachment.cgi?id=155756&action=edit
csvimporterrc
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=464870
Thomas Baumgart changed:
What|Removed |Added
Resolution|--- |WAITINGFORINFO
Status|REPORTED
15 matches
Mail list logo
