[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125518369 ## src/site/markdown/index.md: ## @@ -19,102 +19,110 @@ Build cache is an extension targeted to simplify and make more efficient work wit

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125519077 ## src/site/markdown/index.md: ## @@ -19,102 +19,110 @@ Build cache is an extension targeted to simplify and make more efficient work wit

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125519680 ## src/site/markdown/index.md: ## @@ -19,102 +19,110 @@ Build cache is an extension targeted to simplify and make more efficient work wit

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125521474 ## src/site/markdown/getting-started.md: ## @@ -17,58 +17,66 @@ ## Getting Started -To on-board incremental Maven you need to complete s

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125521474 ## src/site/markdown/getting-started.md: ## @@ -17,58 +17,66 @@ ## Getting Started -To on-board incremental Maven you need to complete s

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #40: Cache documentation improvements

2023-03-04 Thread via GitHub
AlexanderAshitkin commented on code in PR #40: URL: https://github.com/apache/maven-build-cache-extension/pull/40#discussion_r1125521474 ## src/site/markdown/getting-started.md: ## @@ -17,58 +17,66 @@ ## Getting Started -To on-board incremental Maven you need to complete s

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #179: [MSHADE-420] create IT: 2 runs with different TZ give different jars

2023-03-04 Thread via GitHub
michael-o commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1125524556 ## src/it/projects/MSHADE-420/invoker.properties: ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor l

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-04 Thread via GitHub
michael-o commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125530205 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] michael-o commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-04 Thread via GitHub
michael-o commented on PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1454864534 Just those two and I will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-mvnd] psiroky opened a new issue, #798: 0.10.0-SNAPSHOT is leaking heap memory via ThreadLocal

2023-03-04 Thread via GitHub
psiroky opened a new issue, #798: URL: https://github.com/apache/maven-mvnd/issues/798 I was testing the latest bits from the `mvnd-0.10.x` branch (built locally) and noticed an increasing heap usage with every consequent build (of the same project). I am using the Quarkus project (tag 2.16

[GitHub] [maven] elharo opened a new pull request, #1034: restore src/mdo/reader.vm

2023-03-04 Thread via GitHub
elharo opened a new pull request, #1034: URL: https://github.com/apache/maven/pull/1034 How do I hate got? Let me count the ways. In any case, this PR should bring the repo back to the state it was in before an accidental commit to master. -- This is an automated message from the

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-04 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125615482 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-04 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125615482 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125616374 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1455024007 @michael-o, I pushed my educated guess about what you asked me to do in a separate commit to be reviewable separately. If it looks OK for you and you want me to squash and forc

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
michael-o commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125637005 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
michael-o commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125637146 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125638854 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125638933 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] asfgit closed pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
asfgit closed pull request #110: [MSHADE-400] Self-minimisation with custom entry points URL: https://github.com/apache/maven-shade-plugin/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1455059620 Um, sorry @michael-o, what was the rationale behind first asking me for improvements, me consequently doing them and you then not merging them but deciding for the code without

[GitHub] [maven-jar-plugin] slawekjaranowski merged pull request #59: [MJAR-293] Update Parent to 39

2023-03-05 Thread via GitHub
slawekjaranowski merged PR #59: URL: https://github.com/apache/maven-jar-plugin/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #56: URL: https://github.com/apache/maven-jar-plugin/pull/56#issuecomment-1455063794 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #60: URL: https://github.com/apache/maven-jar-plugin/pull/60#issuecomment-1455063913 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #60: URL: https://github.com/apache/maven-jar-plugin/pull/60#issuecomment-1455063967 Looks like apache/maven-gh-actions-shared is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #61: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #61: URL: https://github.com/apache/maven-jar-plugin/pull/61#issuecomment-1455063976 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] dependabot[bot] closed pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
dependabot[bot] closed pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3 URL: https://github.com/apache/maven-jar-plugin/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-jar-plugin] slawekjaranowski closed pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
slawekjaranowski closed pull request #56: Bump maven-plugins from 37 to 39 URL: https://github.com/apache/maven-jar-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-jar-plugin/pull/56#issuecomment-1455064494 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version

[GitHub] [maven-shade-plugin] slachiewicz merged pull request #170: Bump mrm-maven-plugin from 1.4.1 to 1.5.0

2023-03-05 Thread via GitHub
slachiewicz merged PR #170: URL: https://github.com/apache/maven-shade-plugin/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven] elharo merged pull request #1034: restore src/mdo/reader.vm

2023-03-05 Thread via GitHub
elharo merged PR #1034: URL: https://github.com/apache/maven/pull/1034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] elharo opened a new pull request, #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
elharo opened a new pull request, #1035: URL: https://github.com/apache/maven/pull/1035 The goal is to keep committers (i.e. me) from accidentally pushing straight into master. I think this does that, but I've only done this before through the github UI so please review carefully. -- Thi

[GitHub] [maven] michael-o commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
michael-o commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455085949 Well, this will also add overhead if you fix a typo and are safe to push directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [maven-shared-io] elharo opened a new pull request, #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo opened a new pull request, #20: URL: https://github.com/apache/maven-shared-io/pull/20 spotless also did some trivial formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455092495 There appears to be a pre-existing formatting issue: ``` [INFO] Index file does not exist. Fallback to an empty index WARNING: An illegal reflective access operation has

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455094613 I assumed the parent was previously blocked by JDK 7, but maybe removing that will bypass the broken spotless checks. Frankly, spotless is too buggy and I wish we weren't using it, but

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455096798 Reverting the parent does seem to sidestep the spotless bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [maven-shared-io] elharo merged pull request #18: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
elharo merged PR #18: URL: https://github.com/apache/maven-shared-io/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-shared-io] elharo commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455099647 added JIRA issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-shared-io] elharo merged pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo merged PR #20: URL: https://github.com/apache/maven-shared-io/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-shared-io] slachiewicz commented on pull request #19: prefer Apache Commons IO to maven-shared-utils

2023-03-05 Thread via GitHub
slachiewicz commented on PR #19: URL: https://github.com/apache/maven-shared-io/pull/19#issuecomment-1455106278 Please squash commits and create jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-shared-io] slachiewicz commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
slachiewicz commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455106550 Jira should be in commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [maven-shared-io] slachiewicz commented on pull request #18: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
slachiewicz commented on PR #18: URL: https://github.com/apache/maven-shared-io/pull/18#issuecomment-1455106948 Jira ticket please so it will be visible in release note -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-shared-utils] elharo opened a new pull request, #134: update parent to 39

2023-03-05 Thread via GitHub
elharo opened a new pull request, #134: URL: https://github.com/apache/maven-shared-utils/pull/134 This required a lot of automatic reformatting and a little manual reformatting to make spotless happy -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-shared-utils] elharo commented on pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo commented on PR #129: URL: https://github.com/apache/maven-shared-utils/pull/129#issuecomment-1455108610 can't pass the spotless checks, recreating manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-shared-utils] elharo closed pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo closed pull request #129: Bump maven-shared-components from 37 to 39 URL: https://github.com/apache/maven-shared-utils/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-shared-utils] dependabot[bot] commented on pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #129: URL: https://github.com/apache/maven-shared-utils/pull/129#issuecomment-1455108626 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ve

[GitHub] [maven-shared-io] elharo commented on pull request #19: prefer Apache Commons IO to maven-shared-utils

2023-03-05 Thread via GitHub
elharo commented on PR #19: URL: https://github.com/apache/maven-shared-io/pull/19#issuecomment-1455110124 squash and merge will squash commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-shared-io] elharo merged pull request #21: [MSHARED-894] prefer Apache Commons IOUtils to Maven shared utils

2023-03-05 Thread via GitHub
elharo merged PR #21: URL: https://github.com/apache/maven-shared-io/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-shared-io] slachiewicz commented on pull request #21: [MSHARED-894] prefer Apache Commons IOUtils to Maven shared utils

2023-03-05 Thread via GitHub
slachiewicz commented on PR #21: URL: https://github.com/apache/maven-shared-io/pull/21#issuecomment-1455112107 Missing Jira id in commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [maven-doxia] michael-o opened a new pull request, #155: [DOXIA-700] Streamline, update and simplify Doxia ID generation

2023-03-05 Thread via GitHub
michael-o opened a new pull request, #155: URL: https://github.com/apache/maven-doxia/pull/155 This closes #155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455114415 Looking into... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven] cstamas commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
cstamas commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455129880 And this prevents release plugin as well (when released from master)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [maven-doxia-sitetools] asfgit merged pull request #86: [DOXIASITETOOLS-291] Add timezone field to site descriptor PublishDat…

2023-03-05 Thread via GitHub
asfgit merged PR #86: URL: https://github.com/apache/maven-doxia-sitetools/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455140553 Why is it invalid? Every valid XHTML should work with the Doxia parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455141137 > Why is it invalid? Every valid XHTML should work with the Doxia parser. Very good question, at least the diff doesn't look suspicious: https://github.com/apache/maven-doxia/co

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455141281 Maybe this is it: ``` - Feature Summary + Feature Summary ``` Give it a shot. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455144415 I wrote that already in the JIRA ticket: the culprit is https://github.com/apache/maven-doxia/blob/37173794270ee68894aac0e252dcb87545770952/doxia-core/src/main/java/org/apache/maven/doxia/p

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455144678 But the exception is totally misleading... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] hboutemy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
hboutemy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455145429 > And this prevents release plugin as well (when doing a release from master)? this one would be a blocker to me -- This is an automated message from the Apache Git Service. To re

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455147272 @rfscholte @michael-o I just had a long talk with @hboutemy and we also discussed this merge request. As an option that I'm fine with; how about I split this merge reque

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455147388 I'd say Doxia should not try to heal the document... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455148204 > @rfscholte @michael-o I just had a long talk with @hboutemy and we also discussed this merge request. > > As an option that I'm fine with; how about I split this merge reque

[GitHub] [maven-release] hboutemy opened a new pull request, #169: [MRELEASE-431] add user documentation for version policies

2023-03-05 Thread via GitHub
hboutemy opened a new pull request, #169: URL: https://github.com/apache/maven-release/pull/169 https://issues.apache.org/jira/browse/MRELEASE-431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455157684 Ok, then I'll change this in the coming weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455159340 > Ok, then I'll change this in the coming weeks. Dank U! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455169695 > I'd say Doxia should not try to heal the document... Maybe that is rather up for discussion with a follow-up issue. Right now I would only want to fix the missing close element met

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455170737 > > I'd say Doxia should not try to heal the document... > > Maybe that is rather up for discussion with a follow-up issue. Right now I would only want to fix the missing close

[GitHub] [maven-wrapper] slawekjaranowski merged pull request #93: [MWRAPPER-77] Bump plexus-archiver from 4.6.1 to 4.6.2

2023-03-05 Thread via GitHub
slawekjaranowski merged PR #93: URL: https://github.com/apache/maven-wrapper/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-wrapper] slawekjaranowski merged pull request #71: [MWRAPPER-85] mention distributionType

2023-03-05 Thread via GitHub
slawekjaranowski merged PR #71: URL: https://github.com/apache/maven-wrapper/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven] olamy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
olamy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455206222 > > And this prevents release plugin as well (when doing a release from master)? > > this one would be a blocker to me just saying nothing really prevents. create a branch `relea

[GitHub] [maven] michael-o commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
michael-o commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455207415 > > > And this prevents release plugin as well (when doing a release from master)? > > > > > > this one would be a blocker to me > > just saying nothing really prevents.

[GitHub] [maven-verifier] slachiewicz merged pull request #67: Bump junit-jupiter from 5.9.1 to 5.9.2

2023-03-05 Thread via GitHub
slachiewicz merged PR #67: URL: https://github.com/apache/maven-verifier/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[GitHub] [maven-enforcer] slachiewicz closed pull request #234: Bump mockito.version from 4.11.0 to 5.0.0

2023-03-05 Thread via GitHub
slachiewicz closed pull request #234: Bump mockito.version from 4.11.0 to 5.0.0 URL: https://github.com/apache/maven-enforcer/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #234: Bump mockito.version from 4.11.0 to 5.0.0

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #234: URL: https://github.com/apache/maven-enforcer/pull/234#issuecomment-1455213528 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependen

[GitHub] [maven-shared-utils] elharo commented on pull request #134: [MSHARED-1196] Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo commented on PR #134: URL: https://github.com/apache/maven-shared-utils/pull/134#issuecomment-1455216170 Ick. I blame spotless, which is not so spotless. Let me see if I can fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [maven] olamy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
olamy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455217071 > > > > And this prevents release plugin as well (when doing a release from master)? > > > > > > > > > this one would be a blocker to me > > > > > > just saying nothing r

[GitHub] [maven] michael-o commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
michael-o commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455217572 > > > > > And this prevents release plugin as well (when doing a release from master)? > > > > > > > > > > > > this one would be a blocker to me > > > > > > > > > jus

[GitHub] [maven] olamy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
olamy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455219147 > > > > > > And this prevents release plugin as well (when doing a release from master)? > > > > > > > > > > > > > > > this one would be a blocker to me > > > > > > > > >

[GitHub] [maven] michael-o commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
michael-o commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455219603 > > > > > > > And this prevents release plugin as well (when doing a release from master)? > > > > > > > > > > > > > > > > > > this one would be a blocker to me > > > > >

[GitHub] [maven-shared-utils] elharo commented on pull request #134: [MSHARED-1196] Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo commented on PR #134: URL: https://github.com/apache/maven-shared-utils/pull/134#issuecomment-1455226028 OK, I think the duplicate licenses are removed. I am very much not a fan of spotless at this point. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-dependency-analyzer] elharo commented on pull request #73: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
elharo commented on PR #73: URL: https://github.com/apache/maven-dependency-analyzer/pull/73#issuecomment-1455244168 temp files in tests are not a security issue. No info is disclosed that's not freely available in the open source code. -- This is an automated message from the Apache Git

[GitHub] [maven-dependency-analyzer] elharo closed pull request #73: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
elharo closed pull request #73: [SECURITY] Fix Temporary File Information Disclosure Vulnerability URL: https://github.com/apache/maven-dependency-analyzer/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455250593 Taking things out is much simpler than making things :) I took out the version policy itself and the related documentation and comments. I did leave some of the documenta

[GitHub] [maven] olamy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
olamy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455251625 > > > > > > I don't see the problem here. Can you explain? > > You have `maven-3.8.x` ready for `3.8.25` release. so create a branch `release/3.8.25`, then start the release process

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #299: Bump jetty-webapp from 9.4.49.v20220914 to 10.0.14

2023-03-05 Thread via GitHub
dependabot[bot] opened a new pull request, #299: URL: https://github.com/apache/maven-indexer/pull/299 Bumps [jetty-webapp](https://github.com/eclipse/jetty.project) from 9.4.49.v20220914 to 10.0.14. Release notes Sourced from https://github.com/eclipse/jetty.project/releases";>jet

[GitHub] [maven-release] dependabot[bot] opened a new pull request, #170: Bump wagonVersion from 3.5.1 to 3.5.3

2023-03-05 Thread via GitHub
dependabot[bot] opened a new pull request, #170: URL: https://github.com/apache/maven-release/pull/170 Bumps `wagonVersion` from 3.5.1 to 3.5.3. Updates `wagon-provider-api` from 3.5.1 to 3.5.3 Commits https://github.com/apache/maven-wagon/commit/20b847446bb60f49af0428d592ead

[GitHub] [maven-release] dependabot[bot] commented on pull request #141: Bump wagonVersion from 3.5.1 to 3.5.2

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #141: URL: https://github.com/apache/maven-release/pull/141#issuecomment-1455457029 Superseded by #170. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-release] dependabot[bot] closed pull request #141: Bump wagonVersion from 3.5.1 to 3.5.2

2023-03-05 Thread via GitHub
dependabot[bot] closed pull request #141: Bump wagonVersion from 3.5.1 to 3.5.2 URL: https://github.com/apache/maven-release/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [maven-release] dependabot[bot] opened a new pull request, #171: Bump mrm-maven-plugin from 1.4.1 to 1.5.0

2023-03-05 Thread via GitHub
dependabot[bot] opened a new pull request, #171: URL: https://github.com/apache/maven-release/pull/171 Bumps [mrm-maven-plugin](https://github.com/mojohaus/mrm) from 1.4.1 to 1.5.0. Release notes Sourced from https://github.com/mojohaus/mrm/releases";>mrm-maven-plugin's releases.

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455509462 I'll add a very small test to ensure these new connection points for the version policies. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #49: Bump junit-jupiter-engine from 5.8.1 to 5.9.2

2023-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #49: URL: https://github.com/apache/maven-build-cache-extension/pull/49 Bumps [junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.8.1 to 5.9.2. Release notes Sourced from https://github.com/junit-team/junit5/releases";>juni

[GitHub] [maven] cstamas merged pull request #1025: [MNG-7715] Update to resolver 1.9.6

2023-03-06 Thread via GitHub
cstamas merged PR #1025: URL: https://github.com/apache/maven/pull/1025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven-mvnd] psiroky commented on issue #798: 0.10.0-SNAPSHOT is leaking heap memory via ThreadLocal

2023-03-06 Thread via GitHub
psiroky commented on issue #798: URL: https://github.com/apache/maven-mvnd/issues/798#issuecomment-1455809665 Here are some more details from my investigation: * the `ThreadLocal` instances are held by the `Thread-0` thread, which is the main "accept" thread https://github.com/apache/ma

[GitHub] [maven] cstamas opened a new pull request, #1036: [MNG-7715] Update to resolver 1.9.6

2023-03-06 Thread via GitHub
cstamas opened a new pull request, #1036: URL: https://github.com/apache/maven/pull/1036 Adjust some UTs as error message did change. --- https://issues.apache.org/jira/browse/MNG-7715 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-06 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455817608 Done. I think this is good now. @michael-o WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven] cstamas merged pull request #1036: [MNG-7715] Update to resolver 1.9.6

2023-03-06 Thread via GitHub
cstamas merged PR #1036: URL: https://github.com/apache/maven/pull/1036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven-mvnd] gnodet commented on issue #798: 0.10.0-SNAPSHOT is leaking heap memory via ThreadLocal

2023-03-06 Thread via GitHub
gnodet commented on issue #798: URL: https://github.com/apache/maven-mvnd/issues/798#issuecomment-1456051730 @psiroky your analysis looks good to me, and the solution too. Could you raise a PR and handle the exception so that it's at least logged ? -- This is an automated message from th

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-06 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1456057194 Note: This should really be squashed ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-dependency-plugin] elharo commented on pull request #290: use Apache Commons StringUtil

2023-03-06 Thread via GitHub
elharo commented on PR #290: URL: https://github.com/apache/maven-dependency-plugin/pull/290#issuecomment-1456069342 Failure might be flaky or perhaps platform dependent? [INFO] - Error: The following builds failed: Error: * ana

<    1   2   3   4   5   6   7   8   9   10   >