kriegaex commented on code in PR #110:
URL:
https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125616374
##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -964,11 +992,16 @@ private List<Filter> getFilters()
if ( minimizeJar )
{
- getLog().info( "Minimizing jar " + project.getArtifact() );
+ if ( entryPoints == null )
+ {
+ entryPoints = new HashSet<>();
+ }
+ getLog().info( "Minimizing jar " + project.getArtifact()
+ + ( entryPoints.isEmpty() ? "" : ", entry points = " +
entryPoints ) );
Review Comment:
So I should not log any info at all about the minimisation step, or just not
the entry points? I always like to see what is going on in a Maven build, and
the information in debug mode is somewhat overwhelming. But if you tell me how
you like it or how it is customary, I shall comply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
