[jira] [Commented] (MPLUGIN-504) [regression] Goal prefix is required now

2024-06-07 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853053#comment-17853053 ] Romain Manni-Bucau commented on MPLUGIN-504: Well a warning should always be

Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]

2024-06-07 Thread via GitHub
adangel commented on PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150#issuecomment-2154245477 Thank you as well! > I will take care of the next release. Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the n

Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]

2024-06-07 Thread via GitHub
adangel merged PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853055#comment-17853055 ] ASF GitHub Bot commented on MPMD-395: - adangel commented on PR #150: URL: https://githu

[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853056#comment-17853056 ] ASF GitHub Bot commented on MPMD-395: - adangel merged PR #150: URL: https://github.com/

[jira] [Closed] (MPMD-395) Build doesn't fail for invalid CPD format

2024-06-07 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-395. --- Resolution: Fixed Fixed with https://github.com/apache/maven-pmd-plugin/commit/76f7e114a8ac92898c0307d

Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]

2024-06-07 Thread via GitHub
michael-o commented on PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150#issuecomment-2154254116 > Thank you as well! > > > I will take care of the next release. > > Just for this fix I don't think a new release is needed immediately. It's sufficient, if this la

[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853058#comment-17853058 ] ASF GitHub Bot commented on MPMD-395: - michael-o commented on PR #150: URL: https://git

[jira] [Commented] (MPLUGIN-504) [regression] Goal prefix is required now

2024-06-07 Thread Jira
[ https://issues.apache.org/jira/browse/MPLUGIN-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853059#comment-17853059 ] Christoph Läubrich commented on MPLUGIN-504: Just out of curiosity I looked

Re: [PR] Move modelVersion inference to model builder so that it is also effective on consumer models [maven]

2024-06-07 Thread via GitHub
gnodet merged PR #1566: URL: https://github.com/apache/maven/pull/1566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-8141] Model builder should report problems it finds during build [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1556: URL: https://github.com/apache/maven/pull/1556#issuecomment-2154610047 This change is wrong, am about to roll it back and do alternative fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [MNG-8141] Model builder should report problems it finds during build [maven]

2024-06-07 Thread via GitHub
cstamas closed pull request #1565: [MNG-8141] Model builder should report problems it finds during build URL: https://github.com/apache/maven/pull/1565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [MNG-8141] Model builder should report problems it finds during build [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1565: URL: https://github.com/apache/maven/pull/1565#issuecomment-2154610405 This change is wrong, dropping it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853106#comment-17853106 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1556: URL: https://gith

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853107#comment-17853107 ] ASF GitHub Bot commented on MNG-8141: - cstamas closed pull request #1565: [MNG-8141] Mo

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853108#comment-17853108 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1565: URL: https://gith

Re: [PR] [MNG-8141] Model builder should report problems it finds during build [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1556: URL: https://github.com/apache/maven/pull/1556#issuecomment-2154611727 Reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853110#comment-17853110 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1556: URL: https://gith

Re: [PR] [MNG-7266] Remove maven-compat [maven]

2024-06-07 Thread via GitHub
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2154676402 Preparing Maven 3.6.3 releases are ongoing. As soon as they are finished I will rebase my work on top of these and check all UTs and ITs. -- This is an automated message from the Apache

[jira] [Commented] (MNG-7266) Remove maven-compat module

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853120#comment-17853120 ] ASF GitHub Bot commented on MNG-7266: - michael-o commented on PR #1487: URL: https://gi

Re: [PR] [MPH-183] Effective POM path to source [maven-help-plugin]

2024-06-07 Thread via GitHub
jjkester commented on PR #37: URL: https://github.com/apache/maven-help-plugin/pull/37#issuecomment-2154684302 Marked ready for review on behalf of @juulhobert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (MPH-183) Effective-pom + verbose should show import path to BOM dependencyManagement

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853122#comment-17853122 ] ASF GitHub Bot commented on MPH-183: jjkester commented on PR #37: URL: https://github.c

[jira] [Commented] (MPLUGIN-504) [regression] Goal prefix is required now

2024-06-07 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853127#comment-17853127 ] Romain Manni-Bucau commented on MPLUGIN-504: yes you are right, warnings wer

Re: [PR] [MPMD-397] Upgrade to Maven 3.6.3 [maven-pmd-plugin]

2024-06-07 Thread via GitHub
michael-o closed pull request #151: [MPMD-397] Upgrade to Maven 3.6.3 URL: https://github.com/apache/maven-pmd-plugin/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (MPMD-397) Upgrade to Maven 3.6.3

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853133#comment-17853133 ] ASF GitHub Bot commented on MPMD-397: - michael-o closed pull request #151: [MPMD-397] U

[jira] [Closed] (MPMD-397) Upgrade to Maven 3.6.3

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPMD-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-397. --- Resolution: Fixed Fixed with [872fcd87d292abe9a28774201840651f98233142|https://gitbox.apache.org/repos

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
michael-o commented on PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#issuecomment-2154768007 > In CI I see `Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:4.0.0-M15:site (default-site) on project MCHECKSTYLE-357: Error generating maven-

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
romani commented on PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#issuecomment-2154785665 > Obviously this: https://github.com/hazendaz/maven-checkstyle-plugin/commit/714c075158b70f085bd16722b460bc850e897059? yes -- This is an automated message from the

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
romani commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631174243 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio.

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
michael-o commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631201984 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.n

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853148#comment-17853148 ] ASF GitHub Bot commented on MNG-8141: - cstamas opened a new pull request, #1567: URL: h

[PR] grammar [maven-verifier]

2024-06-07 Thread via GitHub
elharo opened a new pull request, #90: URL: https://github.com/apache/maven-verifier/pull/90 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Updated] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8141: - Summary: Model Builder should report if not sure about "fully correct" outcome (was: Model Builder

[jira] [Updated] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8141: - Description: ModelBuilder is component building models (POM + interpolating + parent inheritance a

[jira] [Updated] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8141: - Description: ModelBuilder is component building models (POM + interpolating + parent inheritance a

[PR] [MCHANGELOG-119] - Add option to disable displaying file and file rev… [maven-changelog-plugin]

2024-06-07 Thread via GitHub
juulhobert opened a new pull request, #21: URL: https://github.com/apache/maven-changelog-plugin/pull/21 …ision information on report -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MCHANGELOG-119) Add option to disable displaying file and file revision information on report

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCHANGELOG-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853165#comment-17853165 ] ASF GitHub Bot commented on MCHANGELOG-119: --- juulhobert opened a new pull r

[jira] [Created] (MCHANGELOG-156) Add option to render the changelog as document

2024-06-07 Thread Juul Hobert (Jira)
Juul Hobert created MCHANGELOG-156: -- Summary: Add option to render the changelog as document Key: MCHANGELOG-156 URL: https://issues.apache.org/jira/browse/MCHANGELOG-156 Project: Maven Changelog Plug

[PR] [MPH-189] Get rid of commons lang3 dependency [maven-help-plugin]

2024-06-07 Thread via GitHub
Giovds opened a new pull request, #114: URL: https://github.com/apache/maven-help-plugin/pull/114 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [MPH-189](https://issues.apache.org/jira/browse/MPH-189) filed

[jira] [Commented] (MPH-189) Get rid of commons-lang3

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPH-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853179#comment-17853179 ] ASF GitHub Bot commented on MPH-189: Giovds opened a new pull request, #114: URL: https:

Re: [PR] [MPH-189] Get rid of commons lang3 dependency [maven-help-plugin]

2024-06-07 Thread via GitHub
Giovds commented on PR #114: URL: https://github.com/apache/maven-help-plugin/pull/114#issuecomment-2154998465 This requires the DefaultArtifactVersion to drop commons-lang3 in the maven-artifact module. This was just recently done with https://issues.apache.org/jira/browse/MNG-8146 and PR

[jira] [Commented] (MPH-189) Get rid of commons-lang3

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPH-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853180#comment-17853180 ] ASF GitHub Bot commented on MPH-189: Giovds commented on PR #114: URL: https://github.c

[jira] [Updated] (MCHANGELOG-156) Add option to render the changelog as document

2024-06-07 Thread Juul Hobert (Jira)
[ https://issues.apache.org/jira/browse/MCHANGELOG-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juul Hobert updated MCHANGELOG-156: --- Description: The changelog plugin uses `SiteRendererSink` as default Sink implementation.

[jira] [Commented] (MCHANGELOG-156) Add option to render the changelog as document

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCHANGELOG-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853184#comment-17853184 ] Michael Osipov commented on MCHANGELOG-156: --- Please note that any think tha

[jira] [Comment Edited] (MCHANGELOG-156) Add option to render the changelog as document

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCHANGELOG-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853184#comment-17853184 ] Michael Osipov edited comment on MCHANGELOG-156 at 6/7/24 2:57 PM:

Re: [PR] [MNG-8141] Do not loose model builder warnings [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1567: URL: https://github.com/apache/maven/pull/1567#issuecomment-2155034787 The reproducer now looks like this https://gist.github.com/cstamas/36903dd7701cbae94d5971211e835b05 And is good, goal is to raise awareness to a presence of invalid model in the build. B

[jira] [Created] (MNG-8147) Profile interpolation broke their evaluation

2024-06-07 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8147: Summary: Profile interpolation broke their evaluation Key: MNG-8147 URL: https://issues.apache.org/jira/browse/MNG-8147 Project: Maven Issue Type: Bug

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853186#comment-17853186 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1567: URL: https://gith

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
michael-o commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631410232 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.n

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
rnveach commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631419056 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
rnveach commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631419056 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio

Re: [I] Set `MAVEN_CMD_LINE_ARGS` env [maven-mvnd]

2024-06-07 Thread via GitHub
gsmet closed issue #1008: Set `MAVEN_CMD_LINE_ARGS` env URL: https://github.com/apache/maven-mvnd/issues/1008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-07 Thread via GitHub
michael-o commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631430729 ## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.n

Re: [I] Set `MAVEN_CMD_LINE_ARGS` env [maven-mvnd]

2024-06-07 Thread via GitHub
gsmet commented on issue #1008: URL: https://github.com/apache/maven-mvnd/issues/1008#issuecomment-2155141104 Thanks for the answer. Let's close this one. I'll see if there are any other alternatives. -- This is an automated message from the Apache Git Service. To respond to the message,

[I] mvnd version support Maven 3.9.6+ [maven-mvnd]

2024-06-07 Thread via GitHub
gsmet opened a new issue, #1009: URL: https://github.com/apache/maven-mvnd/issues/1009 Hi, Quarkus is not yet compatible with Maven 4 (and it will probably require some major work on our side) so we stick to Maven 3.9.x. To my knowledge, Maven 3.9.6 is the first version to actu

[jira] [Commented] (MNG-8147) Profile interpolation broke their evaluation

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853208#comment-17853208 ] ASF GitHub Bot commented on MNG-8147: - cstamas opened a new pull request, #1568: URL: h

[jira] [Assigned] (MNG-8147) Profile interpolation broke their evaluation

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8147: Assignee: Tamas Cservenak > Profile interpolation broke their evaluation > -

Re: [PR] [MNG-8141] Do not loose model builder warnings [maven]

2024-06-07 Thread via GitHub
cstamas closed pull request #1567: [MNG-8141] Do not loose model builder warnings URL: https://github.com/apache/maven/pull/1567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MNG-8141] Do not loose model builder warnings [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1567: URL: https://github.com/apache/maven/pull/1567#issuecomment-2155184832 Superseded by https://github.com/apache/maven/pull/1568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853215#comment-17853215 ] ASF GitHub Bot commented on MNG-8141: - cstamas closed pull request #1567: [MNG-8141] Do

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853216#comment-17853216 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1567: URL: https://gith

[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853219#comment-17853219 ] Tamas Cservenak commented on MNG-8131: -- Latest PR [https://github.com/apache/maven/pul

Re: [PR] [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplicate IDs present [maven]

2024-06-07 Thread via GitHub
jgneff commented on PR #1568: URL: https://github.com/apache/maven/pull/1568#issuecomment-2155213002 Thank you, Tamás. On the one hand, I agree that it might be better to issue a warning in version 3.9.8 instead of no warning in version 3.9.6 and an unexplained build failure in version 3.9.

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853221#comment-17853221 ] ASF GitHub Bot commented on MNG-8141: - jgneff commented on PR #1568: URL: https://githu

Re: [PR] [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplicate IDs present [maven]

2024-06-07 Thread via GitHub
cstamas commented on PR #1568: URL: https://github.com/apache/maven/pull/1568#issuecomment-2155216005 My plan is to port same thing to 4 (same behaviour). Maven4 _builds just fine_ the reproducer https://gist.github.com/cstamas/aacd00e7cdc902d23921c6698bdbab49 But does not warn (yet)

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853222#comment-17853222 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1568: URL: https://gith

Re: [PR] [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplicate IDs present [maven]

2024-06-07 Thread via GitHub
michael-o commented on code in PR #1568: URL: https://github.com/apache/maven/pull/1568#discussion_r1631493948 ## maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java: ## @@ -137,7 +137,7 @@ private static String toMessage(String modelId,

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853225#comment-17853225 ] ASF GitHub Bot commented on MNG-8141: - michael-o commented on code in PR #1568: URL: ht

Re: [PR] [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplicate IDs present [maven]

2024-06-07 Thread via GitHub
cstamas commented on code in PR #1568: URL: https://github.com/apache/maven/pull/1568#discussion_r1631500181 ## maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java: ## @@ -137,7 +137,7 @@ private static String toMessage(String modelId,

[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853226#comment-17853226 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on code in PR #1568: URL: http

[jira] [Updated] (MNG-8146) Drop use of commons-lang

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8146: - Component/s: Dependencies > Drop use of commons-lang > > >

[jira] [Updated] (MNG-8066) Maven hangs on self-referencing exceptions

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8066: - Component/s: Core > Maven hangs on self-referencing exceptions > --

[jira] [Updated] (MNG-8147) Profile interpolation broke their evaluation in case of duplicate IDs

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8147: - Summary: Profile interpolation broke their evaluation in case of duplicate IDs (was: Profile inter

[jira] [Updated] (MNG-8147) Profile interpolation broke their evaluation in case of duplicate IDs

2024-06-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8147: - Description: To be clear: we talk about invalid POMs, as you cannot build using a POM that contain

[jira] [Created] (MCLEAN-119) Upgrade Parent to 42

2024-06-07 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MCLEAN-119: -- Summary: Upgrade Parent to 42 Key: MCLEAN-119 URL: https://issues.apache.org/jira/browse/MCLEAN-119 Project: Maven Clean Plugin Issue Type: Depen

Re: [PR] [MCLEAN-119] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-clean-plugin]

2024-06-07 Thread via GitHub
slawekjaranowski merged PR #44: URL: https://github.com/apache/maven-clean-plugin/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Closed] (MCLEAN-119) Upgrade Parent to 42

2024-06-07 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MCLEAN-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCLEAN-119. -- Resolution: Fixed > Upgrade Parent to 42 > > > Key

[jira] [Commented] (MCLEAN-119) Upgrade Parent to 42

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCLEAN-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853255#comment-17853255 ] ASF GitHub Bot commented on MCLEAN-119: --- slawekjaranowski merged PR #44: URL: https

Re: [PR] Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.2 [maven-clean-plugin]

2024-06-07 Thread via GitHub
slawekjaranowski commented on PR #43: URL: https://github.com/apache/maven-clean-plugin/pull/43#issuecomment-2155367302 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.2 [maven-clean-plugin]

2024-06-07 Thread via GitHub
dependabot[bot] closed pull request #43: Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.2 URL: https://github.com/apache/maven-clean-plugin/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.2 [maven-clean-plugin]

2024-06-07 Thread via GitHub
dependabot[bot] commented on PR #43: URL: https://github.com/apache/maven-clean-plugin/pull/43#issuecomment-2155367671 Looks like org.junit.jupiter:junit-jupiter-api is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] mvnd version support Maven 3.9.6+ [maven-mvnd]

2024-06-07 Thread via GitHub
gnodet commented on issue #1009: URL: https://github.com/apache/maven-mvnd/issues/1009#issuecomment-2155368650 Yes, we're planning a mvnd release based on upcoming Maven 3.9.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] Build with Maven 4 [maven-clean-plugin]

2024-06-07 Thread via GitHub
slawekjaranowski opened a new pull request, #45: URL: https://github.com/apache/maven-clean-plugin/pull/45 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) f

[jira] [Created] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-07 Thread Michael Osipov (Jira)
Michael Osipov created MJAVADOC-796: --- Summary: Do not follow links for Java 12+ Key: MJAVADOC-796 URL: https://issues.apache.org/jira/browse/MJAVADOC-796 Project: Maven Javadoc Plugin Issue

Re: [PR] Bump org.springframework.security:spring-security-core from 5.5.8 to 5.7.12 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child [maven-javadoc-plugin]

2024-06-07 Thread via GitHub
michael-o closed pull request #272: Bump org.springframework.security:spring-security-core from 5.5.8 to 5.7.12 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child URL: https://github.com/apache/maven-javadoc-plugin/pull/272 -- This is an automated message from the Apache Git Ser

Re: [PR] Bump org.springframework.security:spring-security-core from 5.5.8 to 5.7.12 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child [maven-javadoc-plugin]

2024-06-07 Thread via GitHub
dependabot[bot] commented on PR #272: URL: https://github.com/apache/maven-javadoc-plugin/pull/272#issuecomment-2155509196 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] Fix usage documentation mentioning `nohelp` default value [maven-javadoc-plugin]

2024-06-07 Thread via GitHub
asfgit merged PR #286: URL: https://github.com/apache/maven-javadoc-plugin/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[PR] [MJAVADOC-796] Do not follow links for Java 12+ [maven-javadoc-plugin]

2024-06-07 Thread via GitHub
michael-o opened a new pull request, #287: URL: https://github.com/apache/maven-javadoc-plugin/pull/287 This closes #287 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/j

[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853277#comment-17853277 ] ASF GitHub Bot commented on MJAVADOC-796: - michael-o opened a new pull request,

Re: [PR] [MDEP-923] Move methods in place where are used [maven-dependency-plugin]

2024-06-07 Thread via GitHub
slawekjaranowski merged PR #407: URL: https://github.com/apache/maven-dependency-plugin/pull/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Commented] (MDEP-923) Code cleanups

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853279#comment-17853279 ] ASF GitHub Bot commented on MDEP-923: - slawekjaranowski merged PR #407: URL: https://gi

[jira] [Created] (MSKINS-248) If $bodyContent is empty HTML code is distorted

2024-06-07 Thread Michael Osipov (Jira)
Michael Osipov created MSKINS-248: - Summary: If $bodyContent is empty HTML code is distorted Key: MSKINS-248 URL: https://issues.apache.org/jira/browse/MSKINS-248 Project: Maven Skins Issue T

[jira] [Commented] (MSKINS-248) If $bodyContent is empty HTML code is distorted

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853280#comment-17853280 ] ASF GitHub Bot commented on MSKINS-248: --- michael-o opened a new pull request, #61:

[PR] Revert "Fix sources goal for multimodule projects" [maven-dependency-plugin]

2024-06-07 Thread via GitHub
michael-o opened a new pull request, #408: URL: https://github.com/apache/maven-dependency-plugin/pull/408 This reverts commit 0bb4c5917222c4f4a6df53bbc70dd770507a3d4d. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure the

Re: [PR] [MDEP-900] dependency:resolve fails for multi-module project [maven-dependency-plugin]

2024-06-07 Thread via GitHub
michael-o commented on PR #406: URL: https://github.com/apache/maven-dependency-plugin/pull/406#issuecomment-2155545377 Revert is here: #408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (MDEP-900) dependency:resolve fails for multi-module project

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-900: Fix Version/s: (was: 3.7.0) > dependency:resolve fails for multi-module project > ---

[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853281#comment-17853281 ] ASF GitHub Bot commented on MDEP-900: - michael-o commented on PR #406: URL: https://gi

[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853282#comment-17853282 ] Michael Osipov commented on MDEP-900: - For now, this is by design. See PR for reasons.

Re: [PR] [MDEP-895] - dependency:sources fails for multi-module project [maven-dependency-plugin]

2024-06-07 Thread via GitHub
michael-o commented on PR #349: URL: https://github.com/apache/maven-dependency-plugin/pull/349#issuecomment-212938 This PR will be reverted with #408. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Reopened] (MDEP-895) dependency:sources fails for multi-module project

2024-06-07 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MDEP-895: - The applied change changes the semantics and contradicts the actual {{resolve}} operation. The goal is

  1   2   >