[
https://issues.apache.org/jira/browse/MPLUGIN-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853059#comment-17853059
]
Christoph Läubrich commented on MPLUGIN-504:
--------------------------------------------
Just out of curiosity I looked at this very old (about a year) Tycho build and
we get a lot of warnings *but not anything about maven-plugin-plugin*:
https://ci.eclipse.org/tycho/job/tycho-github/job/tycho-3.0.x/108/consoleText
It just happily processes the goal prefix:
{code:java}
[INFO] --- maven-jar-plugin:3.3.0:jar (default-jar) @ tycho-ds-plugin ---
[INFO] Building jar:
/home/jenkins/agent/workspace/tycho-github_tycho-3.0.x/tycho-ds-plugin/target/tycho-ds-plugin-3.0.6-SNAPSHOT.jar
[INFO]
[INFO] --- maven-plugin-plugin:3.9.0:addPluginArtifactMetadata
(default-addPluginArtifactMetadata) @ tycho-ds-plugin ---
[INFO]
[INFO] --- maven-source-plugin:3.2.1:jar-no-fork (default) @ tycho-ds-plugin ---
{code}
so I can't confirm we are getting "warnings for all plugin since 10+ years"...
> [regression] Goal prefix is required now
> ----------------------------------------
>
> Key: MPLUGIN-504
> URL: https://issues.apache.org/jira/browse/MPLUGIN-504
> Project: Maven Plugin Tools
> Issue Type: Bug
> Reporter: Christoph Läubrich
> Priority: Major
>
> With https://issues.apache.org/jira/browse/MPLUGIN-450 there was a regression
> introduced that leads to previous working builds fail if the have not
> configured a goalprefix, the error message is:
> > You need to specify a goalPrefix as it can not be correctly computed
> This has several issues:
> # It does not explain why one "needs" a goalPrefix, nor what it is useful for
> or why it can not be correctly computed.
> # It is effectively a breaking change in a minor version increment
> # The inital JIRA mentions that
> a) in general, goal prefix is *+optional+*, but "good to have", and usually
> is present.
> b) we may want to have some option to turn off this feature
> # Now it is required and there is no option to turn it off
> Also the message is not true, the plugin has successfully computed a prefix
> before without any issues:
> * If the artifact ends with -maven-plugin as in my-cool-maven-plugin the
> my-cool was chosen
> * If the artifact ends with -plugin as in my-cool-plugin the my-cool was
> chosen
> * otherwise the full artifact if was chosen as a prefix as in my-cool the
> my-cool was chosen
> From a users point of view I don't see any problem or "disambiguates" with
> this approach that justifies a breaking change here, anyone who is concerned
> about not using this default can and already could choose a prefix and seem
> to been fine with it for a long time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
