[GitHub] [maven-build-cache-extension] HannesWell commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
HannesWell commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695252436 > > Slf4j simple is enough here... > > Agree but we need one. I had to debug some issues here in the past with docker on GHA and it was really helpful Yo

[GitHub] [maven-build-cache-extension] olamy commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
olamy commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695270809 > > > Slf4j simple is enough here... > > > > > > Agree but we need one. I had to debug some issues here in the past with docker on GHA and it was really helpful

[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly

2023-08-28 Thread via GitHub
kbuntrock commented on code in PR #92: URL: https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1307148551 ## src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java: ## @@ -129,7 +129,8 @@ public void execute( boolean

[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759509#comment-17759509 ] ASF GitHub Bot commented on MBUILDCACHE-67: --- kbuntrock commented on code in

[GitHub] [maven-mvnd] ppalaga commented on issue #879: org.codehaus.mojo:properties-maven-plugin `set-system-properties` goal compatibility

2023-08-28 Thread via GitHub
ppalaga commented on issue #879: URL: https://github.com/apache/maven-mvnd/issues/879#issuecomment-1695386234 Does this happen also with a freshly started daemon? - i.e. after `mvnd --stop`? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-build-cache-extension] olamy commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
olamy commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695398411 logging capability restored here 3b318bbed14703f5d9a539017baefa1060af0310 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-build-cache-extension] olamy commented on a diff in pull request #33: [MBUILDCACHE-32] Do not print exception when probing builds

2023-08-28 Thread via GitHub
olamy commented on code in PR #33: URL: https://github.com/apache/maven-build-cache-extension/pull/33#discussion_r1307253655 ## src/main/java/org/apache/maven/buildcache/RemoteCacheRepositoryImpl.java: ## @@ -144,19 +145,32 @@ public void saveArtifactFile(CacheResult cacheResul

[jira] [Commented] (MBUILDCACHE-32) Do not print exception when probing builds in remote repo

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759535#comment-17759535 ] ASF GitHub Bot commented on MBUILDCACHE-32: --- olamy commented on code in PR

[GitHub] [maven-build-cache-extension] elharo commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
elharo commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695546079 In the short term I'm OK with slf4j-simple but logback should never have been added. It's needless dependency bloat, and every extra dependency is a security risk.

[GitHub] [maven-build-cache-extension] olamy commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
olamy commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695558933 @elharo did you really follow any process here? Some of us added some comments/concerns but you have still merged it. So I'm trying to figure out your comment about the f

[GitHub] [maven-build-cache-extension] elharo commented on pull request #88: remove unused logback dependency

2023-08-28 Thread via GitHub
elharo commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695569108 Absolutely. I sent a PR. People responded. No one disapproved the PR by sending a "Request changes" review. I responded to the comments, received an approval from another

[GitHub] [maven-build-cache-extension] kbuntrock commented on pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-28 Thread via GitHub
kbuntrock commented on PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1695606322 > I'm starting to wonder if the use of the JDK `PathMatcher` is sufficient here. If we want to optimize the file system access and not traverse _all_ files / subdirecto

[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759573#comment-17759573 ] ASF GitHub Bot commented on MBUILDCACHE-64: --- kbuntrock commented on PR #91:

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-28 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1307372298 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759577#comment-17759577 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven-deploy-plugin] slawekjaranowski merged pull request #43: DeployFileMojo#readModel(File): fixed MojoExecutionException javadoc

2023-08-28 Thread via GitHub
slawekjaranowski merged PR #43: URL: https://github.com/apache/maven-deploy-plugin/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Updated] (MBUILDCACHE-1) [Deutsche Bank contribution] Incremental build with local and remote(shared) cache

2023-08-28 Thread Maximilian Novikov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Novikov updated MBUILDCACHE-1: - Description: To scale build process in multi-module projects the following fea

[jira] [Commented] (MNG-7848) Add s390x pipeline to Jenkins CI

2023-08-28 Thread Kun Lu (Jira)
[ https://issues.apache.org/jira/browse/MNG-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759701#comment-17759701 ] Kun Lu commented on MNG-7848: - This issue can be closed since the s390x pipeline has been enabl

[jira] [Created] (MRRESOURCES-135) Show projectTimespan year in UTC

2023-08-28 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MRRESOURCES-135: --- Summary: Show projectTimespan year in UTC Key: MRRESOURCES-135 URL: https://issues.apache.org/jira/browse/MRRESOURCES-135 Project: Maven Remote R

[jira] [Commented] (MRRESOURCES-135) Show projectTimespan year in UTC

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759711#comment-17759711 ] ASF GitHub Bot commented on MRRESOURCES-135: slawekjaranowski merged PR

[jira] [Created] (MRRESOURCES-136) Upgrade Parent to 40

2023-08-28 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MRRESOURCES-136: --- Summary: Upgrade Parent to 40 Key: MRRESOURCES-136 URL: https://issues.apache.org/jira/browse/MRRESOURCES-136 Project: Maven Remote Resources Plu

[jira] [Comment Edited] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759721#comment-17759721 ] Hiran Chaudhuri edited comment on MNG-6523 at 8/28/23 8:07 PM: --

[jira] [Closed] (MRRESOURCES-135) Show projectTimespan year in UTC

2023-08-28 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MRRESOURCES-135. --- Resolution: Fixed > Show projectTimespan year in UTC > -

[jira] [Comment Edited] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759721#comment-17759721 ] Hiran Chaudhuri edited comment on MNG-6523 at 8/28/23 8:06 PM: --

[jira] [Commented] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759721#comment-17759721 ] Hiran Chaudhuri commented on MNG-6523: -- There is a project that I'd like to base my wo

[jira] [Comment Edited] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759721#comment-17759721 ] Hiran Chaudhuri edited comment on MNG-6523 at 8/28/23 8:08 PM: --

[jira] [Created] (MCOMPILER-544) ZipException: zip END header not found on POM dependency with Eclipse compiler

2023-08-28 Thread Jira
Václav Haisman created MCOMPILER-544: Summary: ZipException: zip END header not found on POM dependency with Eclipse compiler Key: MCOMPILER-544 URL: https://issues.apache.org/jira/browse/MCOMPILER-544

[jira] [Commented] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759735#comment-17759735 ] Michael Osipov commented on MNG-6523: - [~hiranchaudhuri], you need to complain to the p

[jira] [Commented] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759736#comment-17759736 ] Tamas Cservenak commented on MNG-6523: -- Maven "system" scope is not a real scope, it w

[jira] [Commented] (MRRESOURCES-136) Upgrade Parent to 40

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759737#comment-17759737 ] ASF GitHub Bot commented on MRRESOURCES-136: slawekjaranowski opened a n

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #337: Bump jettyVersion from 9.4.51.v20230217 to 9.4.52.v20230823

2023-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #337: URL: https://github.com/apache/maven-dependency-plugin/pull/337 Bumps `jettyVersion` from 9.4.51.v20230217 to 9.4.52.v20230823. Updates `org.eclipse.jetty:jetty-server` from 9.4.51.v20230217 to 9.4.52.v20230823 Release notes Sourc

[GitHub] [maven] gnodet commented on a diff in pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-08-28 Thread via GitHub
gnodet commented on code in PR #1205: URL: https://github.com/apache/maven/pull/1205#discussion_r1308067100 ## maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java: ## @@ -104,16 +113,53 @@ private TransformerContext getTransformerContext(Map opti

[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759761#comment-17759761 ] ASF GitHub Bot commented on MNG-5862: - gnodet commented on code in PR #1205: URL: https

[jira] [Updated] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2023-08-28 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7055: --- Description: explanation: [{{metadata/plugins}} content in maven-metadata.xml descriptor|https://maven

[jira] [Commented] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759839#comment-17759839 ] Hiran Chaudhuri commented on MNG-6523: -- [~michael-o] Yes, I should and can complain to

[jira] [Comment Edited] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759839#comment-17759839 ] Hiran Chaudhuri edited comment on MNG-6523 at 8/29/23 6:37 AM: --

[jira] [Comment Edited] (MNG-6523) System Dependencies Deprecation

2023-08-28 Thread Hiran Chaudhuri (Jira)
[ https://issues.apache.org/jira/browse/MNG-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759839#comment-17759839 ] Hiran Chaudhuri edited comment on MNG-6523 at 8/29/23 6:39 AM: --