elharo commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1695569108
Absolutely. I sent a PR. People responded. No one disapproved the PR by sending a "Request changes" review. I responded to the comments, received an approval from another committer, and merged. That is exactly how it is supposed to go. What is not supposed to happen is anyone committing anything directly to master and then pushing the branch with no approvals or review. https://github.com/apache/maven-build-cache-extension/commit/3b318bbed14703f5d9a539017baefa1060af0310 could and should have been sent as a PR to be reviewed, and then merged after review and approval like any other change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
