[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125616374 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1455024007 @michael-o, I pushed my educated guess about what you asked me to do in a separate commit to be reviewable separately. If it looks OK for you and you want me to squash and forc

[jira] [Commented] (MNG-7719) Maven 3.9.0 native http transport ignores username/password for basic auth

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696550#comment-17696550 ] Slawomir Jaranowski commented on MNG-7719: -- Testing: {{MAVEN_OPTS=-Dorg.slf4j.simp

[jira] [Comment Edited] (MNG-7719) Maven 3.9.0 native http transport ignores username/password for basic auth

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696550#comment-17696550 ] Slawomir Jaranowski edited comment on MNG-7719 at 3/5/23 10:09 AM: --

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
michael-o commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125637005 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[GitHub] [maven-shade-plugin] michael-o commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
michael-o commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125637146 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[jira] [Updated] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7720: Summary: [REGRESSION] Build order is incorrect and does not respect Reactor Build Order (was: Build

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125638854 ## src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java: ## @@ -156,6 +204,43 @@ private void removeServices( final MavenProject project,

[GitHub] [maven-shade-plugin] kriegaex commented on a diff in pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on code in PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#discussion_r1125638933 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -964,11 +992,16 @@ private List getFilters() if ( minimizeJar )

[jira] [Commented] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696557#comment-17696557 ] Slawomir Jaranowski commented on MNG-7720: -- It happens in forked execution: {nofo

[jira] [Commented] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696558#comment-17696558 ] Slawomir Jaranowski commented on MNG-7720: -- can be connected with MNG-7672 - to ch

[GitHub] [maven-shade-plugin] asfgit closed pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
asfgit closed pull request #110: [MSHADE-400] Self-minimisation with custom entry points URL: https://github.com/apache/maven-shade-plugin/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Closed] (MSHADE-400) Self-minimisation with custom entry points

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHADE-400. - Resolution: Fixed Fixed with [45dcf07f09cd4c896812024898cd1906a74a17f2|https://gitbox.apache.org

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696561#comment-17696561 ] Michael Osipov commented on MSHADE-420: --- [~hboutemy], so should we remove the entry

[jira] [Created] (MARTIFACT-46) Mark Spring Boot Maven Plugin from 2.7.1 as reproducible

2023-03-05 Thread Michael Osipov (Jira)
Michael Osipov created MARTIFACT-46: --- Summary: Mark Spring Boot Maven Plugin from 2.7.1 as reproducible Key: MARTIFACT-46 URL: https://issues.apache.org/jira/browse/MARTIFACT-46 Project: Maven Artifa

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

2023-03-05 Thread via GitHub
kriegaex commented on PR #110: URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1455059620 Um, sorry @michael-o, what was the rationale behind first asking me for improvements, me consequently doing them and you then not merging them but deciding for the code without

[GitHub] [maven-jar-plugin] slawekjaranowski merged pull request #59: [MJAR-293] Update Parent to 39

2023-03-05 Thread via GitHub
slawekjaranowski merged PR #59: URL: https://github.com/apache/maven-jar-plugin/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Closed] (MJAR-293) Update Parent to 39

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MJAR-293. Fix Version/s: next-release Assignee: Slawomir Jaranowski Resolution: Fixed >

[jira] [Closed] (MARTIFACT-46) Mark Spring Boot Maven Plugin from 2.7.1 as reproducible

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MARTIFACT-46. --- Resolution: Fixed Fixed with [8b9553c1ce68825c0fb403c502a659d6e8cea05e|https://gitbox.apa

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #56: URL: https://github.com/apache/maven-jar-plugin/pull/56#issuecomment-1455063794 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #60: URL: https://github.com/apache/maven-jar-plugin/pull/60#issuecomment-1455063913 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #60: URL: https://github.com/apache/maven-jar-plugin/pull/60#issuecomment-1455063967 Looks like apache/maven-gh-actions-shared is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-jar-plugin] slawekjaranowski commented on pull request #61: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-05 Thread via GitHub
slawekjaranowski commented on PR #61: URL: https://github.com/apache/maven-jar-plugin/pull/61#issuecomment-1455063976 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-jar-plugin] dependabot[bot] closed pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3

2023-03-05 Thread via GitHub
dependabot[bot] closed pull request #60: Bump apache/maven-gh-actions-shared from 2 to 3 URL: https://github.com/apache/maven-jar-plugin/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-jar-plugin] slawekjaranowski closed pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
slawekjaranowski closed pull request #56: Bump maven-plugins from 37 to 39 URL: https://github.com/apache/maven-jar-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #56: Bump maven-plugins from 37 to 39

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-jar-plugin/pull/56#issuecomment-1455064494 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version

[GitHub] [maven-shade-plugin] slachiewicz merged pull request #170: Bump mrm-maven-plugin from 1.4.1 to 1.5.0

2023-03-05 Thread via GitHub
slachiewicz merged PR #170: URL: https://github.com/apache/maven-shade-plugin/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven] elharo merged pull request #1034: restore src/mdo/reader.vm

2023-03-05 Thread via GitHub
elharo merged PR #1034: URL: https://github.com/apache/maven/pull/1034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] elharo opened a new pull request, #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
elharo opened a new pull request, #1035: URL: https://github.com/apache/maven/pull/1035 The goal is to keep committers (i.e. me) from accidentally pushing straight into master. I think this does that, but I've only done this before through the github UI so please review carefully. -- Thi

[GitHub] [maven] michael-o commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
michael-o commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455085949 Well, this will also add overhead if you fix a typo and are safe to push directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [maven-shared-io] elharo opened a new pull request, #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo opened a new pull request, #20: URL: https://github.com/apache/maven-shared-io/pull/20 spotless also did some trivial formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455092495 There appears to be a pre-existing formatting issue: ``` [INFO] Index file does not exist. Fallback to an empty index WARNING: An illegal reflective access operation has

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455094613 I assumed the parent was previously blocked by JDK 7, but maybe removing that will bypass the broken spotless checks. Frankly, spotless is too buggy and I wish we weren't using it, but

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2023-03-05 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696567#comment-17696567 ] Herve Boutemy commented on MSHADE-420: -- it seems we can fix m-shade-p... > Reproduc

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455096798 Reverting the parent does seem to sidestep the spotless bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [maven-shared-io] elharo merged pull request #18: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
elharo merged PR #18: URL: https://github.com/apache/maven-shared-io/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Assigned] (MSHARED-848) Code Improvement in ReaderFactory to get rid of commons-io dependency

2023-03-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHARED-848: - Assignee: Elliotte Rusty Harold > Code Improvement in ReaderFactory to

[jira] [Created] (MSHARED-1195) Set JDK 8 to minimum

2023-03-05 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MSHARED-1195: -- Summary: Set JDK 8 to minimum Key: MSHARED-1195 URL: https://issues.apache.org/jira/browse/MSHARED-1195 Project: Maven Shared Components

[jira] [Updated] (MSHARED-1195) Set minimum JDK to 8

2023-03-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-1195: --- Summary: Set minimum JDK to 8 (was: Set JDK 8 to minimum) > Set minimum JD

[jira] [Assigned] (MSHARED-1195) Set JDK 8 to minimum

2023-03-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHARED-1195: -- Assignee: Elliotte Rusty Harold > Set JDK 8 to minimum > ---

[GitHub] [maven-shared-io] elharo commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455099647 added JIRA issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-shared-io] elharo merged pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
elharo merged PR #20: URL: https://github.com/apache/maven-shared-io/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-shared-io] slachiewicz commented on pull request #19: prefer Apache Commons IO to maven-shared-utils

2023-03-05 Thread via GitHub
slachiewicz commented on PR #19: URL: https://github.com/apache/maven-shared-io/pull/19#issuecomment-1455106278 Please squash commits and create jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-shared-io] slachiewicz commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

2023-03-05 Thread via GitHub
slachiewicz commented on PR #20: URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455106550 Jira should be in commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [maven-shared-io] slachiewicz commented on pull request #18: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-03-05 Thread via GitHub
slachiewicz commented on PR #18: URL: https://github.com/apache/maven-shared-io/pull/18#issuecomment-1455106948 Jira ticket please so it will be visible in release note -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Resolved] (MSHARED-1195) Set minimum JDK to 8

2023-03-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHARED-1195. Resolution: Fixed > Set minimum JDK to 8 > > >

[jira] [Closed] (MSHARED-1195) Set minimum JDK to 8

2023-03-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MSHARED-1195. -- > Set minimum JDK to 8 > > > Key: MSHARED-11

[GitHub] [maven-shared-utils] elharo opened a new pull request, #134: update parent to 39

2023-03-05 Thread via GitHub
elharo opened a new pull request, #134: URL: https://github.com/apache/maven-shared-utils/pull/134 This required a lot of automatic reformatting and a little manual reformatting to make spotless happy -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-shared-utils] elharo commented on pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo commented on PR #129: URL: https://github.com/apache/maven-shared-utils/pull/129#issuecomment-1455108610 can't pass the spotless checks, recreating manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-shared-utils] elharo closed pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
elharo closed pull request #129: Bump maven-shared-components from 37 to 39 URL: https://github.com/apache/maven-shared-utils/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-shared-utils] dependabot[bot] commented on pull request #129: Bump maven-shared-components from 37 to 39

2023-03-05 Thread via GitHub
dependabot[bot] commented on PR #129: URL: https://github.com/apache/maven-shared-utils/pull/129#issuecomment-1455108626 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ve

[GitHub] [maven-shared-io] elharo commented on pull request #19: prefer Apache Commons IO to maven-shared-utils

2023-03-05 Thread via GitHub
elharo commented on PR #19: URL: https://github.com/apache/maven-shared-io/pull/19#issuecomment-1455110124 squash and merge will squash commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-shared-io] elharo merged pull request #21: [MSHARED-894] prefer Apache Commons IOUtils to Maven shared utils

2023-03-05 Thread via GitHub
elharo merged PR #21: URL: https://github.com/apache/maven-shared-io/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-shared-io] slachiewicz commented on pull request #21: [MSHARED-894] prefer Apache Commons IOUtils to Maven shared utils

2023-03-05 Thread via GitHub
slachiewicz commented on PR #21: URL: https://github.com/apache/maven-shared-io/pull/21#issuecomment-1455112107 Missing Jira id in commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Created] (DOXIA-700) Streamline, update and simplify Doxia ID generation

2023-03-05 Thread Michael Osipov (Jira)
Michael Osipov created DOXIA-700: Summary: Streamline, update and simplify Doxia ID generation Key: DOXIA-700 URL: https://issues.apache.org/jira/browse/DOXIA-700 Project: Maven Doxia Issue T

[jira] [Commented] (DOXIA-700) Streamline, update and simplify Doxia ID generation

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696575#comment-17696575 ] Michael Osipov commented on DOXIA-700: -- [~sjaranowski], this fixes the issue from the

[GitHub] [maven-doxia] michael-o opened a new pull request, #155: [DOXIA-700] Streamline, update and simplify Doxia ID generation

2023-03-05 Thread via GitHub
michael-o opened a new pull request, #155: URL: https://github.com/apache/maven-doxia/pull/155 This closes #155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (DOXIA-700) Streamline, update and simplify Doxia ID generation

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696576#comment-17696576 ] ASF GitHub Bot commented on DOXIA-700: -- michael-o opened a new pull request, #155: UR

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455114415 Looking into... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696577#comment-17696577 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[jira] [Updated] (DOXIA-696) Inconsistent anchors between toc macro and headers

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-696: - Fix Version/s: wontfix-candidate > Inconsistent anchors between toc macro and headers > --

[jira] [Commented] (DOXIA-696) Inconsistent anchors between toc macro and headers

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696578#comment-17696578 ] Michael Osipov commented on DOXIA-696: -- I am inclined to close this as won't fix beca

[jira] [Commented] (DOXIA-696) Inconsistent anchors between toc macro and headers

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696581#comment-17696581 ] Michael Osipov commented on DOXIA-696: -- This seems to generate the ID: https://githu

[GitHub] [maven] cstamas commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
cstamas commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455129880 And this prevents release plugin as well (when released from master)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Updated] (DOXIASITETOOLS-292) parent site.xml interpolation seems broken when using distributionManagement

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-292: -- Attachment: example-1.zip > parent site.xml interpolation seems broken

[jira] [Closed] (DOXIASITETOOLS-292) parent site.xml interpolation seems broken when using distributionManagement

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-292. - Resolution: Information Provided This works for me now. Updated the sampl

[GitHub] [maven-doxia-sitetools] asfgit merged pull request #86: [DOXIASITETOOLS-291] Add timezone field to site descriptor PublishDat…

2023-03-05 Thread via GitHub
asfgit merged PR #86: URL: https://github.com/apache/maven-doxia-sitetools/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

[jira] [Closed] (DOXIASITETOOLS-291) Add timezone field to site descriptor PublishDate object and pass onto Velocity tools context

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-291. - Resolution: Fixed Fixed with [6cfcf626d8b08bcddbd368a26e331e29e0bb9e99|h

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455140553 Why is it invalid? Every valid XHTML should work with the Doxia parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696587#comment-17696587 ] ASF GitHub Bot commented on DOXIA-699: -- kwin commented on PR #152: URL: https://githu

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455141137 > Why is it invalid? Every valid XHTML should work with the Doxia parser. Very good question, at least the diff doesn't look suspicious: https://github.com/apache/maven-doxia/co

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455141281 Maybe this is it: ``` - Feature Summary + Feature Summary ``` Give it a shot. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696588#comment-17696588 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696589#comment-17696589 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455144415 I wrote that already in the JIRA ticket: the culprit is https://github.com/apache/maven-doxia/blob/37173794270ee68894aac0e252dcb87545770952/doxia-core/src/main/java/org/apache/maven/doxia/p

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696590#comment-17696590 ] ASF GitHub Bot commented on DOXIA-699: -- kwin commented on PR #152: URL: https://githu

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455144678 But the exception is totally misleading... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696591#comment-17696591 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[GitHub] [maven] hboutemy commented on pull request #1035: protect the master branch to prevent accidental commits

2023-03-05 Thread via GitHub
hboutemy commented on PR #1035: URL: https://github.com/apache/maven/pull/1035#issuecomment-1455145429 > And this prevents release plugin as well (when doing a release from master)? this one would be a blocker to me -- This is an automated message from the Apache Git Service. To re

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455147272 @rfscholte @michael-o I just had a long talk with @hboutemy and we also discussed this merge request. As an option that I'm fine with; how about I split this merge reque

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696594#comment-17696594 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455147388 I'd say Doxia should not try to heal the document... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455148204 > @rfscholte @michael-o I just had a long talk with @hboutemy and we also discussed this merge request. > > As an option that I'm fine with; how about I split this merge reque

[jira] [Updated] (MSITE-860) org.codehaus.plexus.util.xml.PrettyPrintXMLWriter swallows IOExceptions

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-860: - Fix Version/s: (was: 4.0.0-candidate) > org.codehaus.plexus.util.xml.PrettyPrintXMLWriter swal

[GitHub] [maven-release] hboutemy opened a new pull request, #169: [MRELEASE-431] add user documentation for version policies

2023-03-05 Thread via GitHub
hboutemy opened a new pull request, #169: URL: https://github.com/apache/maven-release/pull/169 https://issues.apache.org/jira/browse/MRELEASE-431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (MRELEASE-1114) Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6

2023-03-05 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MRELEASE-1114: Fix Version/s: 3.0.0 > Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra sin

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455157684 Ok, then I'll change this in the coming weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2023-03-05 Thread via GitHub
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1455159340 > Ok, then I'll change this in the coming weeks. Dank U! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455169695 > I'd say Doxia should not try to heal the document... Maybe that is rather up for discussion with a follow-up issue. Right now I would only want to fix the missing close element met

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696606#comment-17696606 ] ASF GitHub Bot commented on DOXIA-699: -- kwin commented on PR #152: URL: https://githu

[GitHub] [maven-doxia] michael-o commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-05 Thread via GitHub
michael-o commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1455170737 > > I'd say Doxia should not try to heal the document... > > Maybe that is rather up for discussion with a follow-up issue. Right now I would only want to fix the missing close

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696607#comment-17696607 ] ASF GitHub Bot commented on DOXIA-699: -- michael-o commented on PR #152: URL: https://

[jira] [Assigned] (MSITE-873) The following plugins are not marked @threadSafe in org.apache.maven.plugins:maven-site-plugin:3.9.1

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSITE-873: Assignee: (was: Michael Osipov) > The following plugins are not marked @threadSafe in

[jira] [Assigned] (MSITE-873) The following plugins are not marked @threadSafe in org.apache.maven.plugins:maven-site-plugin:3.9.1

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSITE-873: Assignee: Michael Osipov > The following plugins are not marked @threadSafe in > org.apach

[GitHub] [maven-wrapper] slawekjaranowski merged pull request #93: [MWRAPPER-77] Bump plexus-archiver from 4.6.1 to 4.6.2

2023-03-05 Thread via GitHub
slawekjaranowski merged PR #93: URL: https://github.com/apache/maven-wrapper/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (MWRAPPER-77) wrapper:wrapper does not update scripts

2023-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696610#comment-17696610 ] ASF GitHub Bot commented on MWRAPPER-77: slawekjaranowski merged PR #93: URL: ht

[jira] [Closed] (MWRAPPER-98) distributionType=script does not overwrite files

2023-03-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MWRAPPER-98. --- Resolution: Duplicate > distributionType=script does not overwrite files > -

[jira] [Closed] (MSITE-709) relativizeDecorationLinks=false seems to be ignored

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-709. Fix Version/s: (was: waiting-for-feedback) (was: wontfix-candidate)

[jira] [Commented] (MSITE-773) The evaluation of the within the settings.xml does not work

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696613#comment-17696613 ] Michael Osipov commented on MSITE-773: -- [~kwin], the referenced method is completely

[jira] [Comment Edited] (MSITE-876) Execution default-deploy of goal ...deploy failed: An API incompatibility was encountered while executing ....deploy: java.lang.NoSuchMethodError: org.apache.maven.

2023-03-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446876#comment-17446876 ] Michael Osipov edited comment on MSITE-876 at 3/5/23 7:09 PM: --

  1   2   >