Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
elharo merged PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
elharo commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1894110082 ## src/main/java/org/apache/maven/plugin/doap/DoapUtil.java: ## @@ -472,16 +471,13 @@ public static void fetchURL(Settings settings, URL url) throws IOException {

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
slawekjaranowski commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893780303 ## src/main/java/org/apache/maven/plugin/doap/DoapUtil.java: ## @@ -472,16 +471,13 @@ public static void fetchURL(Settings settings, URL url) throws IOE

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
slawekjaranowski commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893773202 ## src/test/java/org/apache/maven/plugin/doap/stubs/DoapProjectStub.java: ## @@ -49,20 +50,13 @@ public class DoapProjectStub extends MavenProjectStub {

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
elharo commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893736713 ## src/test/java/org/apache/maven/plugin/doap/stubs/DoapProjectStub.java: ## @@ -49,20 +50,13 @@ public class DoapProjectStub extends MavenProjectStub { */

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
elharo commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1886952613 ## src/main/java/org/apache/maven/plugin/doap/DoapUtil.java: ## @@ -688,24 +684,18 @@ private static String getLowerCaseString(I18N i18n, String key) { */

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
slawekjaranowski commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893689176 ## src/test/java/org/apache/maven/plugin/doap/stubs/DoapProjectStub.java: ## @@ -49,20 +50,13 @@ public class DoapProjectStub extends MavenProjectStub {

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-20 Thread via GitHub
slawekjaranowski commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893687242 ## src/main/java/org/apache/maven/plugin/doap/DoapUtil.java: ## @@ -472,16 +471,13 @@ public static void fetchURL(Settings settings, URL url) throws IOE

Re: [PR] Use try with resources [maven-doap-plugin]

2024-12-16 Thread via GitHub
elharo commented on code in PR #28: URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1886952613 ## src/main/java/org/apache/maven/plugin/doap/DoapUtil.java: ## @@ -688,24 +684,18 @@ private static String getLowerCaseString(I18N i18n, String key) { */