slawekjaranowski commented on code in PR #28:
URL: https://github.com/apache/maven-doap-plugin/pull/28#discussion_r1893780303
##########
src/main/java/org/apache/maven/plugin/doap/DoapUtil.java:
##########
@@ -472,16 +471,13 @@ public static void fetchURL(Settings settings, URL url)
throws IOException {
}
if ("file".equals(url.getProtocol())) {
- InputStream in = null;
- try {
- in = url.openStream();
- in.close();
- in = null;
- } finally {
- IOUtil.close(in);
+ // [ERROR]
src/main/java/org/apache/maven/plugin/doap/DoapUtil.java:[474,53] (blocks)
EmptyBlock: Empty try
+ // block.
+ try (InputStream in = url.openStream()) {
+ return;
+ } catch (IOException ex) {
+ return;
Review Comment:
but exit from method always .... it will be the same:
```java
if ("file".equals(url.getProtocol())) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
