gnodet merged PR #2232:
URL: https://github.com/apache/maven/pull/2232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
desruisseaux commented on PR #2232:
URL: https://github.com/apache/maven/pull/2232#issuecomment-2780706320
Added pull request #2236 as a follow-up of this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2029831812
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028405757
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028395404
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns
gnodet commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028387183
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an emp
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028362207
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##
@@ -149,8 +145,8 @@ public DefaultSourceRoot(
final ProjectScope scope
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028360116
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -59,7 +58,7 @@ default List includes() {
* The exclusions are applied after the
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028358504
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns
