desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028395404
##########
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##########
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
I have not tested how we can specify a Windows drive to
`java.nio.file.FileSystem.getPathMatcher(String)`. I was hopping that, since
all paths are made relative to the base directory before to be tested for
match, the Windows drive issue would be avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
