Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-04-05 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007271894 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-04-04 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007273299 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-04-04 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2742788091 @michael-o @Bukama or other else can you check on Windows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-04-04 Thread via GitHub
michael-o commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007275024 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-8248 +ENAB

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-04-04 Thread via GitHub
Bukama commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2743586805 > @michael-o @Bukama or other else can you check on Windows ``` [INFO] --

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-24 Thread via GitHub
slawekjaranowski merged PR #2171: URL: https://github.com/apache/maven/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745484049 > Thanks for the link, I just had a look. Does anyone know for which services jline needs native access? I'm curious in particular if this is a service that Maven actually uses, an

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
desruisseaux commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745458796 Thanks for the link, I just had a look. Does anyone know for which services jline needs native access? I'm curious in particular if this is a service that Maven actually uses, and whic

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745408963 > Is it adding the `--enable-native-access=ALL-UNNAMED` systematically? If yes, I wonder for which feature, and whether there are safer alternatives? @desruisseaux Please al

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745407374 @Bukama I need a test on Windows use `mvn.cmd` from this PR on JDK 24 warning should not be displayed -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2008834455 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
Bukama commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2743586805 > @michael-o @Bukama or other else can you check on Windows ``` [INFO] --

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007271894 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
michael-o commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007275024 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-8248 +ENAB

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007273299 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
michael-o commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007246671 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-8248 +ENAB

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
desruisseaux commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2742824586 Is it adding the `--enable-native-access=ALL-UNNAMED` systematically? If yes, I wonder for which feature, and whether there are safer alternatives? -- This is an automated message fr

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-21 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2742788091 @michael-o @Bukama or other else can you check on Windows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use