michael-o commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2007246671
########## apache-maven/src/bin/mvn: ########## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-8248 +ENABLE_NATIVE_ACCESS="" +if "$JAVACMD" --enable-native-access=ALL-UNNAMED -version >/dev/null 2>&1; then + ENABLE_NATIVE_ACCESS="--enable-native-access=ALL-UNNAMED" Review Comment: Why not add to `MAVEN_OPTS`? ########## apache-maven/src/bin/mvn: ########## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-8248 +ENABLE_NATIVE_ACCESS="" +if "$JAVACMD" --enable-native-access=ALL-UNNAMED -version >/dev/null 2>&1; then Review Comment: The expectation is that when this does not fail then the JVM access this option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
