[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358812#comment-358812 ] Michael Osipov commented on MPMD-193: - Changed with [r1643992|http://svn.apache.org/r1643992]. Th

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358812#comment-358812 ] Michael Osipov edited comment on MPMD-193 at 12/9/14 1:04 AM: -- Changed w

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358799#comment-358799 ] Andreas Dangel commented on MPMD-193: - Only one call is necessary. I would prefer "setSourceEncod

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-193. --- Resolution: Fixed Fix Version/s: 3.4 Fixed with [r1643612|http://svn.apache.org/r1643612]. Andreas,

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358543#comment-358543 ] Andreas Dangel commented on MPMD-193: - I just released PMD 5.2.2. [~michael-o], could you please

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358569#comment-358569 ] Michael Osipov edited comment on MPMD-193 at 12/4/14 3:43 AM: -- As soon a

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358569#comment-358569 ] Michael Osipov commented on MPMD-193: - As soon as Apache's Subversion master will be online again

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358254#comment-358254 ] Andreas Dangel commented on MPMD-193: - Yes, after MPMD-195 the unit test will turn green (tested

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358246#comment-358246 ] Michael Osipov commented on MPMD-193: - Andi, I am right to assume that this merge is safe after M

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358243#comment-358243 ] Andreas Dangel commented on MPMD-193: - Created a pull request with a unit test: https://github.c

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPMD-193: --- Assignee: Michael Osipov > CPD's sourceEncoding not set since PMD 5.1.1 is used > --

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=357780#comment-357780 ] Michael Osipov commented on MPMD-193: - Andreas, thanks for the update. I will spin another ticket

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=357487#comment-357487 ] Andreas Dangel commented on MPMD-193: - Yes, this internally sets `setSourceEncoding` - and this i

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356839#comment-356839 ] Michael Osipov commented on MPMD-193: - Andreas, this is pretty nice. This properly guarantees tha

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356839#comment-356839 ] Michael Osipov edited comment on MPMD-193 at 11/24/14 2:54 PM: --- Andreas

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356835#comment-356835 ] Andreas Dangel commented on MPMD-193: - The issue in PMD will be fixed with 5.2.2 (commit https:/

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356823#comment-356823 ] Tweea Tang commented on MPMD-193: - I'm not sure the usage of encoding property except in postConstruc

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356821#comment-356821 ] Michael Osipov commented on MPMD-193: - Do we steel need to invoke {{setEncoding}}? > CPD's sourc

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356814#comment-356814 ] Tweea Tang edited comment on MPMD-193 at 11/24/14 9:52 AM: --- Yes, PMD 5.1.1

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356817#comment-356817 ] Tweea Tang commented on MPMD-193: - The new issue on PMD: https://sourceforge.net/p/pmd/bugs/1285/ >

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tweea Tang updated MPMD-193: Description: Since PMD 5.1.1, CPDConfiguration adds a method postContruct(). This method is used to set the source

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356814#comment-356814 ] Tweea Tang commented on MPMD-193: - Yes, PMD 5.1.1 use the sourceEncoding property to read the source

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356806#comment-356806 ] Michael Osipov edited comment on MPMD-193 at 11/24/14 4:33 AM: --- It is e

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356806#comment-356806 ] Michael Osipov commented on MPMD-193: - Does this solve the problem? Is the encoding parameter use

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356806#comment-356806 ] Michael Osipov edited comment on MPMD-193 at 11/24/14 4:33 AM: --- It is e

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tweea Tang updated MPMD-193: Attachment: CpdReport.java(setSourceEncoding).patch I make a new patch that directly use setSourceEncoding() inste

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356790#comment-356790 ] Tweea Tang edited comment on MPMD-193 at 11/23/14 10:35 PM: The System.se

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356790#comment-356790 ] Tweea Tang commented on MPMD-193: - The System.setProperty is evil, but this code is already exist in

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

[ https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356784#comment-356784 ] Michael Osipov commented on MPMD-193: - While this seems to be a valid fix, I reject to patch that

[jira] (MPMD-193) CPD's sourceEncoding not set since PMD 5.1.1 is used

Tweea Tang created MPMD-193: --- Summary: CPD's sourceEncoding not set since PMD 5.1.1 is used Key: MPMD-193 URL: https://jira.codehaus.org/browse/MPMD-193 Project: Maven PMD Plugin Issue Type: Bug