[
https://jira.codehaus.org/browse/MPMD-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356784#comment-356784
]
Michael Osipov commented on MPMD-193:
-------------------------------------
While this seems to be a valid fix, I reject to patch that. The
{{postConstruct}} method is
[evil|https://github.com/pmd/pmd/blob/pmd_releases/5.1.1/pmd/src/main/java/net/sourceforge/pmd/cpd/CPDConfiguration.java#L122-L123].
I absolutely do not want a client lib to modify the system environment.
> CPD's sourceEncoding not set since PMD 5.1.1 is used
> ----------------------------------------------------
>
> Key: MPMD-193
> URL: https://jira.codehaus.org/browse/MPMD-193
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: CPD
> Affects Versions: 3.2, 3.3, 3.4
> Reporter: Tweea Tang
> Attachments: CpdReport.java.patch
>
>
> Since PMD 5.1.1, CPDConfiguration adds a method postContruct().
> This method is used to set the sourceEncoding property added in PMD 5.1.1.
> If the sourceEncoding not set, CPD will use the platform default encoding to
> read the source files and maven-pmd-plugin's encoding has no effects.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
