gnodet closed pull request #269: Upgrade to beta-5
URL: https://github.com/apache/maven-compiler-plugin/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2444392038
Done: https://github.com/apache/maven-compiler-plugin/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gnodet commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2444126366
Could you create a PR from your fork, i think we can close this one in favor
of the new one.
--
This is an automated message from the Apache Git Service.
To respond to the m
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2442021527
Other strange behaviour observed with Maven 4: in the `it/jdk16-annotation`
test, the `test-compile` phase is executed twice. I added a workaround in the
compiler plugin
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2441456531
Note: we still have the following a failure in `src/it/MCOMPILER-346`, but
it seems unrelated to JPMS (I have the same test failure with the pre-JPMS
compiler plugin):
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2441441096
Added support for overwriting `module-info.java` in the tests, as did the
previous compiler plugin. However, the way to support that is [quite
different](https://github.
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2439584172
Reintroduced MCOMPILER-542 (the use of ASM for rewriting `module-info` for
reproducible builds), executed only when the JDK is older than Java 22. Now
working on the cas
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2432230280
> I'd be in favour of porting the JPMS work. This is a beta, and the sooner
we switch, the more feedback we'll have.
I would prefer that too. Maybe we should post
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2432219778
> I don't really understand why this upgrade/release would be required. I've
upgrade other plugins (clean, resource, jar, install, deploy) without upgrading
this depende
gnodet commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2432178029
> I'm investigating the integration test failures. But in the meantime, I
think that we will need in any cases:
>
> * A release of `maven-plugin-tools` beta 2 with [Mave
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2431821418
Tested the integration tests of both this `upgrade-beta-5` branch and the
[JPMS branch](https://github.com/Geomatys/maven-compiler-plugin). The following
are tests faili
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2431692965
I'm investigating the integration test failures. But in the meantime, I
think that we will need in any cases:
* A release of `maven-plugin-tools` beta 2 with [Mave
desruisseaux commented on PR #269:
URL:
https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2430331256
I will check tomorrow (Wednesday).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
13 matches
Mail list logo
