desruisseaux commented on PR #269: URL: https://github.com/apache/maven-compiler-plugin/pull/269#issuecomment-2441441096
Added support for overwriting `module-info.java` in the tests, as did the previous compiler plugin. However, the way to support that is [quite different](https://github.com/Geomatys/maven-compiler-plugin/wiki/Implementation-changes#overwriting-module-info-in-tests) than what Maven 3 did. I think it should be a deprecated practice. With this change and the one in the previous comment, the main concerns expressed on the mailing list should be addressed, except `<source>`/`<target>` versus `<release>`. The latter would be easy to change, but I propose to see if it happens often that `<source>` and `<release>` are defined together, and if yes, identify if they are inherited from the `pom` that we can fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
