Re: [PR] Make asserts meaningful [maven-scm]

elharo merged PR #232: URL: https://github.com/apache/maven-scm/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache

Re: [PR] Make asserts meaningful [maven-scm]

slawekjaranowski commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1899688078 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() t

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1899675713 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E

Re: [PR] Make asserts meaningful [maven-scm]

slawekjaranowski commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1899674135 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() t

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on PR #232: URL: https://github.com/apache/maven-scm/pull/232#issuecomment-2562653238 > The code line `assertNotNull(e.getMessage());` does not check for a specific line of code either. You should then check for a specific exception message. No, that's done with

Re: [PR] Make asserts meaningful [maven-scm]

Bukama commented on PR #232: URL: https://github.com/apache/maven-scm/pull/232#issuecomment-2562251973 > That's not good and the JUnit project no longer recommends it. The problem is it doesn't indicate which line of code threw the exception so you can get false positives — tests that p

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on PR #232: URL: https://github.com/apache/maven-scm/pull/232#issuecomment-2562005615 > The problem is it doesn't indicate which line of code threw the exception so you can get false positives — tests that pass when they shouldn't — when the same exception class gets thro

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on PR #232: URL: https://github.com/apache/maven-scm/pull/232#issuecomment-2562002862 That's not good and the JUnit project no longer recommends it. The problem is it doesn't indicate which line of code threw the exception so you can get false positives — tests that pass wh

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882485075 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882378063 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws Exc

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882376686 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws Exc

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882364748 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882349263 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws Exc

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882341152 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882194582 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws Exc

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882161266 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E

Re: [PR] Make asserts meaningful [maven-scm]

elharo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882153429 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws Exc

Re: [PR] Make asserts meaningful [maven-scm]

pzygielo commented on code in PR #232: URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882130332 ## maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java: ## @@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws E