pzygielo commented on code in PR #232:
URL: https://github.com/apache/maven-scm/pull/232#discussion_r1882161266
##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/ChangeLogMojoTest.java:
##########
@@ -103,7 +103,7 @@ public void testChangeLogWithBadUserDateFormat() throws
Exception {
fail("mojo execution must fail.");
} catch (MojoExecutionException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
Review Comment:
I'd rather see `fail` there replaced with `assertThrows`. This would be
meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
