Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
slawekjaranowski merged PR #76: URL: https://github.com/apache/maven-invoker/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
slawekjaranowski commented on code in PR #76: URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590274270 ## src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java: ## @@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {

Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
slawekjaranowski commented on code in PR #76: URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590269182 ## src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java: ## @@ -552,6 +553,16 @@ enum CheckSumPolicy { */ InvocationRequest addArg

Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
michael-o commented on code in PR #76: URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268823 ## src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java: ## @@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) { retur

Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
michael-o commented on code in PR #76: URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374 ## src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java: ## @@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) { retur

Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]

2024-05-05 Thread via GitHub
slawekjaranowski commented on PR #76: URL: https://github.com/apache/maven-invoker/pull/76#issuecomment-2094686028 @michael-o - done - only minimal changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above