michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
Should we really check for empty arg lines?
```
<args>
<arg> </arg>
</args>
```
??
I mean that is a deliberate input, no?
##########
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##########
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+ /**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
Between "raw" and "arguments" should be one space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
